[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#767063: unblock: claws-mail/3.11.1-1



Hi Niels,

On Wed, Oct 29, 2014 at 10:42:27PM +0100, Niels Thykier wrote:
> On 2014-10-29 10:01, Ricardo Mones wrote:
> > Hi Niels,
> > 
> > On Tue, Oct 28, 2014 at 09:29:58PM +0100, Niels Thykier wrote:
> >>  [...]
> >>
> >> Hi Ricardo,
> >>
> >> The changes seems to contain quite a bit of "noise".  Would you be able
> >> to provide a filtered debdiff between the version in unstable and
> >> testing?  This might give us a better idea of what we will be accepting.
> > 
> > Previous unstable (3.11.0-1) would have naturally migrated to testing
> > this week if nothing done. And that's the version to be replaced by
> > current upload (3.11.1-1).
> > 
> 
> We have clearly stated time and again:
> 
> 
> """
> *Remember*: On the 5th of November, the version of your package *in
> testing* must be in its desired state for Jessie.
> """
> 
> We did this because we learned from a painful experience with Wheezy.
> Things in unstable do not always migrate when people expect it too.
> Yours probably would, but we had far too many issues with it last release.

Well, 3.11.0 was going to be the desired version for jessie and would
have migrate without problem. Unfortunately some addition in that release
(appdata) wasn't as tested as expected and caused some undesired efect,
so upstream decided to rollback those changes and make a quick bugfix
release: 
http://lists.claws-mail.org/pipermail/devel/2014-October/001320.html

To be completely fair: after knowing the problems I myself requested
also that release, because I thought that was the case the pre-freeze
unblocks were made for.

If I had knew beforehand this you're telling me now I wouldn't have acted
that way. And I'm sorry, but I was unable to conclude that from the
announce message (not your fault, of course).

> Then the premise would have been entirely different and I would have a
> different basis for my decisions.  I might have advised you to let
> 3.10.4-1 migrate as it with the promise of accepting the diff if it
> migrated (assuming X was not a "major" issue), or said "ok, we will take
> it 3.11.1-1 immediately and we will unblock it now".

Well, yes, unfortunately I don't have a crystal ball and cannot foresee
if a upstream release is going to cause problems. Since you have mixed
some versions above, and just to make it clear:

 • 3.10.1-4 was _already_ migrated in testing and vulnerable to poodle

 • 3.11.0-1 (released 20/10, uploaded 21/10) fixed poodle, but contained 
            other problems discovered after upload had happened; upstream
            set release date too close to the freeze but enough to migrate,
            so it didn't worried me too much at that moment.

 • 3.11.1-1 (released 27/10, uploaded 20/18) fixed the other problems, just
            one week later but now it was to late to migrate with the 10 day
            delay, and have to request a reduction to 5 days (this very bug)

I could have let 3.11.0 migrate, sure. But also considered there was no need
to expose testing users to undesired upstream changes if simply asking for
a age reduction was going to fix that. Clearly I failed to understand the
side effects of the request.

[…]
> > Or do you really mean debdiff between 3.11.0-1 and 3.11.1-1?
> > 
> 
> No, I truly mean the debdiff between 3.10.4-1 and 3.11.1-1.

Ok, don't expect miracles, since there's a new implementation of RSSyl
plugin between these two releases. Anyway upstream author has take years
(literally) to merge this, so I'm confident the new implementation works
pretty well. No bug reported upstream so far helps too.

Some of the changes are also because added missing license headers, but
I think most of them (caused by Makefile.am files) are filtered out.

Summary of remaining files is (full diff with diffstat attached):

210 files changed, 9403 insertions(+), 5898 deletions(-)

Detail of exclusions:

debdiff --exclude 'Makefile.*' --exclude '*.m4' \     # autostuff and
        --exclude 'config.*' --exclude 'ltmain.sh' \  # Makefile.am

        --exclude '*.pot' \                           # updated
        --exclude '*.po' --exclude '*.gmo' \          # translations

        --exclude 'ChangeLog' \                       # generated from git

        --exclude '*.pdf' --exclude '*.ps' \          # generated docs
        --exclude '*.html' \                          # from docbook XML

        --exclude 'matcher_parser_parse.*' \          # generated parsers
        --exclude 'quote_fmt_lex.*' \                 # from yacc files

        --exclude 'ical*' \                           # some script generated
                                                      # sources within ical
        --diffstat \
        _3_10_1-4/*.dsc _3_11_1-1/*.dsc > debdiff-3.10.1-4_3.11.1-1.diff

If this is not OK for testing, please tell me how to proceeed, since
current 3.10.1-4 in testing should be replaced by some patched version
not vulnerable to poodle or removed.

Thanks in advance,
-- 
  Ricardo Mones 
  ~
  Physics is like sex: sure, it may give some practical results, but 
  that's not why we do it.                            Richard Feynman

Attachment: debdiff-3.10.1-4_3.11.1-1.diff.xz
Description: Binary data

Attachment: signature.asc
Description: Digital signature


Reply to: