Hi Niels,
On Wed, 29 Oct 2014 22:19:38 Niels Thykier wrote:
> Could you clarify what the "improved compatibility with GTK"
> involves/means? What we would gain from accepting the changes, what are
> the consequences of not accepting them?
I'm not sure about the consequences but here is my (limited) understanding of
situation: oxygen-gtk3 depends on gtk+3.0 which historically had little
respect for backward compatibility so oxygen-gtk3 suffered from regressions
with nearly every release of the gtk+3.0. You can get some insights into
situation from the following URL:
https://igurublog.wordpress.com/2012/11/05/gnome-et-al-rotting-in-threes/
New follow-up releases of oxygen-gtk3 typically fix regressions and improve
compatibility with gtk+3.0. Although there were no regressions reported, our
timing is not good and from past experience I'm beginning to feel
uncomfortable knowing that last upload of oxygen-gtk3 was in July 2014 while
new versions of gtk+3.0 were uploaded in August, September and October 2014.
In the "src/oxygenthemingengine.cpp" of just released oxygen-gtk3 I see
conditions like
#if !GTK_CHECK_VERSION( 3, 13, 7 )
appeared to disable code block for current (and later) GTK so it is affecting
code paths. There are also some other changes, see top 7 commits in upstream
repository
https://projects.kde.org/projects/playground/artwork/oxygen-gtk/repository/changes?rev=vgtk3-1.4.1
down to "be5a6f98 2014-07-02 09:50am bumped revision" (previous release
1.4.0).
From past experience I can tell that such small changes are usually
significant although I'm not always able to say exactly what is going to be
affected. Overall I have a gut feeling that it might be important and given
that there is still a little time left before freeze I hope that it's not too
late to accommodate all fixes of 1.4.1.
Looking through history of changes in upstream git I see that among others
1.4.1 fixes the following problem:
* Bug 338538 - checkboxes are no more rendered since gtk+ 3.13.7
* https://bugs.kde.org/show_bug.cgi?id=338538
I vaguely recall that I may have seen this somewhere... IMHO it looks
significant to warrant an unblock hence I've decided to trouble you with it...
Thanks for considering and I hope it makes sense...
--
Regards,
Dmitry Smirnov.
---
Free speech is the bedrock of liberty and a free society. And yes, it
includes the right to blaspheme and offend.
-- Ayaan Hirsi Ali, 2010
Attachment:
signature.asc
Description: This is a digitally signed message part.