[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#763552: marked as done (wheezy-pu: package at/3.1.13-2+deb7u1)

Your message dated Sat, 18 Oct 2014 12:06:30 +0100
with message-id <E1XfRqB-0002TZ-00@jacala>
and subject line Closing bugs for updates in 7.7
has caused the Debian Bug report #763552,
regarding wheezy-pu: package at/3.1.13-2+deb7u1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
763552: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=763552
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: wheezy
User: release.debian.org@packages.debian.org
Usertags: pu

Hi,

I would like to update at in Debian Wheezy: bash can now export
variables of the form BASH_FUNC_*() which at cannot handle as they
cannot be set via assignment in the shell...

With the change below, at will just skip variables that would just
give an error in the generated shell script later. at 3.1.16-1 which I
uploaded to unstable yesterday has the same change.

Ansgar

diff -u at-3.1.13/debian/changelog at-3.1.13/debian/changelog
--- at-3.1.13/debian/changelog
+++ at-3.1.13/debian/changelog
@@ -1,3 +1,11 @@
+at (3.1.13-2+deb7u1) wheezy; urgency=medium
+
+  * at: Only retain variables whose name consists of alphanumerics and
+    underscores. This prevents jobs from failing in case bash exports
+    functions to the environment with the changes from DSA-3035.
+
+ -- Ansgar Burchardt <ansgar@debian.org>  Tue, 30 Sep 2014 20:58:23 +0200
+
 at (3.1.13-2) unstable; urgency=low
 
   * Use debhelper compat level 9 (to enable hardening by default).
only in patch2:
unchanged:
--- at-3.1.13.orig/at.c
+++ at-3.1.13/at.c
@@ -390,6 +390,22 @@
 	int export = 1;
 	char *eqp;
 
+        /* Only accept alphanumerics and underscore in variable names.
+         * Also require the name to not start with a digit.
+         * Some shells don't like other variable names.
+         */
+        {
+            char *p = *atenv;
+            if (isdigit(*p))
+                export = 0;
+            for (; *p != '=' && *p != '\0'; ++p) {
+                if (!isalnum(*p) && *p != '_') {
+                    export = 0;
+                    break;
+                }
+            }
+        }
+
 	eqp = strchr(*atenv, '=');
 	if (ap == NULL)
 	    eqp = *atenv;

--- End Message ---
--- Begin Message --- 
Version: 7.7

The upload discussed in this bug was included in the 7.7 point release.

Regards,

Adam

--- End Message ---
Reply to: