[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#759312: marked as done (wheezy-pu: package gnubg/0.90+20120429-1)

Your message dated Sat, 18 Oct 2014 12:06:30 +0100
with message-id <E1XfRqA-0002SY-KZ@jacala>
and subject line Closing bugs for updates in 7.7
has caused the Debian Bug report #759312,
regarding wheezy-pu: package gnubg/0.90+20120429-1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
759312: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=759312
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: wheezy
User: release.debian.org@packages.debian.org
Usertags: pu

Hello folks,

The current gnubg in stable segfaults during "end game" when run with
the -t flag.  I got a request from one user to fix this in stable, at:

    http://bugs.debian.org/754764

Upstream provided the relevant patch, which is quite straightforward
(attached).  May I upload this to stable for stable-proposed-updates?
The severity of the bug is rather borderline, but the fix is small
and unlikely to introduce any additional issues.

Thanks!

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.14-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

--- a/gtkwindows.c
+++ b/gtkwindows.c
@@ -391,7 +391,7 @@
 
 extern int GTKShowWarning(warningType warning, GtkWidget *pwParent)
 {
-	if (warnings[warning].warningEnabled)
+	if (fX && warnings[warning].warningEnabled)
 	{
 		char *buf;
 		GtkWidget *pwDialog, *pwMsg, *pwv, *label;
--- a/play.c
+++ b/play.c
@@ -3287,7 +3287,9 @@
 	int fDisplay_store = fDisplay;
 	int fQuiet_store = fQuiet;
 #if USE_BOARD3D
-	BoardData *bd = BOARD(pwBoard)->board_data;
+	BoardData *bd;
+	if (fX && pwBoard)
+		bd = BOARD(pwBoard)->board_data;
 #endif
 	const evalcontext ec_quick = { FALSE, 0, FALSE, TRUE, 0.0 };
 	int manual_dice = (rngCurrent == RNG_MANUAL); 
@@ -3326,7 +3328,8 @@
 	}
 
 #if USE_BOARD3D
-	SuspendDiceRolling(bd->rd);
+	if (fX)
+		SuspendDiceRolling(bd->rd);
 #endif
 
 	fAutoGame = FALSE;
@@ -3373,7 +3376,8 @@
 	}
 
 #if USE_BOARD3D
-	ResumeDiceRolling(bd->rd);
+	if (fX)
+		ResumeDiceRolling(bd->rd);
 #endif
 
 	if (!automaticTask)

--- End Message ---
--- Begin Message --- 
Version: 7.7

The upload discussed in this bug was included in the 7.7 point release.

Regards,

Adam

--- End Message ---
Reply to: