[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#736168: pu: package samhain/2.8.3a-1



On Mon, Jan 20, 2014 at 08:57:48PM +0000, Adam D. Barratt wrote:
> Control: tags -1 + wheezy moreinfo
> 
> On Mon, 2014-01-20 at 18:06 +0100, Javier Fernández-Sanguino Peña wrote:
> > I have recently updated Samhain in sid and have fixed some important bugs.  As
> > requested by DSA, since samhain is used in many project machines, I would like
> > to make an upload to the wheezy release including some of these fixes.
> 
> Not that it's a blocker, but do you know if they're planning on testing
> the package once it's uploaded, before the point release?

I'd say yes.

DSA is actually willing test them right now, I've decided to approach you
instead of manually building the test packages myself.


> +samhain (2.8.3a-2) stable; urgency=medium
> 
> In general we'd suggest 2.8.3a-1+deb7u1 here; -2 is okay as long as
> there's never been a package in the Debian archive with that version.

You are right. There's never been a 2.8.3a-2 package but I will use
2.8.3a-1+deb7u1 instead anyway.

> 
> +  * Default samhainrc now uses SetMailAddress=root, SetMailRelay=localhost
> +    since there have been reports of the previous confguration
> +    (SetMailAddress=root@localhost, SetMailRelay=NULL) not working since
> +    samhain tries to retrieve an MX record for 'localhost' from the DNS
> +    (Closes: 709754)
> 
> I think you meant #709753 here; #709754 is an erlang bug.

Yes, its #709753. Thanks for spotting this error. I will fix it in the
changelog.

> Is samhainrc generally customised by users? More specifically, is this
> likely to lead to conffile prompts for a majority of users on upgrade?

Some users might have changed the conffile to use the configuration above but
I cannot be certain. There might be conffile prompts for users but I think
the majority just runs with the standard configuration.

The benefit of the above is that the "standard" configuration will work for
everybody out of the box.

> 
> diff --git a/sql_init/samhain.mysql.init~ b/sql_init/samhain.mysql.init~
> deleted file mode 100644
> diff --git a/sql_init/samhain.oracle.init~ b/sql_init/samhain.oracle.init~
> deleted file mode 100644
> diff --git a/sql_init/samhain.postgres.init~ b/sql_init/samhain.postgres.init~
> deleted file mode 100644
> 
> I'm assuming these are cruft and thus intentionally removed from the
> package, but it would have been helpful to mention that (and preferably
> changelog it).

Yes, this is cruft. I will add to the changelog.

Regards

Javier

Attachment: signature.asc
Description: Digital signature


Reply to: