[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#709947: closed by tytso@mit.edu (Theodore Y. Ts'o) (Bug#708307: fixed in e2fsprogs 1.42.8-1)



On Sat, Aug 10, 2013 at 06:39:33PM +0100, Adam D. Barratt wrote:
> On Thu, 2013-06-27 at 14:01 -0400, Theodore Ts'o wrote:
> > It's a bit more than that.  The full patch is here:
> > 
> > https://git.kernel.org/cgit/fs/ext2/e2fsprogs.git/commit/?h=maint&id=3df6014a3d216d19be7d2286de24e8ee106f18ad
> > 
> > It disables the ability to display a stack trace when e2fsck crashes,
> > which makes it easier for me to debug problems which only occur once
> > and where I can't get access to the file system which provoked the
> > fsck crash.  Disabling reduces long term maintainability and RAS, but
> > doesn't cause any other missing functionality to the user.
> 
> Thanks for the information.
> 
> Assuming that the fix has been tested on stable, please go ahead using
> 1.42.5-1.1+deb7u1 as the version number; apologies for the delay in
> getting back to you regarding this.

We have a minor problem with uploading a fix.  E2fsprogs currently
FTBFS on stable, due to bug #707996, whose root cause is #708061.  

Personally, I blame glibc (#708061) for once again making a
library-visible API change.  (If they didn't want programs to use
__secure_getenv, they shouldn't have made it visible.)

However, the decision was to fix it by forcing a reconfigure and
rebuild of all affected packages --- which in the case of e2fsprogs
FTBFS, requires a rebuild and re-upload of util-linux (#707996).  This
has happened in unstable, but it hasn't happened in stable.

There is (almost) nothing I can do to work around this problem in
e2fsprogs, since the problem is that e2fsck.static is linking against
the blkid library found in util-linux, and it is the blkid library
which is referencing the symbol in glibc which has vanished in a puff
of greasy black smoke.

The (almost) referres to something really, REALLY, horrible which I
could do, which is to use the antique version of the blkid library
found in the e2fsprogs sources, from before we transferred it over to
util-linux.  I could only do this for e2fsck.static, but that would
mean that e2fsck and e2fsck.static would be using different versions
of the blkid library.  Or I could do it for e2fsprogs as well, but
then e2fsck and mke2fs would be using a version of blkid that hasn't
been updated for several years, and which will have all sorts of bugs
and lack features added since the move to util-linux.

The really right answer is to rebuild (it doesn't even require a
source-level change, since I believe the configure script should make
the right thing happen once we build with the glibc with the
gratuitous ABI change) and then reload util-linux.

What say the release team?

Regards,

							- Ted


Reply to: