[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#714940: pu: package ibus-xkbc/1.3.3.20100922-2+deb7u1



On 2013-07-05 14:52, Osamu Aoki wrote:
On Thu, Jul 04, 2013 at 07:57:31PM +0100, Adam D. Barratt wrote:
Control: tags -1 + moreinfo
...
-       dh  --with quilt $@
+       dh  $@ --with autotools-dev

Please could you explain that change?

My thought was based on wrong assumption for stable upload requirements
... but:

 * Aesthetic fix to bogus but seemingly-safe "--with quilt"
 * Aesthetic fix to add normally required "autotools-dev"
   (but this is python so it may be OK without this.)
 * Carried over from unstable fix for bumped debhelper compat level
   for $@ location.

Since compat level of this stable update package is still 7, I should
revert these to match with strict stable updates requirements. Updated
patch and changes are attached.

It's not so much "strict stable update requirements", but more that I didn't understand the intent of the change (dropping the explicit --with-quilt makes sense, the addition of autotools-dev didn't seem obvious to me). If they're not actually required for the stable package though, let's drop them indeed.

Hmmm... I still have removal of "DM-Upload-Allowed: yes". Should I keep
it?

That's fine. It might be nicer if it were mentioned in the changelog though. :)

Regards,

Adam


Reply to: