[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#695764: marked as done (unblock: packagekit/0.7.6-2)

Your message dated Thu, 24 Jan 2013 15:21:10 +0000
with message-id <20130124152110.GG6719@halon.org.uk>
and subject line Re: Bug#695764: unblock: packagekit/0.7.6-2
has caused the Debian Bug report #695764,
regarding unblock: packagekit/0.7.6-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
695764: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=695764
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package packagekit

The new PackageKit revision contains very important fixes for the PK Aptcc
backend.
The bugs found lead to wrong behaviour of the Aptcc backend, e.g. marking
packages as auto-installed if they aren't or emitting/not emitting information
about packages from untrusted sources.
Also, a locking issue is removed, causing packagekitd not to release archive
locks immediately.
It would be great if these patches go into Wheezy, because they fix serious
malfunctions.
Of course, no public API is touched. All patches are available upstream too and
are tested.

At time, because of the DM-permission-migration, the package is not yet
uploaded, but I will be available in unstable this week. (I thought notifying
about this earlier is a good idea)

A full debdiff between the two revisions is attached.
Kind regards,
    Matthias

unblock packagekit/0.7.6-2

-- System Information:
Debian Release: wheezy/sid
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.5.0-19-generic (SMP w/2 CPU cores)

diff -Nru packagekit-0.7.6/debian/changelog packagekit-0.7.6/debian/changelog
--- packagekit-0.7.6/debian/changelog	2012-08-21 16:46:20.000000000 +0200
+++ packagekit-0.7.6/debian/changelog	2012-12-10 20:26:59.000000000 +0100
@@ -1,3 +1,13 @@
+packagekit (0.7.6-2) unstable; urgency=low
+
+  * aptcc: Release remaining lock on the archive after
+     a transaction has completed
+  * aptcc: Fix trusted/untrusted package handling
+  * aptcc: Don't accidentially mark packages as auto-installed
+  * Removed some unused build dependencies
+
+ -- Matthias Klumpp <matthias@tenstral.net>  Mon, 10 Dec 2012 19:16:33 +0100
+
 packagekit (0.7.6-1) unstable; urgency=low
 
   * New upstream bugfix release: 0.7.6
diff -Nru packagekit-0.7.6/debian/control packagekit-0.7.6/debian/control
--- packagekit-0.7.6/debian/control	2012-08-21 16:46:20.000000000 +0200
+++ packagekit-0.7.6/debian/control	2012-12-10 20:26:59.000000000 +0100
@@ -14,7 +14,6 @@
                gtk-doc-tools,
                libapt-pkg-dev (>= 0.8.14),
                libarchive-dev,
-               libcppunit-dev,
                libgirepository1.0-dev (>= 0.10.1),
                libglib2.0-dev (>= 2.24),
                libgstreamer-plugins-base0.10-dev,
@@ -22,8 +21,6 @@
                libgtk2.0-dev (>= 2.24),
                libnm-glib-dev [linux-any],
                libnspr4-dev,
-               libpam0g-dev,
-               libpolkit-backend-1-dev,
                libpolkit-gobject-1-dev,
                libqt4-dev,
                libsqlite3-dev,
diff -Nru packagekit-0.7.6/debian/patches/01_aptcc_untrusted-trusted-pkgs.patch packagekit-0.7.6/debian/patches/01_aptcc_untrusted-trusted-pkgs.patch
--- packagekit-0.7.6/debian/patches/01_aptcc_untrusted-trusted-pkgs.patch	1970-01-01 01:00:00.000000000 +0100
+++ packagekit-0.7.6/debian/patches/01_aptcc_untrusted-trusted-pkgs.patch	2012-12-10 20:26:59.000000000 +0100
@@ -0,0 +1,51 @@
+From 580ad4fc6269a8ab85e9136a00d3738037ec0303 Mon Sep 17 00:00:00 2001
+From: Daniel Nicoletti <dantti12@gmail.com>
+Date: Fri, 30 Nov 2012 19:25:15 -0200
+Subject: [PATCH] aptcc: Fix trusted packages not being emitted when an untrusted package was available
+ Backported to PackageKit 0.7.x series by Matthias Klumpp <matthias@tenstral.net>
+
+---
+ backends/aptcc/apt-intf.cpp |   27 +++++++++++++++++----------
+ 1 files changed, 17 insertions(+), 10 deletions(-)
+
+--- a/backends/aptcc/apt-intf.cpp
++++ b/backends/aptcc/apt-intf.cpp
+@@ -1430,21 +1430,26 @@
+     if (untrusted.empty()) {
+         return true;
+     } else if (simulating) {
++        // We are just simulating and have untrusted packages emit them
++        // and return true to continue processing
+         emitPackages(untrusted, PK_FILTER_ENUM_NONE, PK_INFO_ENUM_UNTRUSTED);
+-    }
++    } else if (pk_backend_get_bool(m_backend, "only_trusted")) {
++         // We are NOT simulating and have untrusted packages
++         // fail the transaction.
++         string warning("The following packages cannot be authenticated:\n");
++         warning += UntrustedList;
++         pk_backend_error_code(m_backend,
++                                   PK_ERROR_ENUM_CANNOT_INSTALL_REPO_UNSIGNED,
++                                   warning.c_str());
++         _error->Discard();
+ 
+-    if (pk_backend_get_bool(m_backend, "only_trusted") == false) {
+-        g_debug ("Authentication warning overridden.\n");
+-        return true;
++         return false;
++    } else {
++         // We are NOT simulating and have untrusted packages
++         // But the user didn't set ONLY_TRUSTED flag
++         g_debug ("Authentication warning overridden.\n");
++         return true;
+     }
+-
+-    string warning("The following packages cannot be authenticated:\n");
+-    warning += UntrustedList;
+-    pk_backend_error_code(m_backend,
+-                          PK_ERROR_ENUM_CANNOT_INSTALL_REPO_UNSIGNED,
+-                          warning.c_str());
+-    _error->Discard();
+-    return false;
+ }
+ 
+ void AptIntf::tryToRemove(const pkgCache::VerIterator &ver,
diff -Nru packagekit-0.7.6/debian/patches/02_aptcc_auto-installed-fix.patch packagekit-0.7.6/debian/patches/02_aptcc_auto-installed-fix.patch
--- packagekit-0.7.6/debian/patches/02_aptcc_auto-installed-fix.patch	1970-01-01 01:00:00.000000000 +0100
+++ packagekit-0.7.6/debian/patches/02_aptcc_auto-installed-fix.patch	2012-12-10 20:26:59.000000000 +0100
@@ -0,0 +1,42 @@
+From c3eed50835846b0357693cceb1d4654713c30e94 Mon Sep 17 00:00:00 2001
+From: Daniel Nicoletti <dantti12@gmail.com>
+Date: Mon, 10 Dec 2012 15:56:23 -0200
+Subject: [PATCH] aptcc: Fix bug that was marking some packages as auto-installed and confused the resolver
+
+---
+ backends/aptcc/apt-intf.cpp |   10 +---------
+ 1 files changed, 1 insertions(+), 9 deletions(-)
+
+--- a/backends/aptcc/apt-intf.cpp
++++ b/backends/aptcc/apt-intf.cpp
+@@ -1475,7 +1475,6 @@
+     Cache.MarkDelete(Pkg, false);
+ }
+ 
+-
+ bool AptIntf::tryToInstall(const pkgCache::VerIterator &ver,
+                            pkgDepCache &Cache,
+                            pkgProblemResolver &Fix,
+@@ -1485,6 +1484,7 @@
+     pkgCache::PkgIterator Pkg = ver.ParentPkg();
+ 
+     // Check if there is something at all to install
++    Cache.SetCandidateVersion(ver);
+     pkgDepCache::StateCache &State = Cache[Pkg];
+ 
+     if (State.CandidateVer == 0) {
+@@ -1507,14 +1507,6 @@
+         ExpectedInst++;
+     }
+ 
+-    // 	cout << "trytoinstall ExpectedInst " << ExpectedInst << endl;
+-    // Install it with autoinstalling enabled (if we not respect the minial
+-    // required deps or the policy)
+-    if ((State.InstBroken() == true || State.InstPolicyBroken() == true) &&
+-            BrokenFix == false) {
+-        Cache.MarkInstall(Pkg,true);
+-    }
+-
+     return true;
+ }
+ 
diff -Nru packagekit-0.7.6/debian/patches/03_aptcc_release-lock.patch packagekit-0.7.6/debian/patches/03_aptcc_release-lock.patch
--- packagekit-0.7.6/debian/patches/03_aptcc_release-lock.patch	1970-01-01 01:00:00.000000000 +0100
+++ packagekit-0.7.6/debian/patches/03_aptcc_release-lock.patch	2012-12-10 20:26:59.000000000 +0100
@@ -0,0 +1,40 @@
+From b6b37cddb4b7c07f4365bc816473a746b6d02bf0 Mon Sep 17 00:00:00 2001
+From: Daniel Nicoletti <dantti12@gmail.com>
+Date: Fri, 30 Nov 2012 00:45:12 -0200
+Subject: [PATCH] aptcc: Fix a remaining lock that was being left on the archive directory
+ Backported to PackageKit 0.7.x series by Matthias Klumpp <matthias@tenstral.net>
+
+---
+ backends/aptcc/apt-intf.cpp |   22 ++++++++++------------
+ 1 files changed, 10 insertions(+), 12 deletions(-)
+
+--- a/backends/aptcc/apt-intf.cpp
++++ b/backends/aptcc/apt-intf.cpp
+@@ -2408,21 +2408,17 @@
+         return false;
+     }
+ 
+-    // Lock the archive directory
+-    FileFd Lock;
+-    if (_config->FindB("Debug::NoLocking", false) == false) {
+-        Lock.Fd(GetLock(_config->FindDir("Dir::Cache::Archives") + "lock"));
+-        if (_error->PendingError() == true) {
+-            return _error->Error("Unable to lock the download directory");
+-        }
+-    }
+-
+     // Create the download object
+     AcqPackageKitStatus Stat(this, m_backend, m_cancel);
+ 
+     // get a fetcher
+     pkgAcquire fetcher;
+-    fetcher.Setup(&Stat);
++    if (!simulating) {
++        // Only lock the archive directory if we will download
++        if (fetcher.Setup(&Stat, _config->FindDir("Dir::Cache::Archives")) == false) {
++            return false;
++        }
++    }
+ 
+     // Create the package manager and prepare to download
+     SPtr<pkgPackageManager> PM = _system->CreatePM(cache);
diff -Nru packagekit-0.7.6/debian/patches/series packagekit-0.7.6/debian/patches/series
--- packagekit-0.7.6/debian/patches/series	2012-08-21 16:46:20.000000000 +0200
+++ packagekit-0.7.6/debian/patches/series	2012-12-10 20:26:59.000000000 +0100
@@ -1,3 +1,6 @@
 vendor-debian.diff
 defaults.diff
 policy.diff
+01_aptcc_untrusted-trusted-pkgs.patch
+02_aptcc_auto-installed-fix.patch
+03_aptcc_release-lock.patch
diff -Nru packagekit-0.7.6/debian/patches/ubuntu.series packagekit-0.7.6/debian/patches/ubuntu.series
--- packagekit-0.7.6/debian/patches/ubuntu.series	2012-08-21 16:46:20.000000000 +0200
+++ packagekit-0.7.6/debian/patches/ubuntu.series	2012-12-10 20:26:59.000000000 +0100
@@ -1,3 +1,6 @@
 vendor-ubuntu.diff
 defaults.diff
 policy.diff
+01_aptcc_untrusted-trusted-pkgs.patch
+02_aptcc_auto-installed-fix.patch
+03_aptcc_release-lock.patch

--- End Message ---
--- Begin Message --- 
On Thu, Jan 24, 2013 at 04:00:53PM +0100, Matthias Klumpp wrote:
> Hi!
> Please unblock this release, it is highly recommended! It will not
> only fix an issue with packagekitd locking the cache for far too long,
> but also it will close this bug, which really is a severe one if
> people don't know how to deal with it:
>  https://bugs.launchpad.net/bugs/1103989
> 

Pinging on IRC 30 seconds after you ping via mail is not a good way to
endear yourself to the release team.

Anyway, unblocked.

Neil
--

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: