[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#698589: unblock: umlet/11.3-4



Thanks for the hint. I have no good knowledge of shell and appreciate
your improvement. I've prepared and uploaded a new version of umlet.
Here is the debdiff:

> debdiff umlet_11.3-4.dsc umlet_11.3-5.dsc 
diff -Nru umlet-11.3/debian/changelog umlet-11.3/debian/changelog
--- umlet-11.3/debian/changelog 2013-01-10 20:20:38.000000000 +0100
+++ umlet-11.3/debian/changelog 2013-01-22 21:33:11.000000000 +0100
@@ -1,3 +1,10 @@
+umlet (11.3-5) unstable; urgency=low
+
+  * improved command line script to handle whitespaces in filenames
+    (thanks Niels for a watchful eye)
+
+ -- Benjamin Mesing <bensmail@gmx.net>  Tue, 22 Jan 2013 21:32:08 +0100
+
 umlet (11.3-4) unstable; urgency=medium
 
   * pass command line parameters through "umlet" script (Closes:
#690272)
diff -Nru umlet-11.3/debian/patches/20_runScript.diff
umlet-11.3/debian/patches/20_runScript.diff
--- umlet-11.3/debian/patches/20_runScript.diff 2012-10-12
21:58:41.000000000 +0200
+++ umlet-11.3/debian/patches/20_runScript.diff 2013-01-22
21:31:05.000000000 +0100
@@ -13,5 +13,5 @@
 +# not required for packagesearch - everything is referenced from the
jar-file
 +# find_jars jabref antlr antlr3 jgoodies-looks forms spin glazedlists
microba pdfbox jempbox mysql-connect
 +
-+run_java -jar /usr/share/java/umlet.jar $*
++run_java -jar /usr/share/java/umlet.jar "$@"
 +

Best regards

Ben



On Tue, 2013-01-22 at 15:31 +0100, Niels Thykier wrote:
> Control: tags -1 moreinfo
> 
> On 2013-01-20 19:55, Benjamin Mesing wrote:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian.org@packages.debian.org
> > Usertags: unblock
> > 
> > Please unblock package umlet
> > 
> > The important bug #690271 is fixed. Nothing else was changed.
> > 
> >> > debdiff  umlet_11.3-3.dsc   umlet_11.3-4.dsc
> > diff -Nru umlet-11.3/debian/changelog umlet-11.3/debian/changelog
> > --- umlet-11.3/debian/changelog 2011-10-26 21:15:50.000000000 +0200
> > +++ umlet-11.3/debian/changelog 2013-01-10 20:20:38.000000000 +0100
> > @@ -1,3 +1,9 @@
> > +umlet (11.3-4) unstable; urgency=medium
> > +
> > +  * pass command line parameters through "umlet" script (Closes: #690272)
> > +
> > + -- Benjamin Mesing <bensmail@gmx.net>  Fri, 12 Oct 2012 22:02:34 +0200
> > +
> >  umlet (11.3-3) unstable; urgency=medium
> >  
> >    * set JAVA_HOME path arch-aware within rules file to comply to 
> > diff -Nru umlet-11.3/debian/patches/20_runScript.diff umlet-11.3/debian/patches/20_runScript.diff
> > --- umlet-11.3/debian/patches/20_runScript.diff 2011-10-23 19:35:37.000000000 +0200
> > +++ umlet-11.3/debian/patches/20_runScript.diff 2012-10-12 21:58:41.000000000 +0200
> > @@ -13,5 +13,5 @@
> >  +# not required for packagesearch - everything is referenced from the jar-file
> >  +# find_jars jabref antlr antlr3 jgoodies-looks forms spin glazedlists microba pdfbox jempbox mysql-connect
> >  +
> > -+run_java -jar /usr/share/java/umlet.jar
> > ++run_java -jar /usr/share/java/umlet.jar $*
> >  +
> > 
> 
> Are you sure you don't want to use "$@" instead of $* here.  I believe
> $* fails in case of spaces in arguments (even if quoted).
> 
> > 
> > unblock umlet/11.3-4
> > 
> > 
> > Best regards
> > 
> > Ben
> 
> ~Niels
> 


Reply to: