--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Hi Release Team
I would like to ask if it's possible to have libproc-processtable-perl
0.45-4, which implements a workaround for multi-cpu machine (>10
logical CPUs). The corresponding Debian Bug is [1]. Upstream has not
commented on it so far, the patch was applied to the package in
unstable and is there now for 14 days. Also it was already synced in
Ubuntu.
This request is not strictly compliant to the freeze policy as not
really RC. So I wanted to check the possibility of an unblock. Else I
can later on ask for an update via a pu for stable.
[1]: http://bugs.debian.org/696874
unblock libproc-processtable-perl/0.45-4
Many thanks for your work, and
regards,
Salvatore
Base version: libproc-processtable-perl_0.45-3 from testing
Target version: libproc-processtable-perl_0.45-4 from unstable
No hints in place.
changelog | 10 ++++++
patches/696874-fix-Buffer-overflow-in-pctcpu.patch | 34 +++++++++++++++++++++
patches/series | 1
3 files changed, 45 insertions(+)
diff -Nru libproc-processtable-perl-0.45/debian/changelog libproc-processtable-perl-0.45/debian/changelog
--- libproc-processtable-perl-0.45/debian/changelog 2011-11-07 16:23:58.000000000 +0000
+++ libproc-processtable-perl-0.45/debian/changelog 2012-12-28 17:52:42.000000000 +0000
@@ -1,3 +1,13 @@
+libproc-processtable-perl (0.45-4) unstable; urgency=low
+
+ * Add 696874-fix-Buffer-overflow-in-pctcpu.patch.
+ Fix for buffer overflow in pctcpu. On systems with more than 9 logical
+ CPUs, a process can use more than 999% of CPU and overflow pctcpu.
+ Thanks to Matthew L. Dailey and Zhengpeng Hou (Closes: #696874)
+ (LP: #1093289)
+
+ -- Salvatore Bonaccorso <carnil@debian.org> Fri, 28 Dec 2012 18:49:26 +0100
+
libproc-processtable-perl (0.45-3) unstable; urgency=low
[ Ansgar Burchardt ]
diff -Nru libproc-processtable-perl-0.45/debian/patches/696874-fix-Buffer-overflow-in-pctcpu.patch libproc-processtable-perl-0.45/debian/patches/696874-fix-Buffer-overflow-in-pctcpu.patch
--- libproc-processtable-perl-0.45/debian/patches/696874-fix-Buffer-overflow-in-pctcpu.patch 1970-01-01 00:00:00.000000000 +0000
+++ libproc-processtable-perl-0.45/debian/patches/696874-fix-Buffer-overflow-in-pctcpu.patch 2012-12-28 17:52:42.000000000 +0000
@@ -0,0 +1,34 @@
+Description: Fix for buffer overflow in pctcpu
+ On systems with more than 9 logical CPUs, a process can use more than 999% of
+ CPU and overflow pctcpu. This patch increases the buffer so that it will work
+ for up to 99 logical CPUs.
+Bug: https://rt.cpan.org/Public/Bug/Display.html?id=82175
+Bug-Debian: http://bugs.debian.org/696874
+Bug-Ubuntu: https://launchpad.net/bugs/1093289
+Forwarded: not-needed
+Author: Matthew L. Dailey <matthew.l.dailey@dartmouth.edu>
+Reviewed-by: Salvatore Bonaccorso <carnil@debian.org>
+Last-Update: 2012-12-23
+
+--- libproc-processtable-perl-0.45.orig/os/Linux.h
++++ libproc-processtable-perl-0.45/os/Linux.h
+@@ -42,7 +42,7 @@ struct procstat
+ char *cmndline;
+ char *exec;
+ /* other values */
+- char pctcpu[sizeof("100.00")]; /* precent cpu, without '%' char */
++ char pctcpu[sizeof("1000.00")]; /* precent cpu, without '%' char */
+ char pctmem[sizeof("100.00")]; /* precent memory, without '%' char */
+ };
+
+--- libproc-processtable-perl-0.45.orig/os/Linux.c
++++ libproc-processtable-perl-0.45/os/Linux.c
+@@ -551,7 +551,7 @@ static void calc_prec(char *format_str,
+ float pctcpu = 100.0f * (prs->utime / 1e6) / (time(NULL) - prs->start_time);
+
+ /* calculate pctcpu - NOTE: This assumes the cpu time is in microsecond units! */
+- sprintf(prs->pctcpu, "%3.2f", pctcpu);
++ sprintf(prs->pctcpu, "%4.2f", pctcpu);
+ field_enable(format_str, F_PCTCPU);
+
+ /* calculate pctmem */
diff -Nru libproc-processtable-perl-0.45/debian/patches/series libproc-processtable-perl-0.45/debian/patches/series
--- libproc-processtable-perl-0.45/debian/patches/series 2011-11-07 16:23:58.000000000 +0000
+++ libproc-processtable-perl-0.45/debian/patches/series 2012-12-28 17:52:42.000000000 +0000
@@ -1,2 +1,3 @@
spelling.patch
646785-add-new-states.patch
+696874-fix-Buffer-overflow-in-pctcpu.patch
--- End Message ---
--- Begin Message ---
On 17.01.2013 06:09, Salvatore Bonaccorso wrote:
On Sat, Jan 12, 2013 at 04:07:55PM +0100, Salvatore Bonaccorso wrote:
To have this info in the bugreport:
>From the discussion on IRC and comments from Julien and Adam: It
would
make sense to even inrease this to more than 100.
@Adam: will try to handle this in the unstable version then first.
Increased as requested, as 100 is not enough for the future. Attached
is the new debdiff against the version in testing.
Unblocked; thanks.
Regards,
Adam
--- End Message ---