[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697877: unblock: ebook-speaker/2.0-3



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Please unblock package ebook-speaker

Version 2.0-3 fixes bug 697350 where users could not use ebook-speaker if their
voice descriptor was longer than 5 characters.

Some voice synthesizers use language descriptors which are longer than the
currently allowed 5 characters. The language they need might not be among the
espeak voices, and the alternative have a voice whose name is bigger than 5.

debdiff is attached

unblock ebook-speaker/2.0-3

- -- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBCAAGBQJQ7xa8AAoJEJxcmesFvXUKFSgH/3ZktB1ouN7pM9cW2jl6tper
TBdANkAF6RzUFyRwknECpxRGDM58WInLQT/osqKIGLqkIObf/qB5d/5B6kNZQvA5
zPik2j+oFdyfxQ1RuWrBM+EAXF4yUAq/G2ro2mso3wxJiR18BauzVBcbZO9AhhMa
sjHluZFHmCc2C5k11CEVdmfCyulMJWOivsOk5tzKKmk45Ur86VeWZud7Y9+A9AnB
8/fMCQLtTXYkysklNShzb2GYat88O94XWMkiwu2QR1IAmWTdFXvHLoJ6XpLmWz0b
6BRpwQtuAZWZlm2Vnky+9LRbhExOEFyFO85bL6Rc92TEr6vMe/AWosh4Z/HRN18=
=/Sh2
-----END PGP SIGNATURE-----
diff -Nru ebook-speaker-2.0/debian/changelog ebook-speaker-2.0/debian/changelog
--- ebook-speaker-2.0/debian/changelog	2012-03-03 21:37:01.000000000 +0100
+++ ebook-speaker-2.0/debian/changelog	2013-01-09 21:34:39.000000000 +0100
@@ -1,3 +1,10 @@
+ebook-speaker (2.0-3) unstable; urgency=low
+
+  * Add mbrola.patch to allow voices with longer than 5 characters
+    descriptor (Closes: Bug#697350)
+
+ -- Paul Gevers <elbrus@debian.org>  Wed, 09 Jan 2013 21:02:39 +0100
+
 ebook-speaker (2.0-2) unstable; urgency=low
 
   [ Samuel Thibault ]
diff -Nru ebook-speaker-2.0/debian/patches/mbrola.patch ebook-speaker-2.0/debian/patches/mbrola.patch
--- ebook-speaker-2.0/debian/patches/mbrola.patch	1970-01-01 01:00:00.000000000 +0100
+++ ebook-speaker-2.0/debian/patches/mbrola.patch	2013-01-09 21:54:53.000000000 +0100
@@ -0,0 +1,44 @@
+Description: Some voice synthesizers use language descriptors which are
+ longer than the currently allowed 5 characters. This patch fixes that as
+ users have to get used to synthetic voices, so they want to use their own
+ default. Furthermore, the language they need might not be among the espeak
+ voices, and the alternative have a voice whose name is bigger than 5.
+Author: Thomas Renard <cybaer42@web.de>
+Author: Samuel Thibault <sthibault@debian.org>
+Bug-Debian: http://bugs.debian.org/697350
+Forwarded: yes
+
+--- a/eBook-speaker.c
++++ b/eBook-speaker.c
+@@ -1325,9 +1325,9 @@
+          p += 9;
+          while (*p == ' ' || *p == '\t' || *p == '\n')
+             p++;
+-         strncpy (dc_language, p, 5);
++         strncpy (dc_language, p, sizeof(dc_language));
+          p = dc_language;
+-         while (*p != ' ' && *p != '\t' && *p != 0)
++         while (*p != ' ' && *p != '\t' && *p != 0 && p < dc_language+sizeof(dc_language)-1)
+             p++;
+          *p = 0;
+       } // if
+@@ -1954,7 +1954,8 @@
+       fflush (stdout);
+       exit (1);
+    } // if
+-   strncpy (dc_language, label, 5);
++   strncpy (dc_language, label, sizeof(dc_language)-1);
++   dc_language[sizeof(dc_language)-1] = 0;
+    zip_fclose (opf);
+ } // set_language
+ 
+@@ -1989,7 +1990,8 @@
+       switch (opt)
+       {
+       case 'l':
+-         strncpy (dc_language, optarg, 5);
++         strncpy (dc_language, optarg, sizeof(dc_language)-1);
++         dc_language[sizeof(dc_language)-1] = 0;
+          break;
+       default:
+          usage (prog_name);
diff -Nru ebook-speaker-2.0/debian/patches/series ebook-speaker-2.0/debian/patches/series
--- ebook-speaker-2.0/debian/patches/series	2012-03-03 19:29:08.000000000 +0100
+++ ebook-speaker-2.0/debian/patches/series	2013-01-09 21:33:24.000000000 +0100
@@ -1,2 +1,3 @@
 ncx.patch
 realname.patch
+mbrola.patch

Reply to: