[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697667: unblock: opendkim/2.6.8-4



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package opendkim

I haven't uploaded this to unstable yet, this is a pre-approval request as
the bug is not RC, but it's a trivial fix backported from upstream with
negligible risk of regression that will help admins diagnose and troubleshoot
DKIM signing/verification issues.  Since currently the logs get the message
selector wrong (it logs the signing domain instead), it makes it very
difficult to troubleshoot selector related isseus (which are not rare).

Please let me know if this is OK and if so, I'm prepared to upload right
away.

unblock opendkim/2.6.8-4
diff -u opendkim-2.6.8/debian/changelog opendkim-2.6.8/debian/changelog
--- opendkim-2.6.8/debian/changelog
+++ opendkim-2.6.8/debian/changelog
@@ -1,3 +1,10 @@
+opendkim (2.6.8-4) unstable; urgency=low
+
+  * Backport fix from upstream to log the correct message selector
+    (Closes: #695145) (fix was included as part of the just released 2.7.4)
+
+ -- Scott Kitterman <scott@kitterman.com>  Tue, 08 Jan 2013 02:44:28 -0500
+
 opendkim (2.6.8-3) unstable; urgency=medium
 
   * Urgency medium for low risk RC bug fix
only in patch2:
unchanged:
--- opendkim-2.6.8.orig/opendkim/opendkim.c
+++ opendkim-2.6.8/opendkim/opendkim.c
@@ -13365,7 +13365,7 @@
 				for (c = 0; c < nsigs; c++)
 				{
 					domain = dkim_sig_getdomain(sigs[c]);
-					selector = dkim_sig_getdomain(sigs[c]);
+					selector = dkim_sig_getselector(sigs[c]);
 					err = dkim_sig_geterror(sigs[c]);
 					errstr = dkim_sig_geterrorstr(err);
 

Reply to: