[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#694790: upload (pre-approval): munin/2.0.6-2



Hi Julien,

thanks for your review!

On Dienstag, 1. Januar 2013, Julien Cristau wrote:
> debian/munin-async.logrotate: why change the gid?  

point. (On a third thought :)

> also
> <1111054228.1424.1351986968106.JavaMail.root@zimbra.lentz.com.au>
> suggests the glob is still wrong.

right, thanks for spotting!

> munin-async.postinst: what's the [ "$2" = 0 ] test supposed to achieve?

uhm, nothing, which not already has been achieved by the previous 'dpkg --
compare-versions "$2" le "2.0.6-1~"' - seems I copied the code from 
munin.postinst or munin-node.postinst... will remove it in all three places.

Will upload 2.0.6-3 with these fixes and this one soon, hopefully tomorrow:

commit 328396936f0b82dd8c9b182232cf6721af904da3
Author: Holger Levsen <holger@layer-acht.org>
Date:   Tue Dec 11 21:22:29 2012 +0000

    set MUNIN_VERSION correctly during build. (Closes: #694527)
    
    debian/rules: set MUNIN_VERSION correctly during build. (Closes: #694527)

diff --git a/debian/changelog b/debian/changelog
index 28011b7..559173c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+munin (2.0.6-3) UNRELEASD; urgency=low
+
+  * debian/rules: set MUNIN_VERSION correctly during build. (Closes: #694527)
+
+ -- Holger Levsen <holger@debian.org>  Wed, 26 Dec 2012 14:32:18 +0100
+
 munin (2.0.6-2) unstable; urgency=low
 
   * Fix "/etc/apache2/conf.d/munin removed on upgrade":
diff --git a/debian/rules b/debian/rules
index 8cac862..e1b7a12 100755
--- a/debian/rules
+++ b/debian/rules
@@ -8,6 +8,8 @@ MAKEOPTS = CONFIG=debian/Makefile.config INSTALL_PLUGINS="auto 
manual snmpauto c
        dh $@
 
 override_dh_auto_build:
+       # ./getversion reads RELEASE if it exists
+       dpkg-parsechangelog | sed -n 's/^Version: //p' > RELEASE
        chmod 755 debian/ostype_helper
        dh_auto_build -- $(MAKEOPTS)
 
@@ -83,6 +85,7 @@ override_dh_auto_install:
 override_dh_auto_clean:
        dh_auto_clean -- $(MAKEOPTS) clean-node clean-master clean-plugins 
clean-common clean
        find plugins/javalib -name '*.class' -print0 | xargs -0 -r rm -v
+       rm RELEASE -f
 
 # Disable build tests for now
 override_dh_auto_test:


cheers,
	Holger


Reply to: