Andreas Beckmann <anbe@debian.org> (2013-07-21): > On 2013-07-21 18:11, Adam D. Barratt wrote: > > On Sun, 2013-07-21 at 16:51 +0200, Andreas Beckmann wrote: > >> the change I suggested for sysvinit (#694252) and got applied in > >> sysvinit/2.88dsf-41+deb7u1 does not fix the bootchart upgrade path > >> lenny->squeeze->wheezy, but instead renders bootchart uninstallable in > >> stable (and sid as well): #717495. > > > > Hmmm, I'd rather assumed that was the point, given that the Breaks > > matches the only version of bootchart in the archive. > > but it makes a package in stable uninstallable without planning to > remove it from stable ... and that does not fix the upgrade issue in sysv-rc > > > Is keeping bootchart around still useful? The last upload of any kind > > was in 2009, with the last maintainer upload in early 2008. > > If the package were removed entirely (or at least version -3.3+1 would > be forced to rename the initscript), we could have sysv-rc use > dpkg-maintscript-helper rm_conffile to get rid of that script ... that > would even cover the case where bootchart lenny was installed, removed, > the initscript remained and the system would be upgraded to squeeze and > wheezy later on. > > > Going back through the history of the sysvinit bug, I have to admit to > > being rather confused. You state that "0.10~svn407-3.3 was the last > > existing and therefore "broken" version in lenny (and on > > snapshots.d.o)." However, the lenny packages files (as on archive.d.o) > > indicates that lenny contained -3; the fix for #491391 in bootchart was > > included in -3.1. Please clarify... :-| > > I think I have mixed up the versions -3 vs. -3.3 at some point, > therefore suggesting to add the wrong Breaks against << -4, after seeing > that a Breaks against -3 was not sufficient to fix that upgrade path. > That Breaks actually worked, but it was not sufficient to ensure -3.3 > gets configured before sysv-rc, leaving the bad initscript still around. > > At the time I initially filed the bug I didn't have piuparts ready to > easily do upgrade tests with the new --testdebs-repo option, otherwise I > might have tried the Breaks approach myself (and seen that it does not > work as planned). > > > Entirely new approach to fix this much less intrusively: > > bootchart.preinst: > on upgrade from << -4 > sed -i 's/rmnologin/$all/' /etc/init.d/bootchart > # makes the initscript identical to the new shipped one, so no conffile > prompts (unless there were other user modifications) > > bump version to -4.1 / -4.1~deb7u1 to satisfy initscripts I'm really tempted by not even trying to fix it, adding layers of patches on top of each others, trying to compensate for things that are unmaintained and broken isn't very nice (reminds me of sgml-base…). Adam, what's your take on this one? Mraw, KiBi.
Attachment:
signature.asc
Description: Digital signature