Re: Proposed update: gabedit/2.4.2-2+wheezy1 fixing #703965

["Adam D. Barratt" <adam@adam-barratt.org.uk>]

Hi,

On Mon, 2013-07-29 at 00:44 +0200, Daniel Leidert wrote:
> I'm proposing a fix for gabedit in Wheezy. A buffer overflow has been
> detected, which can be fixed with a one-liner. See these references:

Thanks for caring about fixing bugs in stable. For future reference,
it's generally easier (at least for us) to track such requests if
they're filed in the BTS (either via reportbug, or separately with the
appropriate usertags).

+gabedit (2.4.2-2+wheezy1) stable; urgency=low

2.4.2-2+deb7u1, please.

+--- a/src/Display/AnimationGeomConv.c
++++ b/src/Display/AnimationGeomConv.c
+@@ -1441,6 +1441,7 @@
+                       if (l==2) AtomCoord[0][1]=tolower(AtomCoord[0][1]);
+ 
+ 
++                      sprintf(AtomCoord[0],"%s",get_symbol_using_z(atoi(dum)));
+                       sprintf(listOfAtoms[j].symbol,"%s",AtomCoord[0]);

Apologies if I'm missing something, but doesn't that sprintf() call
overwrite all of the manipulation performed on AtomCoord[0] (or its
components) during the previous few lines?

Regards,

Adam