[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#709286: pu: package libnss-myhostname/0.3-4



Hi,

Am Mittwoch, den 22.05.2013, 20:16 +0200 schrieb Paul Gevers:
> On 22-05-13 12:53, Joachim Breitner wrote:
> > The fix is uploaded to unstable, and the  debdiff attached.
> 
> Just a note on your debdiff. It contains several spurious differences
> (e.g. .git-dpm and refreshed patches without code changes). It would
> help the RT if your debdiff is clean, i.e. only contain real changes.

unfortunately unavoidable due to the old version of git that produced
the old package and the new version of git that produced the new
patches. Changing to a different workflow just to avoid these cosmetic
differences seems counterproductive, as it increases the risk of errors
in the workflow.

But you are right that for review purposes I can do better. So instead
of the debdiff I now just attache the newly added patch; besides the
changelog entry no other change has been done.

> > Is this ok for wheezy? If so, how should I proceed -- wait for it to
> > enter jessie and then upload a package, built in a stable chroot, to
> > s-p-u?
> 
> If the changes are acceptable, you should prepare with the minimal
> changes a package for wheezy, build against wheezy and upload to s-p-u.

Thanks for the info. Judging from what I see before I should give the
upload the version number 0.3-5~deb7u1. What happens if it enters stable
before 0.3-5 is in jessie?

Greetings,
Joachim

-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: 4743206C
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

From cce547eac7d27b4476e646bfead3ba14b57a6ccc Mon Sep 17 00:00:00 2001
From: Joachim Breitner <mail@joachim-breitner.de>
Date: Mon, 13 May 2013 10:34:57 +0200
Subject: Ignore link-local addresses

Closes: #705900
---
 netlink.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/netlink.c b/netlink.c
index 29f38e3..9bbed7e 100644
--- a/netlink.c
+++ b/netlink.c
@@ -178,6 +178,12 @@ int ifconf_acquire_addresses(struct address **_list, unsigned *_n_list) {
                         if (!address)
                                 continue;
 
+			// Avoid link-local address
+			// http://bugs.debian.org/705900
+			if (ifaddrmsg->ifa_family == AF_INET6 &&
+			    IN6_IS_ADDR_LINKLOCAL((const struct in6_addr *)address))
+			    continue;
+
                         list = realloc(list, (n_list+1) * sizeof(struct address));
                         if (!list) {
                                 r = -ENOMEM;

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: