Bug#708247: pu: package smcroute/0.95-2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: pu
Hello brave release-team,
I would like to propose smcroute/0.95-2 as a canididate for the next wheezy
point release. Compared to the version released with wheezy, I did following
changes:
smcroute (0.95-2) stable; urgency=low
* Switch to dpkg-source 3.0 (quilt) format for easier patch maintenance.
* Added patch 01_fix_segfault.patch to fix a NULL pointer dereferencing in
interface vector initialization (closes: #707793, LP: #1043688).
-- Micha Lenk <micha@debian.org> Tue, 14 May 2013 14:41:24 +0200
You can find the full diff of changes attached to this mail.
Is the distribution 'stable' correct for wheezy proposed updates?
Regards,
Micha
diff -Nru smcroute-0.95/debian/changelog smcroute-0.95/debian/changelog
--- smcroute-0.95/debian/changelog 2013-05-14 15:02:54.000000000 +0200
+++ smcroute-0.95/debian/changelog 2013-05-14 15:01:23.000000000 +0200
@@ -1,3 +1,11 @@
+smcroute (0.95-2) stable; urgency=low
+
+ * Switch to dpkg-source 3.0 (quilt) format for easier patch maintenance.
+ * Added patch 01_fix_segfault.patch to fix a NULL pointer dereferencing in
+ interface vector initialization (closes: #707793, LP: #1043688).
+
+ -- Micha Lenk <micha@debian.org> Tue, 14 May 2013 14:41:24 +0200
+
smcroute (0.95-1) unstable; urgency=low
* New upstream version, added support for FreeBSD
diff -Nru smcroute-0.95/debian/patches/01_fix_segfault.patch smcroute-0.95/debian/patches/01_fix_segfault.patch
--- smcroute-0.95/debian/patches/01_fix_segfault.patch 1970-01-01 01:00:00.000000000 +0100
+++ smcroute-0.95/debian/patches/01_fix_segfault.patch 2013-05-14 14:47:54.000000000 +0200
@@ -0,0 +1,25 @@
+Description: Fixed a segfault caused by dereferencing a NULL pointer
+Author: Micha Lenk <micha@debian.org>
+Bug-Debian: http://bugs.debian.org/707793
+Bug-Ubuntu: https://launchpad.net/bugs/1043688
+Forwarded: not-needed, fixed upstream by more intrusive code changes
+Last-Update: 2013-05-14
+
+--- smcroute-0.95.orig/src/ifvc.c
++++ smcroute-0.95/src/ifvc.c
+@@ -50,12 +50,13 @@ void buildIfVc()
+ }
+
+ for (ifa = ifaddr; ifa != NULL; ifa = ifa->ifa_next) {
++ /* Skip interface without internet address */
++ if (ifa->ifa_addr == NULL) continue;
++
+ int family = ifa->ifa_addr->sa_family;
+
+ /* Skip non-IPv4 and non-IPv6 interfaces */
+ if ((family != AF_INET) && (family != AF_INET6)) continue;
+- /* Skip interface without internet address */
+- if (ifa->ifa_addr == NULL) continue;
+
+ /* Copy data from interface iterator 'ifa' */
+ strncpy(IfDescEp->Name, ifa->ifa_name, sizeof(IfDescEp->Name));
diff -Nru smcroute-0.95/debian/patches/series smcroute-0.95/debian/patches/series
--- smcroute-0.95/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ smcroute-0.95/debian/patches/series 2013-05-14 14:44:07.000000000 +0200
@@ -0,0 +1 @@
+01_fix_segfault.patch
diff -Nru smcroute-0.95/debian/source/format smcroute-0.95/debian/source/format
--- smcroute-0.95/debian/source/format 1970-01-01 01:00:00.000000000 +0100
+++ smcroute-0.95/debian/source/format 2013-05-14 14:41:24.000000000 +0200
@@ -0,0 +1 @@
+3.0 (quilt)
Reply to: