[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#704566: unblock: isc-dhcp/4.2.2.dfsg.1-5+deb70u4



control: retitle -1 unblock: isc-dhcp/4.2.2.dfsg.1-5+deb70u5

On Mon, Apr 8, 2013 at 6:42 PM, Jonathan Wiltshire wrote:
> (sorry for the delay, which was to avoid a rash reply)
> (quotes have been re-ordered)
>
> On Wed, Apr 03, 2013 at 08:12:15PM -0400, Michael Gilbert wrote:
>> On Wed, Apr 3, 2013 at 1:47 PM, Jonathan Wiltshire wrote:
>> > On Tue, Apr 02, 2013 at 09:07:44PM -0400, Michael Gilbert wrote:
>> >> Please unblock package isc-dhcp
>> >>
>> >> This upload fixes a security issue in the embedded bind library.  It's
>> >> a bit large due to the addition of a secondary patch system for
>> >> patching bind issues.  Please see attached patch.
>> >>
>> >> unblock isc-dhcp/4.2.2.dfsg.1-5+deb70u4
>> >
>> > Nack with the patch system change. You can upload without it if you like.
>> >
>
>> Anyway, adding the secondary bind patching system is actually not
>> unrelated to the bug being fixed.  It is the sanest solution of 3 ugly
>> possibilities:
>>
>> 1.  Add the separate bind patching system
>> 2.  Extract bind.tar.gz (adding probably around 300,000 lines to the
>> diff) and use the existing patching system
>
> Thank you, that is the missing explanation that would have saved a round
> trip mail.
>
> You are right that the first option is the better. However, I discussed it
> with Adam and we'd prefer the direct use of "patch" rather than added
> build-dependencies at this point. You get patch for free because dpkg-dev
> depends on it.

I've attached a proposed patch-using patch, and will wait for an ack.

Best wishes,
Mike

Attachment: dhcp.patch
Description: Binary data


Reply to: