[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#696564: unblock: fusioninventory-agent/2.2.3-5



On Thu, Apr 04, 2013 at 04:13:51PM +0200, Gonéri Le Bouder wrote:
> On Wed, Apr 03, 2013 at 09:58:43PM +0100, Jonathan Wiltshire wrote:
> > On Thu, Mar 28, 2013 at 12:22:38PM +0000, Jonathan Wiltshire wrote:
> > > On Tue, Mar 26, 2013 at 04:17:00PM +0100, Gonéri Le Bouder wrote:
> > > > Hi,
> > > > 
> > > > > -7 looks fine in principle. Please upload it with urgency=medium so it can
> > > > > get a final review.
> > > > The package has been uploded.
> > > 
> > > I'm sorry not to have spotted it earlier, but this change in prerm:
> > > 
> > > +    # remove the configuration file itself
> > > +    rm -f /etc/fusioninventory/agent.cfg
> > > +    rm -r /etc/fusioninventory
> > > 
> > > Apart from the redundancy, what happens if the directory isn't there? Won't
> > > the purge abort?
> > 
> > ping?
> Sorry,
> 
> Indeed, this is enough to break the postrm script. I prepare a new package.

I uploaded 2.2.3-8, this is the debdiff against 2.2.3-7:


diff -u fusioninventory-agent-2.2.3/debian/changelog fusioninventory-agent-2.2.3/debian/changelog
--- fusioninventory-agent-2.2.3/debian/changelog
+++ fusioninventory-agent-2.2.3/debian/changelog
@@ -1,3 +1,10 @@
+fusioninventory-agent (2.2.3-8) unstable; urgency=medium
+
+  * purge: avoid postrm script failure if /etc/fusioninventory is missing
+  * Urgency medium, because it fix bug #684855 in testing
+
+ -- Gonéri Le Bouder <goneri@rulezlan.org>  Thu, 04 Apr 2013 16:18:10 +0200
+
 fusioninventory-agent (2.2.3-7) unstable; urgency=medium
 
   * Drop upstream-fix-backport.diff in order to reduce the size of the
diff -u fusioninventory-agent-2.2.3/debian/fusioninventory-agent.postrm fusioninventory-agent-2.2.3/debian/fusioninventory-agent.postrm
--- fusioninventory-agent-2.2.3/debian/fusioninventory-agent.postrm
+++ fusioninventory-agent-2.2.3/debian/fusioninventory-agent.postrm
@@ -11,7 +11,7 @@
 
     # remove the configuration file itself
     rm -f /etc/fusioninventory/agent.cfg
-    rm -r /etc/fusioninventory
+    [ -d /etc/fusioninventory ] && rmdir --ignore-fail-on-non-empty /etc/fusioninventory
 
     # and finally clear it out from the ucf database
     if which ucf >/dev/null; then

Attachment: pgpPfRiksb2NR.pgp
Description: PGP signature


Reply to: