[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#704273: marked as done (unblock: debian-installer-launcher/16)

Your message dated Mon, 01 Apr 2013 20:44:41 +0100
with message-id <1364845481.6905.32.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#704273: unblock: debian-installer-launcher/16
has caused the Debian Bug report #704273,
regarding unblock: debian-installer-launcher/16
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
704273: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704273
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package debian-installer-launcher

It fixes the grave bug #703979.

unblock debian-installer-launcher/16

Thanks,
Ben

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (500, 'testing'), (101, 'unstable'), (1, 'experimental')
Architecture: i386 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

diff -Nru debian-installer-launcher-15/debian/changelog debian-installer-launcher-16/debian/changelog
--- debian-installer-launcher-15/debian/changelog	2013-03-25 19:32:31.000000000 -0300
+++ debian-installer-launcher-16/debian/changelog	2013-03-30 16:59:31.000000000 -0300
@@ -1,3 +1,12 @@
+debian-installer-launcher (16) unstable; urgency=low
+
+  * Use tmpfs and lazy unmount to ensure safe cleanup.
+    Thanks to Bastian Blank <waldi@debian.org>. (Closes: #703979).
+  * Ensure chroot inherits DISPLAY from caller to make
+    install from console possible again.
+
+ -- Ben Armstrong <synrg@sanctuary.nslug.ns.ca>  Sat, 30 Mar 2013 10:37:55 -0300
+
 debian-installer-launcher (15) unstable; urgency=low
 
   * Correctly identifying syslogd/klogd processes to kill when cleaning up
diff -Nru debian-installer-launcher-15/debian-installer.sh debian-installer-launcher-16/debian-installer.sh
--- debian-installer-launcher-15/debian-installer.sh	2013-03-25 19:32:31.000000000 -0300
+++ debian-installer-launcher-16/debian-installer.sh	2013-03-30 16:59:31.000000000 -0300
@@ -3,7 +3,7 @@
 set -e
 
 in_image () {
-	chroot /lib/live/installer /usr/bin/env -i LIVE_INSTALLER_MODE=1 DEBIAN_FRONTEND=$DI_FRONTEND DISPLAY=:0 TERM=$TERM $CMDLINE $@
+	chroot /lib/live/installer /usr/bin/env -i LIVE_INSTALLER_MODE=1 DEBIAN_FRONTEND=$DI_FRONTEND DISPLAY=$DISPLAY TERM=$TERM $CMDLINE $@
 }
 
 CMDLINE=
diff -Nru debian-installer-launcher-15/plugins/live debian-installer-launcher-16/plugins/live
--- debian-installer-launcher-15/plugins/live	2013-03-25 19:32:31.000000000 -0300
+++ debian-installer-launcher-16/plugins/live	2013-03-30 16:59:31.000000000 -0300
@@ -65,8 +65,9 @@
 
 	echo "Loading debian-installer..."
 
-	# Create the temporary directory
+	# Create the temporary directory and mount a tmpfs on it to ease cleanup
 	mkdir -p /lib/live/installer
+	mount -t tmpfs none /lib/live/installer
 
 	# Unpack the initrd
 	cd /lib/live/installer
@@ -100,13 +101,9 @@
 	# which is a bit of a grubby way to identify them, but holds true for now.
 	fuser -k /lib/live/installer/bin/busybox > /dev/null 2>&1 || true
 
-	# Unmounting filesystems
-	for fs in /cdrom /dev/pts /dev /proc /sys /tmp; do
-		umount -f /lib/live/installer/$fs > /dev/null 2>&1 || true
-	done
-
 	# Remove unpacked initrd
-	rm -rf /lib/live/installer
+	cd
+	umount -l /lib/live/installer
 	rm -f /tmp/debian-installer
 }

--- End Message ---
--- Begin Message --- 
On Sat, 2013-03-30 at 17:25 -0300, Ben Armstrong wrote:
> Please unblock package debian-installer-launcher
> 
> It fixes the grave bug #703979.

Done, thanks.

Regards,

Adam

--- End Message ---
Reply to: