[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#704047: marked as done (unblock: kvpm/0.8.6-3)

Your message dated Thu, 28 Mar 2013 13:25:37 +0000
with message-id <0243d47f3cfc1832a340dab9135b371a@mail.adsl.funky-badger.org>
and subject line Re: Bug#704047: unblock: kvpm/0.8.6-3
has caused the Debian Bug report #704047,
regarding unblock: kvpm/0.8.6-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
704047: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704047
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
Tags: patch
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi,

the upstream author of kvpm who also happens to be the Debian
maintainer of the package recently found a critical bug when
moving partitions [1]. I have reviewed his package and I'm
attaching the Debdiff.

Please unblock the package for Wheezy.

unblock kvpm/0.8.6-3

> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703919

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.8-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -Nru kvpm-0.8.6/debian/changelog kvpm-0.8.6/debian/changelog
--- kvpm-0.8.6/debian/changelog	2012-04-16 17:47:32.000000000 +0200
+++ kvpm-0.8.6/debian/changelog	2013-03-27 01:13:57.000000000 +0100
@@ -1,3 +1,11 @@
+kvpm (0.8.6-3) unstable; urgency=critical
+	
+  [ Benjamin J. Scott ]
+  * Changed file kvpm/partchange.cpp to fix potential data corruption bug 
+    when moving a partition on a disk with mounted partitions (Closes: #703919).
+
+ -- Benjamin J. Scott <benscott@nwlink.com>  Sun, 24 Feb 2013 17:25:21 -0700
+
 kvpm (0.8.6-2) unstable; urgency=low
 
   [ Benjamin J. Scott ]
diff -Nru kvpm-0.8.6/debian/patches/partition-move-corruption.patch kvpm-0.8.6/debian/patches/partition-move-corruption.patch
--- kvpm-0.8.6/debian/patches/partition-move-corruption.patch	1970-01-01 01:00:00.000000000 +0100
+++ kvpm-0.8.6/debian/patches/partition-move-corruption.patch	2013-03-06 07:12:54.000000000 +0100
@@ -0,0 +1,20 @@
+This patch corrects a bug in which data is sometimes corrupted when moving a disk 
+partition while the disk has other partitions mounted.
+--- a/kvpm/partchange.cpp
++++ b/kvpm/partchange.cpp
+@@ -649,13 +649,8 @@
+         return false;
+     }
+     else {
+-        if( !movefs(old_start, current_start, old_size) ){
+-            return false;
+-        }
+-        else{
+-            pedCommitAndWait(m_ped_disk);
+-            return true;
+-        }
++        pedCommitAndWait(m_ped_disk);
++	return movefs(old_start, current_start, old_size);
+     }
+ }
+ 
diff -Nru kvpm-0.8.6/debian/patches/series kvpm-0.8.6/debian/patches/series
--- kvpm-0.8.6/debian/patches/series	2012-04-16 17:41:26.000000000 +0200
+++ kvpm-0.8.6/debian/patches/series	2013-03-06 08:16:15.000000000 +0100
@@ -1 +1,2 @@
+partition-move-corruption.patch
 bug-667232.patch

--- End Message ---
--- Begin Message --- 
On 28.03.2013 10:46, John Paul Adrian Glaubitz wrote:

On 03/28/2013 11:44 AM, Adam D. Barratt wrote:

That's too bad. But I would go ahead now, build 0.8.6-3+wheezy1


That would be higher than the version in unstable. :) Please use
"0.8.6-2+deb7u1".

[...]

Will upload the package now.


Approved; thanks.

Regards,

Adam

--- End Message ---
Reply to: