Bug#703238: unblock: remmina/1.0.0-4+deb7u1 (pre-approval)
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
I'd like to receive a pre-approval to upload into unstable a fix for bug
#668020 (and its merged ones), which could result very annoying.
One of the submitters confirmed the proposed patch fixes the bug for him
(thanks to Bernhard Schmidt for his efforts!), so it received a first testing
in advance.
I chose 1.0.0-4+deb7u1 as version because I already uploaded 1.0.0-5 to
experimental.
-- System Information:
Debian Release: 7.0
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
diff -Nru remmina-1.0.0/debian/changelog remmina-1.0.0/debian/changelog
--- remmina-1.0.0/debian/changelog 2012-05-24 22:37:17.000000000 +0200
+++ remmina-1.0.0/debian/changelog 2013-03-17 14:39:39.000000000 +0100
@@ -1,3 +1,11 @@
+remmina (1.0.0-4+deb7u1) unstable; urgency=low
+
+ [ Bernhard Schmidt ]
+ * Cherry-pick commit 9243d35 from upstream Git repository to fix a
+ crash when resizing window to fit remote resolution (Closes: #668020).
+
+ -- Luca Falavigna <dktrkranz@debian.org> Sun, 17 Mar 2013 14:37:39 +0100
+
remmina (1.0.0-4) unstable; urgency=low
[ Martijn van Brummelen ]
diff -Nru remmina-1.0.0/debian/patches/fix-crash-on-resize.patch remmina-1.0.0/debian/patches/fix-crash-on-resize.patch
--- remmina-1.0.0/debian/patches/fix-crash-on-resize.patch 1970-01-01 01:00:00.000000000 +0100
+++ remmina-1.0.0/debian/patches/fix-crash-on-resize.patch 2013-03-07 15:13:50.000000000 +0100
@@ -0,0 +1,25 @@
+From 1901a1e9e5282c1deca2f5f98476e2c7e9243d35 Mon Sep 17 00:00:00 2001
+From: Jean-Louis Dupond <jean-louis@dupond.be>
+Date: Mon, 10 Sep 2012 14:12:11 +0200
+Subject: [PATCH] Closes #63: fix typo when fitting window
+
+---
+ remmina/src/remmina_connection_window.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/remmina/src/remmina_connection_window.c b/remmina/src/remmina_connection_window.c
+index 7ff1246..2ba8193 100644
+--- a/remmina/src/remmina_connection_window.c
++++ b/remmina/src/remmina_connection_window.c
+@@ -436,7 +436,7 @@ static gboolean remmina_connection_holder_toolbar_autofit_restore(RemminaConnect
+ remmina_connection_holder_get_desktop_size(cnnhld, &width, &height, TRUE);
+ gtk_widget_get_allocation(priv->notebook, &na);
+ gtk_widget_get_allocation(cnnobj->scrolled_container, &ca);
+- gtk_widget_get_allocation(priv->toolbar, &ca);
++ gtk_widget_get_allocation(priv->toolbar, &ta);
+ gtk_window_resize(GTK_WINDOW(cnnhld->cnnwin), MAX(1, width + na.width - ca.width),
+ MAX(1, height + ta.height + na.height - ca.height));
+ gtk_container_check_resize(GTK_CONTAINER(cnnhld->cnnwin));
+--
+1.7.10
+
diff -Nru remmina-1.0.0/debian/patches/series remmina-1.0.0/debian/patches/series
--- remmina-1.0.0/debian/patches/series 2012-05-24 22:37:17.000000000 +0200
+++ remmina-1.0.0/debian/patches/series 2013-03-07 15:13:50.000000000 +0100
@@ -7,3 +7,4 @@
fullname.patch
systray.patch
scroll.patch
+fix-crash-on-resize.patch
Reply to: