[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#702877: marked as done (unblock: python-mysqldb/1.2.3-2)

Your message dated Fri, 15 Mar 2013 19:21:04 +0000
with message-id <1363375264.2662.5.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#702877: Uploaded to unstable; please unblock
has caused the Debian Bug report #702877,
regarding unblock: python-mysqldb/1.2.3-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
702877: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=702877
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi,

I would like to ask if you would unblock a fix for #678169 (python-mysqldb: fails to
connect to mysql), where python-mysqldb errorneously does not compile with SSL support,
thus securely connecting to a MySQL server from python is not possible. This is a
regression from squeeze. The fix is a three-line patch pulled from upstream which
forcibly enables SSL support as it is not enabled automatically anymore.

The proposed debdiff is in the bug report and attached.

Cheers,

Mika

unblock python-mysqldb/1.2.3-2

diff -Nru python-mysqldb-1.2.3/debian/changelog python-mysqldb-1.2.3/debian/changelog
--- python-mysqldb-1.2.3/debian/changelog	2011-10-18 12:46:05.000000000 +0200
+++ python-mysqldb-1.2.3/debian/changelog	2013-03-12 13:51:34.000000000 +0100
@@ -1,3 +1,14 @@
+python-mysqldb (1.2.3-2) unstable; urgency=low
+
+  * Team upload.
+  * debian/patches/05_ssl.patch: Add upstream patch to force building
+    SSL support with newer MySQL client libraries. Thanks to Eldon Koyle
+    for isolating the fix in the upstream VCS. (Closes: #678169)
+  * Delete now obsolete debian/patches/README.source which referred to
+    dpatch.
+
+ -- Mika Pflüger <debian@mikapflueger.de>  Mon, 11 Mar 2013 18:03:06 +0100
+
 python-mysqldb (1.2.3-1) unstable; urgency=low
 
   * Merge with package from Ubuntu, thanks to Mario Limonciello.
diff -Nru python-mysqldb-1.2.3/debian/patches/05_ssl.patch python-mysqldb-1.2.3/debian/patches/05_ssl.patch
--- python-mysqldb-1.2.3/debian/patches/05_ssl.patch	1970-01-01 01:00:00.000000000 +0100
+++ python-mysqldb-1.2.3/debian/patches/05_ssl.patch	2013-03-11 18:32:15.000000000 +0100
@@ -0,0 +1,21 @@
+Description: Force HAVE_OPENSSL if the client library is 5.5 or newer.
+Origin: http://sourceforge.net/p/mysql-python/svn/656/tree//branches/MySQLdb-1.2/MySQLdb/_mysql.c?diff=5059d1f5bfc09e26e1a66617:655
+Bug: http://sourceforge.net/p/mysql-python/bugs/323/
+Reviewed-by: Eldon Koyle <ekoyle@gmail.com>
+Last-Update: 2013-03-11
+
+Index: python-mysqldb-argh/_mysql.c
+===================================================================
+--- python-mysqldb-argh.orig/_mysql.c	2010-06-17 09:21:56.000000000 +0200
++++ python-mysqldb-argh/_mysql.c	2013-03-11 18:30:38.839269635 +0100
+@@ -102,6 +102,10 @@
+ #define check_server_init(x) if (!_mysql_server_init_done) _mysql_server_init_done = 1
+ #endif
+ 
++#if MYSQL_VERSION_ID >= 50500
++#define HAVE_OPENSSL 1
++#endif
++
+ PyObject *
+ _mysql_Exception(_mysql_ConnectionObject *c)
+ {
diff -Nru python-mysqldb-1.2.3/debian/patches/series python-mysqldb-1.2.3/debian/patches/series
--- python-mysqldb-1.2.3/debian/patches/series	2011-10-18 11:38:40.000000000 +0200
+++ python-mysqldb-1.2.3/debian/patches/series	2013-03-11 18:19:24.000000000 +0100
@@ -1,2 +1,3 @@
 01_converters_boolean.patch
 03_converters_set2str.patch
+05_ssl.patch
diff -Nru python-mysqldb-1.2.3/debian/README.source python-mysqldb-1.2.3/debian/README.source
--- python-mysqldb-1.2.3/debian/README.source	2011-09-19 12:48:38.000000000 +0200
+++ python-mysqldb-1.2.3/debian/README.source	1970-01-01 01:00:00.000000000 +0100
@@ -1,2 +0,0 @@
-This package uses dpatch for its patch management, see
-/usr/share/doc/dpatch/README.source.gz if you are unfamiliar with it.

--- End Message ---
--- Begin Message --- 
On Fri, 2013-03-15 at 18:36 +0100, Mika Pflüger wrote:
>   * debian/patches/05_ssl.patch: Add upstream patch to force building
>     SSL support with newer MySQL client libraries. Thanks to Eldon Koyle
>     for isolating the fix in the upstream VCS. (Closes: #678169)

Unblocked.

As an additional note, python-mysqldb appears to be missing a
build-dependency on libssl-dev. I doubt that pythonX.Y-dev's dependency
on it will go away any time soon, but you shouldn't rely on that if your
package requires libssl-dev in order to build.

Regards,

Adam

--- End Message ---
Reply to: