[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#703030: marked as done (unblock: gst-plugins-base0.10/0.10.36-1.1)

Your message dated Thu, 14 Mar 2013 18:27:29 +0000
with message-id <20130314182729.GR5712@ernie.home.powdarrmonkey.net>
and subject line Re: Bug#703030: unblock: gst-plugins-base0.10/0.10.36-1.1
has caused the Debian Bug report #703030,
regarding unblock: gst-plugins-base0.10/0.10.36-1.1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
703030: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703030
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package gst-plugins-base0.10

Reason
------

The package in unstable fixes bug #668109
"playback stops when transitioning to ogg or flac"
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=668109

The bug leads to hangs during song changes to ogg/flac files using media
players like Rhythmbox and Quod Libet and is a regression from squeeze.

The fix was taken from upstream git and has been in unstable and Ubuntu
raring for 3 months now without an known side effects.

Debdiff against the package in testing
--------------------------------------

diff -Nru gst-plugins-base0.10-0.10.36/debian/changelog gst-plugins-
base0.10-0.10.36/debian/changelog
--- gst-plugins-base0.10-0.10.36/debian/changelog       2012-02-21
10:40:54.000000000 +0100
+++ gst-plugins-base0.10-0.10.36/debian/changelog       2012-12-04
12:08:57.000000000 +0100
@@ -1,3 +1,12 @@
+gst-plugins-base0.10 (0.10.36-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+    + debian/patches/98_fix-ogg-flac-transition.patch:
+      - Fixes ogg->flac transition hangs (Closes: #668109)
+        Taken from upstream git.
+
+ -- Christoph Reiter <reiter.christoph@gmail.com>  Tue, 04 Dec 2012 11:07:40
+0100
+
 gst-plugins-base0.10 (0.10.36-1) unstable; urgency=low

   * New upstream stable release, "Better":
diff -Nru gst-plugins-base0.10-0.10.36/debian/patches/98_fix-ogg-flac-
transition.patch gst-plugins-base0.10-0.10.36/debian/patches/98_fix-ogg-flac-
transition.patch
--- gst-plugins-base0.10-0.10.36/debian/patches/98_fix-ogg-flac-
transition.patch        1970-01-01 01:00:00.000000000 +0100
+++ gst-plugins-base0.10-0.10.36/debian/patches/98_fix-ogg-flac-
transition.patch        2012-12-04 12:08:57.000000000 +0100
@@ -0,0 +1,27 @@
+From: Edward Hervey <edward.hervey@collabora.co.uk>
+Subject: baseaudiosink: Resync when ringbuffer resets
+
+When the ringbuffer gets restarted (like in setcaps), we *will* have to
+resync against the new values. Without this we end up blindly assuming the
+new samples align to the old ones.
+
+Origin: upstream, http://cgit.freedesktop.org/gstreamer/gst-plugins-
base/commit/?id=969fe8c0b97ae4ac58aacf7530ca1bfbc2b5969a
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=680252
+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=668109
+Index: gst-plugins-base0.10-0.10.36/gst-libs/gst/audio/gstbaseaudiosink.c
+===================================================================
+--- gst-plugins-base0.10-0.10.36.orig/gst-libs/gst/audio/gstbaseaudiosink.c
2011-12-30 14:29:13.000000000 +0100
++++ gst-plugins-base0.10-0.10.36/gst-libs/gst/audio/gstbaseaudiosink.c
2012-12-04 11:02:39.294066822 +0100
+@@ -921,6 +921,12 @@
+   if (!gst_ring_buffer_acquire (sink->ringbuffer, spec))
+     goto acquire_error;
+
++  /* We need to resync since the ringbuffer restarted */
++  sink->priv->avg_skew = -1;
++  sink->next_sample = -1;
++  sink->priv->eos_time = -1;
++  sink->priv->discont_time = -1;
++
+   if (bsink->pad_mode == GST_ACTIVATE_PUSH) {
+     GST_DEBUG_OBJECT (sink, "activate ringbuffer");
+     gst_ring_buffer_activate (sink->ringbuffer, TRUE);
diff -Nru gst-plugins-base0.10-0.10.36/debian/patches/99_ltmain_as-needed.patch
gst-plugins-base0.10-0.10.36/debian/patches/99_ltmain_as-needed.patch
--- gst-plugins-base0.10-0.10.36/debian/patches/99_ltmain_as-needed.patch
2012-02-21 10:35:51.000000000 +0100
+++ gst-plugins-base0.10-0.10.36/debian/patches/99_ltmain_as-needed.patch
2012-12-04 12:08:57.000000000 +0100
@@ -1,8 +1,8 @@
-diff --git a/ltmain.sh b/ltmain.sh
-index c7d06c3..7bc27f2 100644
---- a/ltmain.sh
-+++ b/ltmain.sh
-@@ -5800,6 +5800,11 @@ func_mode_link ()
+Index: gst-plugins-base0.10-0.10.36/ltmain.sh
+===================================================================
+--- gst-plugins-base0.10-0.10.36.orig/ltmain.sh        2012-12-04
11:22:23.710301877 +0100
++++ gst-plugins-base0.10-0.10.36/ltmain.sh     2012-12-04 11:23:37.102314806
+0100
+@@ -5800,6 +5800,11 @@
        arg=$func_stripname_result
        ;;

@@ -14,7 +14,7 @@
        -Wl,*)
        func_stripname '-Wl,' '' "$arg"
        args=$func_stripname_result
-@@ -6163,6 +6168,15 @@ func_mode_link ()
+@@ -6163,6 +6168,15 @@
        lib=
        found=no
        case $deplib in
diff -Nru gst-plugins-base0.10-0.10.36/debian/patches/series gst-plugins-
base0.10-0.10.36/debian/patches/series
--- gst-plugins-base0.10-0.10.36/debian/patches/series  2011-12-11
18:02:08.000000000 +0100
+++ gst-plugins-base0.10-0.10.36/debian/patches/series  2012-12-04
12:08:57.000000000 +0100
@@ -1,2 +1,3 @@
 10_gnome-vfs-dav-url.patch
+98_fix-ogg-flac-transition.patch
 99_ltmain_as-needed.patch


unblock gst-plugins-base0.10/0.10.36-1.1

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (901, 'unstable'), (900, 'testing'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.8-trunk-amd64 (SMP w/4 CPU cores)

--- End Message ---
--- Begin Message --- 
On Thu, Mar 14, 2013 at 02:38:12PM +0100, Christoph Reiter wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package gst-plugins-base0.10
> 

Thanks, unblocked.


-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

<directhex> i have six years of solaris sysadmin experience, from
            8->10. i am well qualified to say it is made from bonghits
			layered on top of bonghits

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: