[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#703003: [pre-approval] unblock: python-apt/0.8.8.2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package python-apt

This release would include a small fix for multi-arch support. Currently,
python-apt might look at the wrong part of the dpkg database when looking
up the file lists, thus causing an empty list to be returned. The fix
tries both possible options, those fixing the problem. 

If the removal of the (unused) translation file is a problem, it can
be reverted. Likewise, we would normally update the mirror lists from
the website (not included in diff below); I could manually make sure
that we include the ones from 0.8.8.1 instead (although an up-to-date
mirror list would be useful).

It might not strictly match the requirements for an unblock; but the
fix is extremely small and helps multi-arch. Please let me know what
you think.

=== modified file 'apt/package.py'
--- apt/package.py	2012-03-27 09:21:20 +0000
+++ apt/package.py	2013-03-13 22:47:43 +0000
@@ -1045,12 +1045,15 @@ class Package(object):
         Return a list of unicode names of the files which have
         been installed by this package
         """
-        path = "/var/lib/dpkg/info/%s.list" % self.name
-        try:
-            with open(path, "rb") as file_list:
-                return file_list.read().decode("utf-8").split(u"\n")
-        except EnvironmentError:
-            return []
+        for name in self.shortname, self.fullname:
+            path = "/var/lib/dpkg/info/%s.list" % name
+            try:
+                with open(path, "rb") as file_list:
+                    return file_list.read().decode("utf-8").split(u"\n")
+            except EnvironmentError:
+                continue
+
+        return []
 
     def get_changelog(self, uri=None, cancel_lock=None):
         """

=== modified file 'debian/changelog'
--- debian/changelog	2012-11-15 13:30:14 +0000
+++ debian/changelog	2013-03-13 22:32:41 +0000
@@ -1,3 +1,14 @@
+python-apt (0.8.8.2) UNRELEASED; urgency=low
+
+  [ David Prévot ]
+  * po/no.po: Remove useless translation (superseded by nb.po)
+
+  [ Julian Andres Klode ]
+  * apt/package.py: Try both filenames for package file lists
+    (Closes: #700715)
+
+ -- David Prévot <taffit@debian.org>  Wed, 28 Nov 2012 21:37:17 -0400
+
 python-apt (0.8.8.1) unstable; urgency=low
 
   * python/tag.cc:

=== removed file 'po/no.po'
--- po/no.po	2012-06-30 20:55:52 +0000
+++ po/no.po	1970-01-01 00:00:00 +0000

unblock python-apt/0.8.8.2

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'unstable'), (500, 'testing'), (500, 'stable'), (100, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-- 
Julian Andres Klode  - Debian Developer, Ubuntu Member

See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.


Reply to: