[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#688321: unblock: quota/4.01-1



Hi!

intrigeri <intrigeri@debian.org> writes:
> Michael Meskes wrote (27 Dec 2012 11:21:56 GMT) :
>>> > Would it be possible to get *only* the xfs fix in testing instead of the
>>> > whole new release?
>
>> Where does fixing the XFS problem differ from fixing the other bugs
>> in 4.01?
>
> As I understand it (and not being a member of the release team), it
> differs because that one has been reported in Debian as the #685356
> important bug, while the others have not. At this time of the freeze,
> including a new upstream release because it fixes a lot of more or
> less important bugs (and adds a few features..) is probably not an
> option. I guess that's exactly why Salvatore prepared a minimal
> t-p-u debdiff.
>
> But well, if you feel like every change in 4.01 satisfies the current
> freeze policy and should be fixed in Wheezy, then please feel free to
> explain why :)
>
>> Anyway, we can surely do a Wheezy version of 4.00 that fixes XFS.
>
> OK. Do you ACK Salvatore's proposed t-p-u debdiff?

Hm could we maybe add 8b6ce13e1b196cb9d0cc5b24dfc75c97a9eb883d (upstream
git) as well?
Seems to be the one addressing (at least the second half of)
#698864. Cc-ed the folks there to check the fixed quota 4.00 binary they
deployed is actually using this patch.

    Christoph

8b6ce13e1b196cb9d0cc5b24dfc75c97a9eb883d
>>>
>From 8b6ce13e1b196cb9d0cc5b24dfc75c97a9eb883d Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@suse.cz>
Date: Mon, 20 Aug 2012 19:16:05 +0200
Subject: [PATCH] quota: Fix reporting of NFS mountpoints

Commit b8ab76ad19e3c284ac14bd0450662bfc41719e03 creating split_nfs_mount()
forgot to remove zeroing of pathname character. That lead to broken reporting
quotas for NFSv3 mount points.

Thanks to anonymous reporter for spotting this.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 rquota_client.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/rquota_client.c b/rquota_client.c
index 54a8921..e26e066 100644
--- a/rquota_client.c
+++ b/rquota_client.c
@@ -162,7 +162,6 @@ int rpc_rquota_get(struct dquot *dquot)
 		return -ENOENT;
 	}
 
-	*pathname++ = '\0';
 	/* For NFSv4, we send the filesystem path without initial /. Server prepends proper
 	 * NFS pseudoroot automatically and uses this for detection of NFSv4 mounts. */
 	if ((dquot->dq_h->qh_io_flags & IOFL_NFS_MIXED_PATHS) &&
-- 
1.7.4.1
<<<


Reply to: