[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#699148: marked as done (unblock: celery/2.5.3-3)

Your message dated Sat, 02 Mar 2013 18:47:51 +0000
with message-id <1362250071.11072.41.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#699148: unblock: celery/2.5.3-2
has caused the Debian Bug report #699148,
regarding unblock: celery/2.5.3-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
699148: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699148
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Please unblock package celery

2.5.3-2 fixes #697195 (RC) which was caused by the user "celery" not being
created in postinst. The attached debdiff introduces a new dependency on
adduser and postinst/postrm maintainer scripts to take care of creation/removal
of the user "celery".

unblock celery/2.5.3-2

- -- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.7-trunk-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAlEGIV0ACgkQeJ3z1zFMUGa59wCdHVdTU4HktmZRPBbIH9syvEGc
8oEAoIP+AKFXpqlXUszbsySEb3sMc7G0
=JeZK
-----END PGP SIGNATURE-----

diff -Nru celery-2.5.3/debian/changelog celery-2.5.3/debian/changelog
--- celery-2.5.3/debian/changelog	2012-05-30 16:04:38.000000000 +0200
+++ celery-2.5.3/debian/changelog	2013-01-22 13:02:04.000000000 +0100
@@ -1,3 +1,10 @@
+celery (2.5.3-2) unstable; urgency=low
+
+  * Create user celery in maintainer scripts (Closes: #697195).
+  * Update year in d/copyright.
+
+ -- Michael Fladischer <FladischerMichael@fladi.at>  Sun, 13 Jan 2013 19:10:12 +0100
+
 celery (2.5.3-1) unstable; urgency=low
 
   * New upstream release.
diff -Nru celery-2.5.3/debian/control celery-2.5.3/debian/control
--- celery-2.5.3/debian/control	2012-05-30 16:04:38.000000000 +0200
+++ celery-2.5.3/debian/control	2013-01-22 13:02:04.000000000 +0100
@@ -36,7 +36,8 @@
 
 Package: python-celery
 Architecture: all
-Depends: python-amqplib,
+Depends: adduser,
+         python-amqplib,
          python-anyjson (>= 0.3.1),
          python-cl,
          python-dateutil (>= 1.5),
diff -Nru celery-2.5.3/debian/copyright celery-2.5.3/debian/copyright
--- celery-2.5.3/debian/copyright	2012-05-30 16:04:38.000000000 +0200
+++ celery-2.5.3/debian/copyright	2013-01-22 13:02:04.000000000 +0100
@@ -16,7 +16,7 @@
 License: BSD
 
 Files: debian/*
-Copyright: 2012, Michael Fladischer
+Copyright: 2012-2013, Michael Fladischer
            2010, Elliot Murphy
 License: BSD-solem
 
diff -Nru celery-2.5.3/debian/python-celery.postinst celery-2.5.3/debian/python-celery.postinst
--- celery-2.5.3/debian/python-celery.postinst	1970-01-01 01:00:00.000000000 +0100
+++ celery-2.5.3/debian/python-celery.postinst	2013-01-27 23:32:21.000000000 +0100
@@ -0,0 +1,29 @@
+#!/bin/sh
+
+set -e
+
+case "$1" in
+    configure|reconfigure)
+        adduser \
+            --system \
+            --quiet \
+            --home /usr/share/pyshared/celery \
+            --no-create-home \
+            --group \
+            celery
+    ;;
+
+    abort-upgrade|abort-remove|abort-deconfigure)
+        exit 0
+    ;;
+
+    *)
+        echo "postinst called with unknown argument \`$1'" >&2
+        exit 1
+    ;;
+esac
+
+#DEBHELPER#
+
+exit 0
+
diff -Nru celery-2.5.3/debian/python-celery.postrm celery-2.5.3/debian/python-celery.postrm
--- celery-2.5.3/debian/python-celery.postrm	1970-01-01 01:00:00.000000000 +0100
+++ celery-2.5.3/debian/python-celery.postrm	2013-01-27 23:32:21.000000000 +0100
@@ -0,0 +1,23 @@
+#!/bin/sh
+
+set -e
+
+case "$1" in
+    purge)
+        if [ -x "$(command -v deluser)" ]; then
+            deluser --quiet --system celery > /dev/null || true
+            deluser --group --system --quiet --only-if-empty celery || true
+        else
+            echo >&2 "not removing celery system account and group because deluser command was not found"
+        fi
+	;;
+    remove|upgrade|failed-upgrade|abort-install|abort-upgrade|disappear)
+	;;
+    *)
+	echo "postrm called with unknown argument \`$1'" >&2
+        exit 1
+esac
+
+#DEBHELPER#
+
+exit 0

--- End Message ---
--- Begin Message --- 
On Fri, 2013-03-01 at 12:02 +0100, Julien Cristau wrote:
> On Fri, Mar  1, 2013 at 12:01:01 +0100, Michael Fladischer wrote:
> 
> > On 2013-03-01 11:43, Julien Cristau wrote:
> > I know what you mean, that I could remove the logfiles directory no
> > matter what happens to the user/group. I can do this in celery-2.5.3-4
> > if you deem this a better way to handle it.
> > 
> I do.

-4 was uploaded with that change, and I've unblocked it; thanks.

fwiw, should a -5 be necessary for some reason, this message:

+            echo >&2 "not removing celery system account, group and logfiles because deluser command was not found"

is no longer technically accurate.

Regards,

Adam

--- End Message ---
Reply to: