[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700928: marked as done (unblock: ruby-activeldap/1.2.4-3)

Your message dated Sat, 23 Feb 2013 15:59:59 +0000
with message-id <1361635199.20752.27.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#700928: unblock: ruby-activeldap/1.2.4-3
has caused the Debian Bug report #700928,
regarding unblock: ruby-activeldap/1.2.4-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
700928: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700928
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
User: release.debian.org@packages.debian.org
Usertags: unblock
Severity: normal


Coin,
When the previous version was uploaded, it worked. Currently, the i18n code crash, which is probably due to changes in the Ruby/Rails i18n classes which happened last year. Depending on the combination of ruby-gettext/ruby-fastgettext installed on your system, it might not crash (probably when none are), but i'm not going into lenghty digging and patching. Nevertheless, po files (yes, not mo) are missing, and this is a packaging bug. 
Thus, I made the package install those missing po files, and made 2 
tiny one-liner patches to fix the po path and a misnamed locale name. 
These are trivial fixes (see debdiff attached), so i do think it should 
be allowed in wheezy. It was found late (two days ago) because i was not 
actively using this lib these last few months and noone complained.

Command:
  unblock ruby-activeldap/1.2.4-3

Regards.

--
Marc Dequènes
diff -Nru ruby-activeldap-1.2.4/debian/changelog ruby-activeldap-1.2.4/debian/changelog
--- ruby-activeldap-1.2.4/debian/changelog	2012-06-30 18:12:40.000000000 +0200
+++ ruby-activeldap-1.2.4/debian/changelog	2013-02-18 01:57:33.000000000 +0100
@@ -1,3 +1,10 @@
+ruby-activeldap (1.2.4-3) unstable; urgency=low
+
+  * Fixed translation files not installed.
+  * Added patch to fix loading japanese translations.
+
+ -- Marc Dequènes (Duck) <Duck@DuckCorp.org>  Mon, 18 Feb 2013 00:30:42 +0100
+
 ruby-activeldap (1.2.4-2) unstable; urgency=low
 
   * Bump build dependency on gem2deb to >= 0.3.0~.
diff -Nru ruby-activeldap-1.2.4/debian/patches/gettext_misnamed_locale ruby-activeldap-1.2.4/debian/patches/gettext_misnamed_locale
--- ruby-activeldap-1.2.4/debian/patches/gettext_misnamed_locale	1970-01-01 01:00:00.000000000 +0100
+++ ruby-activeldap-1.2.4/debian/patches/gettext_misnamed_locale	2013-02-18 01:54:30.000000000 +0100
@@ -0,0 +1,13 @@
+Index: ruby-activeldap/lib/active_ldap/get_text_support.rb
+===================================================================
+--- ruby-activeldap.orig/lib/active_ldap/get_text_support.rb	2013-02-18 01:53:36.122949120 +0100
++++ ruby-activeldap/lib/active_ldap/get_text_support.rb	2013-02-18 01:54:26.370702741 +0100
+@@ -12,7 +12,7 @@
+           include(GetText::Translation)
+           po_dir = "/usr/share/ruby-activeldap/po"
+           GetText.add_text_domain('active-ldap', :path => po_dir, :type => :po)
+-          GetText.default_available_locales = ['en', 'jp']
++          GetText.default_available_locales = ['en', 'ja']
+           GetText.default_text_domain = "active-ldap"
+         end
+       end
diff -Nru ruby-activeldap-1.2.4/debian/patches/gettext_po_path ruby-activeldap-1.2.4/debian/patches/gettext_po_path
--- ruby-activeldap-1.2.4/debian/patches/gettext_po_path	1970-01-01 01:00:00.000000000 +0100
+++ ruby-activeldap-1.2.4/debian/patches/gettext_po_path	2013-02-18 01:44:19.000000000 +0100
@@ -0,0 +1,14 @@
+Index: ruby-activeldap/lib/active_ldap/get_text_support.rb
+===================================================================
+--- ruby-activeldap.orig/lib/active_ldap/get_text_support.rb	2013-02-18 00:29:52.000000000 +0100
++++ ruby-activeldap/lib/active_ldap/get_text_support.rb	2013-02-18 01:43:07.658020919 +0100
+@@ -10,8 +10,7 @@
+       def included(base)
+         base.class_eval do
+           include(GetText::Translation)
+-          po_dir = File.join(File.dirname(__FILE__), "..", "..", "po")
+-          po_dir = File.expand_path(po_dir)
++          po_dir = "/usr/share/ruby-activeldap/po"
+           GetText.add_text_domain('active-ldap', :path => po_dir, :type => :po)
+           GetText.default_available_locales = ['en', 'jp']
+           GetText.default_text_domain = "active-ldap"
diff -Nru ruby-activeldap-1.2.4/debian/patches/series ruby-activeldap-1.2.4/debian/patches/series
--- ruby-activeldap-1.2.4/debian/patches/series	2011-07-28 18:55:58.000000000 +0200
+++ ruby-activeldap-1.2.4/debian/patches/series	2013-02-18 01:54:10.000000000 +0100
@@ -1 +1,3 @@
 gem_sux
+gettext_po_path
+gettext_misnamed_locale
diff -Nru ruby-activeldap-1.2.4/debian/ruby-activeldap.install ruby-activeldap-1.2.4/debian/ruby-activeldap.install
--- ruby-activeldap-1.2.4/debian/ruby-activeldap.install	1970-01-01 01:00:00.000000000 +0100
+++ ruby-activeldap-1.2.4/debian/ruby-activeldap.install	2013-02-18 00:34:54.000000000 +0100
@@ -0,0 +1 @@
+po usr/share/ruby-activeldap/


--- End Message ---


--- Begin Message ---


On Tue, 2013-02-19 at 14:33 +0100, Marc Dequènes wrote:
> When the previous version was uploaded, it worked. Currently, the i18n 
> code crash, which is probably due to changes in the Ruby/Rails i18n 
> classes which happened last year. Depending on the combination of 
> ruby-gettext/ruby-fastgettext installed on your system, it might not 
> crash (probably when none are), but i'm not going into lenghty digging 
> and patching. Nevertheless, po files (yes, not mo) are missing, and this 
> is a packaging bug.

Unblocked.

Regards,

Adam

--- End Message ---







Reply to: