[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700194: unblock: python3-defaults/3.2.3-6



On Sat, Feb  9, 2013 at 13:32:10 -0500, Scott Kitterman wrote:

> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package python3-defaults
> 
> First, apologies for this late unblock request.  I'd been focused on getting
> python2.7/python-defaults updated and thought one of my co-maintainers had
> taken care of this already.  Changelog below is annotated with why I think
> this should be unblocked.
> 
Thanks for the explanations.

> python3-defaults (3.2.3-6) unstable; urgency=low
> 
>   [ Piotr Ożarowski ]
>   * dh_python3
>     - ignore empty files while trying to normalize shebangs
> 
> This fixed build failures, so there are likely packages that built since this
> was uploaded to Sid that won't build in Wheezy.
> 
>     - mention the right file (debian/py3dist-overrides) while warning about
>       guessed dependency - thanks to Sebastian Ramacher for the patch
>       (Closes: #685067)
> 
> Trivial documentation fix.  Not critical, but good to have and certainly not
> worth a TPU upload to avoid.
> 
>     - fix generating dependencies when maximum version is specified
>       (Closes: #687060)
> 
> This fixed build failures, so there are likely packages that built since this
> was uploaded to Sid that won't build in Wheezy.
> 
>   * py3versions.py: fix parsing DEBPYTHON3_SUPPORTED env. variable
>     (versions should be separated using comma, as in debian_defaults
>     config file)
> 
> This is similar to the change that was just part of the python-defaults
> unblock.  It's here for tests.  There are packages that use the env variable,
> but all maintained by p1otr and he'd checked they work with this change.  To
> stay in line with the way pyversions.py will work in Wheezy, this should go
> in.
> 
>   * py3versions, debpython: close previously opened files - thanks to Dmitry
>     Shachnev for the patch (Closes: #686587)
> 
> This is a bug.  Not critical, but not worth a TPU upload to avoid.
> 
Mostly looks like a bunch of no-ops to me, but ok...

>   [ Dmitry Shachnev ]
>   [ Barry Warsaw ]
>   * py3clean: Don't remove everything in the __pycache__ directory for
>     system site package directories. Prevents bogus cleaning of unrelated
>     *.pyc files. Original patch by Dmitry, with review, clean up, small
>     modifications, and additional comments by Barry. (Closes: #685167)
> 
> This is a significant bug that should be fixed.
> 
:type magic_tag: None or False or str
makes me cringe, but hey, it's your code...

>   [ Barry Warsaw ]
>   * dh_python3: Rework calculation of extension tags to add support for
>     Python 3.3's different suffixes, and to allow for unadorned .so files
>     to assume they are built with the default Python 3 version.
>     Closes: 672178
> 
> This is not essential for Wheezy, but will make working with python3.3 much
> easier for people that want to do it.  I think it's worth making the change to
> make Wheezy a better platform for Python 3 development.
> 
>   * README.derivatives: It is no longer necessary to edit
>     debian/py3versions.py since the values are taken from
>     debian_defaults. Also added some text on how to separate the
>     specification when multiple versions are supported.
>   * Makefile: Fix the nosetests3 command. Closes: 690259
> 
> These don't directly impact the way the package works and are nice to have.
> Not worth uploading to TPU to avoid.
> 
>  -- Piotr Ożarowski <piotr@debian.org>  Sun, 21 Oct 2012 21:29:45 +0200
> 
> This has been in Sid for several months without issue.  At this point the
> risks of not including it (because packages have built against it) is, in my
> opinion, greater than the risk of including it.
> 
So there's bits in debpython/depends.py I don't understand.

Why is maxv sometimes inclusive and sometimes exclusive?
Why change the minv == maxv case?

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: