[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#700344: marked as done (unblock: icinga/1.7.1-6)

Your message dated Mon, 11 Feb 2013 21:55:11 +0000
with message-id <20130211215511.GG5321@ernie.home.powdarrmonkey.net>
and subject line Re: Bug#700344: unblock: icinga/1.7.1-6
has caused the Debian Bug report #700344,
regarding unblock: icinga/1.7.1-6
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
700344: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=700344
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package icinga

This upload fixes a bug that destroys icinga.cfg on systems that
replaced the config with symlinks. DSA has been bitten by that
problem.

unblock icinga/1.7.1-6

-- System Information:
Debian Release: 7.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.8.0-rc4+ (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

diff -u icinga-1.7.1/debian/icinga-common.postinst icinga-1.7.1/debian/icinga-common.postinst
--- icinga-1.7.1/debian/icinga-common.postinst
+++ icinga-1.7.1/debian/icinga-common.postinst
@@ -68,8 +68,6 @@
 			;;
 	esac
 
-	cp -a -f "$conffile" "$conffile".tmp
-
 	# If the admin deleted or commented some variables but then set
 	# them via debconf, (re-)add them to the config file.
 
@@ -77,11 +75,8 @@
 	grep -Eq '^ *check_external_commands=' "$conffile" || \
 	echo "check_external_commands=" >> "$conffile"
 
-	sed -e "s|^ *check_external_commands=.*|check_external_commands=$check_external_commands|" \
-	< "$conffile" > "$conffile.tmp"
-
-	mv -f "$conffile".tmp "$conffile"
-
+	sed --follow-symlinks -i -e "s|^ *check_external_commands=.|check_external_commands=$check_external_commands|" \
+		"$conffile"
 	# Stop a not already stopped icinga instance,
 	# debhelper will start it again automatically at the bottom
 	status="$(/etc/init.d/icinga status >/dev/null 2>&1; echo $?)"
diff -u icinga-1.7.1/debian/changelog icinga-1.7.1/debian/changelog
--- icinga-1.7.1/debian/changelog
+++ icinga-1.7.1/debian/changelog
@@ -1,3 +1,10 @@
+icinga (1.7.1-6) unstable; urgency=medium
+
+  * Don't destroy symlinked icinga configs with sed 
+    (Closes: #698137)
+
+ -- Alexander Wirt <formorer@debian.org>  Mon, 11 Feb 2013 22:03:15 +0100
+
 icinga (1.7.1-5) unstable; urgency=high
 
   * Apply fix for CVE-2012-6096 - buffer overflows in cgis

--- End Message ---
--- Begin Message --- 
On Mon, Feb 11, 2013 at 10:24:45PM +0100, Alexander Wirt wrote:
> Please unblock package icinga
> 
> This upload fixes a bug that destroys icinga.cfg on systems that
> replaced the config with symlinks. DSA has been bitten by that
> problem.

Already unblocked by Adam.

Thanks,

-- 
Jonathan Wiltshire                                      jmw@debian.org
Debian Developer                         http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51

<directhex> i have six years of solaris sysadmin experience, from
            8->10. i am well qualified to say it is made from bonghits
			layered on top of bonghits

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: