Bug#699857: unblock: dynalogin - fixes RC issue with oath_callback / strcmp semantics

[Daniel Pocock <daniel@pocock.com.au>]

Package: release.debian.org
Severity: normal

This is a brief fix (3 lines)

debdiff attached

It also makes minor fixes to the control file (update maintainer contact
details, correct VCS location)

diff -u dynalogin-0.9.14/debian/changelog dynalogin-0.9.14/debian/changelog
--- dynalogin-0.9.14/debian/changelog
+++ dynalogin-0.9.14/debian/changelog
@@ -1,3 +1,12 @@
+dynalogin (0.9.14-2) unstable; urgency=low
+
+  * Correct behavior of oath_callback (Closes: #699856)
+  * Tweak title and description text
+  * Update control file for migration from collab-maint to pkg-auth
+  * Remove deprecated DM-Upload-Allowed
+
+ -- Daniel Pocock <daniel@pocock.com.au>  Tue, 05 Feb 2013 23:25:37 +0100
+
 dynalogin (0.9.14-1) unstable; urgency=low
 
   * Initial packaging. (Closes: #665831).
diff -u dynalogin-0.9.14/debian/control dynalogin-0.9.14/debian/control
--- dynalogin-0.9.14/debian/control
+++ dynalogin-0.9.14/debian/control
@@ -1,20 +1,19 @@
 Source: dynalogin
 Section: admin
 Priority: optional
-Maintainer: Daniel Pocock <daniel@pocock.com.au>
-Uploaders: Stuart Teasdale <sdt@debian.org>
+Maintainer: Debian Authentication Maintainers <pkg-auth-maintainers@lists.alioth.debian.org>
+Uploaders: Daniel Pocock <daniel@pocock.com.au>
 Build-Depends: cdbs, debhelper (>= 8.0.0), libapr1-dev, liboath-dev, unixodbc-dev, autotools-dev, pkg-config
 Homepage: http://www.dynalogin.org/
 Standards-Version: 3.9.3
-DM-Upload-Allowed: yes
-Vcs-Git: git://git.debian.org/collab-maint/dynalogin.git
-Vcs-Browser: http://git.debian.org/?p=collab-maint/dynalogin.git;a=summary
+Vcs-Git: git://git.debian.org/pkg-auth/dynalogin.git
+Vcs-Browser: http://git.debian.org/?p=pkg-auth/dynalogin.git;a=summary
 
 Package: libdynalogin-1-0
 Section: libs
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: dynalogin - two-factor HOTP authentication - implementation libs
+Description: two-factor HOTP authentication - implementation libs
  dynalogin is a two-factor authentication framework based on the HOTP
  (Open Authentication) algorithm.  Dynalogin can store credentials in
  any database supported by UNIXODBC, which makes the solution
@@ -32,7 +31,7 @@
 Package: dynalogin-server
 Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
-Description: dynalogin - two-factor HOTP authentication - server daemon
+Description: two-factor HOTP authentication - server daemon
  dynalogin is a two-factor authentication framework based on the HOTP
  (Open Authentication) algorithm.  Dynalogin can store credentials in 
  any database supported by UNIXODBC, which makes the solution
@@ -49,7 +48,7 @@
 Section: web
 Architecture: all
 Depends: ${misc:Depends}
-Description: dynalogin - two-factor HOTP authentication - PHP authentication
+Description: two-factor HOTP authentication - PHP client
  dynalogin is a two-factor authentication framework based on the HOTP
  (Open Authentication) algorithm.  Dynalogin can store credentials in 
  any database supported by UNIXODBC, which makes the solution
@@ -67,7 +66,7 @@
 Section: web
 Architecture: all
 Depends: ${misc:Depends}, simpleid, dynalogin-client-php
-Description: dynalogin - two-factor HOTP authentication - OpenID provider
+Description: two-factor HOTP authentication - OpenID provider
  dynalogin is a two-factor authentication framework based on the HOTP
  (Open Authentication) algorithm.  Dynalogin can store credentials in
  any database supported by UNIXODBC, which makes the solution
only in patch2:
unchanged:
--- dynalogin-0.9.14.orig/libdynalogin/dynalogin.c
+++ dynalogin-0.9.14/libdynalogin/dynalogin.c
@@ -141,7 +141,7 @@
 		return -1;
 	}
 
-	return strcmp(pvt->code, test_str);
+	return abs(strcmp(pvt->code, test_str));
 }
 
 dynalogin_result_t dynalogin_authenticate
only in patch2:
unchanged:
--- dynalogin-0.9.14.orig/libdynalogin/hotpdigest.c
+++ dynalogin-0.9.14/libdynalogin/hotpdigest.c
@@ -11,6 +11,7 @@
 #include "hotpdigest.h"
 
 #include <stdio.h>		/* For snprintf, getline. */
+#include <stdlib.h>
 #include <string.h>		/* For strverscmp. */
 
 #include "gc.h"
@@ -104,7 +105,7 @@
         }
       make_hex_string(_response_raw, _response, GC_MD5_DIGEST_SIZE);
 
-      return strcmp (pvt->response, _response);
+      return abs(strcmp (pvt->response, _response));
 
 }