[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#682906: unblock: python-defaults/2.7.3-2



On Thu, Jul 26, 2012 at 18:50:29 -0400, Scott Kitterman wrote:

> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Please unblock package python-defaults
> 
A few comments/questions below.

> The RC bug in unstable (#680793) that prevented this from migrating with an
> automatice freeze exception is fixed in this upload.  Unblocking this will do
> a number of beneficial things for squeeze:
> 
I assume s/squeeze/wheezy/ (and below)

>  - Match the version number for python and python2.7.3.  Although this is
>    costmetic, it does cause confusion.
> 
>  - Matches the feature set in squeeze between dh_python2 and dh_python3.  It
>    would be difficult for backporters, derivatives, and third party vendors to
>    keep straight which did what with a skewed feature set.  This is better
>    avoided.
> 
> This is low risk to do because the changes have already been exercised in
> dh_python3.  In fact, the issues it had were with dh_python2 code that had not
> been completely adapted to python3.  The changes in this package for python
> are solid.
> 
There's also much fewer users of python3 than python2...

> I am attaching both the debdiff for this upload and for testing to show the
> minor nature of the changes from what already had, at one time, a freeze
> exception.
> 
> unblock python-defaults/2.7.3-2

> diff -Nru python-defaults-2.7.3~rc2/debian/changelog python-defaults-2.7.3/debian/changelog
> --- python-defaults-2.7.3~rc2/debian/changelog	2012-06-05 22:58:56.000000000 -0400
> +++ python-defaults-2.7.3/debian/changelog	2012-07-26 18:26:27.000000000 -0400
> @@ -1,3 +1,46 @@
> +python-defaults (2.7.3-2) unstable; urgency=low
> +
> +  * dh_python2: ignore empty files while trying to normalize shebangs
> +    (Closes: #680793)
> +  * Fix lack of python-imaging in pydist/dist_fallback
> +    - Add python-imaging override to pydist/generate_fallback_list.py
> +    - pydist/dist_fallback: Regenerate to add python-imaging (which wasn't
> +      recognized before due to .pth file) along with a few automatic
> +      adjustments 
> +
> + -- Piotr Ożarowski <piotr@debian.org>  Thu, 26 Jul 2012 23:03:32 +0200
> +
> +python-defaults (2.7.3-1) unstable; urgency=low
> +
> +  [ Piotr Ożarowski ]
> +  * dh_python2:
> +    - remove even more \.so.* dangling symlinks, thanks to Stefano
> +      Rivera for providing a test case
> +    - rewrite shebangs by default (disable via --no-shebang-rewrite),
> +      examples:
> +       + "/usr/bin/env python*" → "/usr/bin/python*"
> +       + "/usr/local/bin/python foo" → "/usr/bin/python foo"
> +       + "/usr/bin/python2" → "/usr/bin/python"
> +    - new --shebang option to replace all shebangs in bin dirs
> +      (example: --shebang /usr/bin/python2.6)
> +    - no longer generates python2.X | python2.Y depenendies for public modules
> +      (Closes: 625740)
> +    - translate Python version numbers into Debian ones for those
> +      require.txt items that have a pydist file with (uscan like) rules
> +      or PEP386 flag (Closes: #653740)
> +  * Improve dh_python2 manpage a bit, add information about cleaning debug
> +    packages (Closes: #653741)
> +  * pyversions, dh_python2, pycompile: allow to override system's list of
> +    supported Python versions via DEBPYTHON_SUPPORTED and default Python
> +    version via DEBPYTHON_DEFAULT env. variables

So I'm rather uneasy about this bit with env vars...  It doesn't seem to
fix a bug (much less a RC one), and I'm not sure why we need that.

> +  * Debhelper's python2 sequence now inserts dh_python2 before dh_installinit
> +    (closes: 670418)
> +
> +  [ Scott Kitterman ]
> +  * Bump upstream version to match current unstable/wheezy python2.7 version
> +
> + -- Piotr Ożarowski <piotr@debian.org>  Sat, 30 Jun 2012 20:23:59 +0200
> +
>  python-defaults (2.7.3~rc2-1) unstable; urgency=low
>  
>    [ Scott Kitterman ]

Why is some stuff being removed from pydist/dist_fallback?  What is that
file for?

And as discussed on IRC the prerm/postrm changes are broken and need a
revert.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: