[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697894: marked as done (unblock: gnome-control-center/1:3.4.3.1-2)



Your message dated Thu, 31 Jan 2013 15:50:26 +0100
with message-id <510A84B2.1030201@thykier.net>
and subject line Re: Bug#697894: unblock: gnome-control-center/1:3.4.3.1-2
has caused the Debian Bug report #697894,
regarding unblock: gnome-control-center/1:3.4.3.1-2
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
697894: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=697894
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi,

please unblock gnome-control-center. Apart from a handful of upstream 
fixes, the changes consist in using NetworkManager user connections when 
system connections are not available, and to store passwords in the 
keyring if necessary.

With that, we’re getting close to having the NM clusterfuck fixed. Only 
gnome-shell remains.


gnome-control-center (1:3.4.3.1-1) unstable; urgency=low

  * New upstream stable release.
  * 11_revert_printer_class.patch: revert, merged upstream.
  * 03_network_null_unref.patch: patch from upstream git. Fix a critical 
    warning caused by g_object_unref (NULL).
  * 04_network_crash_signals.patch: patch from upstream git. Correctly 
    disconnect signal handlers to avoid crashes.
  * 11_network_user_connections.patch: new patch, similar to nm-applet 
    (also requires the changes in libnm-gtk). Set passwords as 
    agent-owned when they need to, to allow users without root 
    permissions to easily configure their connections.
    + CDMA and GSM connections are always user-owned.
    + WEP/WPA connections are system-owned if user has the permissions
      (with NM’s config, that is netdev or sudo membership), user-owned
      otherwise. The password is stored in the keyring for WPA, not for
      WEP.
    + WiMax / Wired connections are always system-owned.


unblock gnome-control-center/1:3.4.3.1-1

Thanks,
-- 
 .''`.      Josselin Mouette
: :' :
`. `'
  `-
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/aclocal.m4 gnome-control-center-3.4.3.1/aclocal.m4
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/ChangeLog gnome-control-center-3.4.3.1/ChangeLog
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/compile gnome-control-center-3.4.3.1/compile
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/config.guess gnome-control-center-3.4.3.1/config.guess
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/configure gnome-control-center-3.4.3.1/configure
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/configure.ac gnome-control-center-3.4.3.1/configure.ac
--- gnome-control-center-3.4.2+git20121016.29d7c0/configure.ac	2012-11-07 18:52:59.000000000 +0100
+++ gnome-control-center-3.4.3.1/configure.ac	2012-12-10 16:07:52.000000000 +0100
@@ -1,4 +1,4 @@
-m4_define([gnome_control_center_version], 3.4.2)
+m4_define([gnome_control_center_version], 3.4.3.1)
 AC_INIT([gnome-control-center], [gnome_control_center_version],
         [http://bugzilla.gnome.org/enter_bug.cgi?product=gnome-control-center])
 
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/debian/changelog gnome-control-center-3.4.3.1/debian/changelog
--- gnome-control-center-3.4.2+git20121016.29d7c0/debian/changelog	2012-11-07 19:52:05.000000000 +0100
+++ gnome-control-center-3.4.3.1/debian/changelog	2013-01-10 23:54:45.000000000 +0100
@@ -1,3 +1,24 @@
+gnome-control-center (1:3.4.3.1-1) unstable; urgency=low
+
+  * New upstream stable release.
+  * 11_revert_printer_class.patch: revert, merged upstream.
+  * 03_network_null_unref.patch: patch from upstream git. Fix a critical 
+    warning caused by g_object_unref (NULL).
+  * 04_network_crash_signals.patch: patch from upstream git. Correctly 
+    disconnect signal handlers to avoid crashes.
+  * 11_network_user_connections.patch: new patch, similar to nm-applet 
+    (also requires the changes in libnm-gtk). Set passwords as 
+    agent-owned when they need to, to allow users without root 
+    permissions to easily configure their connections.
+    + CDMA and GSM connections are always user-owned.
+    + WEP/WPA connections are system-owned if user has the permissions
+      (with NM’s config, that is netdev or sudo membership), user-owned
+      otherwise. The password is stored in the keyring for WPA, not for
+      WEP.
+    + WiMax / Wired connections are always system-owned.
+
+ -- Josselin Mouette <joss@debian.org>  Thu, 10 Jan 2013 23:54:31 +0100
+
 gnome-control-center (1:3.4.2+git20121016.29d7c0-1) unstable; urgency=low
 
   [ Josselin Mouette ]
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/03_network_null_unref.patch gnome-control-center-3.4.3.1/debian/patches/03_network_null_unref.patch
--- gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/03_network_null_unref.patch	1970-01-01 01:00:00.000000000 +0100
+++ gnome-control-center-3.4.3.1/debian/patches/03_network_null_unref.patch	2012-12-18 00:27:54.000000000 +0100
@@ -0,0 +1,25 @@
+From 160697df6ca870efc153c77d32f42ffb05359c1d Mon Sep 17 00:00:00 2001
+From: Richard Hughes <richard@hughsie.com>
+Date: Wed, 30 May 2012 11:39:48 +0000
+Subject: network: Do not print a critical warning when NetworkManager is restarted
+
+Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=676369
+---
+(limited to 'panels/network/cc-network-panel.c')
+
+diff --git a/panels/network/cc-network-panel.c b/panels/network/cc-network-panel.c
+index 50fa7b3..4e82677 100644
+--- a/panels/network/cc-network-panel.c
++++ b/panels/network/cc-network-panel.c
+@@ -693,7 +693,8 @@ panel_refresh_killswitch_visibility (CcNetworkPanel *panel)
+                                 break;
+                         }
+                 }
+-                g_object_unref (object_tmp);
++                if (object_tmp != NULL)
++                        g_object_unref (object_tmp);
+         } while (!show_flight_toggle && gtk_tree_model_iter_next (model, &iter));
+ 
+         /* only show toggle if there are wireless devices */
+--
+cgit v0.9.0.2
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/04_network_crash_signals.patch gnome-control-center-3.4.3.1/debian/patches/04_network_crash_signals.patch
--- gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/04_network_crash_signals.patch	1970-01-01 01:00:00.000000000 +0100
+++ gnome-control-center-3.4.3.1/debian/patches/04_network_crash_signals.patch	2012-12-18 00:41:53.000000000 +0100
@@ -0,0 +1,50 @@
+From c6f49c2872dcd3a4bbf0ce2d9b315faff3ea9656 Mon Sep 17 00:00:00 2001
+From: Matthias Clasen <mclasen@redhat.com>
+Date: Wed, 27 Jun 2012 23:02:02 -0400
+Subject: [PATCH] network: avoid crashes due to leftover signal handlers
+
+The libnm objects can survive the disposal of the network panel.
+If we don't disconnect the signal handlers on them, bad things
+can happen. Use g_signal_connect_object to tie the life-cycle
+of the signal handlers to the panel.
+https://bugzilla.gnome.org/show_bug.cgi?id=677969
+---
+ panels/network/cc-network-panel.c |   16 ++++++----------
+ 1 file changed, 6 insertions(+), 10 deletions(-)
+
+diff --git a/panels/network/cc-network-panel.c b/panels/network/cc-network-panel.c
+index 6cd7298..ca527d9 100644
+--- a/panels/network/cc-network-panel.c
++++ b/panels/network/cc-network-panel.c
+@@ -647,14 +647,10 @@ object_removed_cb (NetObject *object, CcNetworkPanel *panel)
+ static void
+ register_object_interest (CcNetworkPanel *panel, NetObject *object)
+ {
+-        g_signal_connect (object,
+-                          "changed",
+-                          G_CALLBACK (object_changed_cb),
+-                          panel);
+-        g_signal_connect (object,
+-                          "removed",
+-                          G_CALLBACK (object_removed_cb),
+-                          panel);
++        g_signal_connect_object (object, "changed",
++                                 G_CALLBACK (object_changed_cb), panel, 0);
++        g_signal_connect_object (object, "removed",
++                                 G_CALLBACK (object_removed_cb), panel, 0);
+ }
+ 
+ static void
+@@ -729,8 +725,8 @@ panel_add_device (CcNetworkPanel *panel, NMDevice *device)
+         g_debug ("device %s type %i",
+                  nm_device_get_udi (device),
+                  nm_device_get_device_type (device));
+-        g_signal_connect (G_OBJECT (device), "notify::state",
+-                          (GCallback) device_state_notify_changed_cb, panel);
++        g_signal_connect_object (G_OBJECT (device), "notify::state",
++                                 (GCallback) device_state_notify_changed_cb, panel, 0);
+ 
+         /* do we have to get additonal data from ModemManager */
+         if (type == NM_DEVICE_TYPE_MODEM) {
+-- 
+1.7.10.4
\ Pas de fin de ligne à la fin du fichier
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/11_network_user_connections.patch gnome-control-center-3.4.3.1/debian/patches/11_network_user_connections.patch
--- gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/11_network_user_connections.patch	1970-01-01 01:00:00.000000000 +0100
+++ gnome-control-center-3.4.3.1/debian/patches/11_network_user_connections.patch	2013-01-03 17:23:27.000000000 +0100
@@ -0,0 +1,171 @@
+Index: gnome-control-center-3.4.3.1/panels/network/network-dialogs.c
+===================================================================
+--- gnome-control-center-3.4.3.1.orig/panels/network/network-dialogs.c	2012-12-10 15:38:41.000000000 +0100
++++ gnome-control-center-3.4.3.1/panels/network/network-dialogs.c	2013-01-03 16:19:34.732481478 +0100
+@@ -233,6 +233,14 @@ show_wireless_dialog (CcNetworkPanel   *
+         gtk_widget_show (dialog);
+ }
+ 
++gboolean
++cc_network_panel_default_to_private_connection (NMClient *client)
++{
++        NMClientPermissionResult perms;
++        perms = nm_client_get_permission_result (client, NM_CLIENT_PERMISSION_SETTINGS_MODIFY_SYSTEM);
++        return (perms != NM_CLIENT_PERMISSION_RESULT_YES);
++}
++
+ void
+ cc_network_panel_create_wifi_network (CcNetworkPanel   *panel,
+ 				      NMClient         *client,
+@@ -306,6 +314,10 @@ cc_network_panel_connect_to_8021x_networ
+         g_object_set (s_8021x, NM_SETTING_802_1X_PHASE2_AUTH, "mschapv2", NULL);
+         nm_connection_add_setting (connection, NM_SETTING (s_8021x));
+ 
++        if (cc_network_panel_default_to_private_connection (client)) {
++                nm_setting_connection_add_permission (s_con, "user", g_get_user_name(), NULL);
++        }
++
+         dialog = nma_wireless_dialog_new (client, settings, connection, device, ap, FALSE);
+         show_wireless_dialog (panel, client, settings, dialog);
+ }
+@@ -359,6 +371,7 @@ cdma_mobile_wizard_done (NMAMobileWizard
+ 		              NM_SETTING_CDMA_NUMBER, "#777",
+ 		              NM_SETTING_CDMA_USERNAME, method->username,
+ 		              NM_SETTING_CDMA_PASSWORD, method->password,
++		              NM_SETTING_CDMA_PASSWORD_FLAGS, NM_SETTING_SECRET_FLAG_AGENT_OWNED,
+ 		              NULL);
+ 		nm_connection_add_setting (connection, setting);
+ 
+@@ -388,6 +401,7 @@ cdma_mobile_wizard_done (NMAMobileWizard
+ 		              NULL);
+ 		g_free (uuid);
+ 		g_free (id);
++		nm_setting_connection_add_permission (setting, "user", g_get_user_name (), NULL);
+ 		nm_connection_add_setting (connection, setting);
+ 	}
+ 
+@@ -421,6 +435,7 @@ gsm_mobile_wizard_done (NMAMobileWizard
+ 		              NM_SETTING_GSM_NUMBER, "*99#",
+ 		              NM_SETTING_GSM_USERNAME, method->username,
+ 		              NM_SETTING_GSM_PASSWORD, method->password,
++		              NM_SETTING_GSM_PASSWORD_FLAGS, NM_SETTING_SECRET_FLAG_AGENT_OWNED,
+ 		              NM_SETTING_GSM_APN, method->gsm_apn,
+ 		              NULL);
+ 		nm_connection_add_setting (connection, setting);
+@@ -451,6 +466,7 @@ gsm_mobile_wizard_done (NMAMobileWizard
+ 		              NULL);
+ 		g_free (uuid);
+ 		g_free (id);
++		nm_setting_connection_add_permission ((NMSettingConnection *) setting, "user", g_get_user_name (), NULL);
+ 		nm_connection_add_setting (connection, setting);
+ 	}
+ 
+Index: gnome-control-center-3.4.3.1/panels/network/network-dialogs.h
+===================================================================
+--- gnome-control-center-3.4.3.1.orig/panels/network/network-dialogs.h	2012-12-10 15:38:41.000000000 +0100
++++ gnome-control-center-3.4.3.1/panels/network/network-dialogs.h	2013-01-03 15:24:42.300385989 +0100
+@@ -23,6 +23,8 @@
+ #include <nm-access-point.h>
+ #include "cc-network-panel.h"
+ 
++gboolean cc_network_panel_default_to_private_connection (NMClient *client);
++
+ void cc_network_panel_create_wifi_network (CcNetworkPanel   *panel,
+ 					   NMClient         *client,
+ 					   NMRemoteSettings *settings);
+Index: gnome-control-center-3.4.3.1/panels/network/cc-network-panel.c
+===================================================================
+--- gnome-control-center-3.4.3.1.orig/panels/network/cc-network-panel.c	2013-01-03 15:24:42.212385560 +0100
++++ gnome-control-center-3.4.3.1/panels/network/cc-network-panel.c	2013-01-03 16:17:34.419893694 +0100
+@@ -924,20 +924,16 @@ get_access_point_security (NMAccessPoint
+         wpa_flags = nm_access_point_get_wpa_flags (ap);
+         rsn_flags = nm_access_point_get_rsn_flags (ap);
+ 
+-        if (!(flags & NM_802_11_AP_FLAGS_PRIVACY) &&
+-            wpa_flags == NM_802_11_AP_SEC_NONE &&
+-            rsn_flags == NM_802_11_AP_SEC_NONE)
+-                type = NM_AP_SEC_NONE;
+-        else if ((flags & NM_802_11_AP_FLAGS_PRIVACY) &&
+-                 wpa_flags == NM_802_11_AP_SEC_NONE &&
+-                 rsn_flags == NM_802_11_AP_SEC_NONE)
++        if ((rsn_flags & NM_802_11_AP_SEC_KEY_MGMT_PSK) ||
++            (wpa_flags & NM_802_11_AP_SEC_KEY_MGMT_PSK))
++                type = NM_AP_SEC_WPA_PSK;
++        else if (rsn_flags != NM_802_11_AP_SEC_NONE ||
++                 wpa_flags != NM_802_11_AP_SEC_NONE)
++                type = NM_AP_SEC_WPA_OTHER;
++        else if (flags & NM_802_11_AP_FLAGS_PRIVACY)
+                 type = NM_AP_SEC_WEP;
+-        else if (!(flags & NM_802_11_AP_FLAGS_PRIVACY) &&
+-                 wpa_flags != NM_802_11_AP_SEC_NONE &&
+-                 rsn_flags != NM_802_11_AP_SEC_NONE)
+-                type = NM_AP_SEC_WPA;
+         else
+-                type = NM_AP_SEC_WPA2;
++                type = NM_AP_SEC_NONE;
+ 
+         return type;
+ }
+@@ -2823,6 +2819,7 @@ wireless_ap_changed_cb (GtkComboBox *com
+         gboolean ret;
+         gchar *object_path = NULL;
+         gchar *ssid_target = NULL;
++        NMAccessPointSecurity security = NM_AP_SEC_UNKNOWN;
+         GSList *list, *l;
+         GSList *filtered;
+         GtkTreeIter iter;
+@@ -2830,6 +2827,7 @@ wireless_ap_changed_cb (GtkComboBox *com
+         NetObject *object;
+         NMConnection *connection;
+         NMConnection *connection_activate = NULL;
++        NMConnection *connection_partial = NULL;
+         NMDevice *device;
+         NMSettingWireless *setting_wireless;
+ 
+@@ -2853,6 +2851,7 @@ wireless_ap_changed_cb (GtkComboBox *com
+         gtk_tree_model_get (model, &iter,
+                             PANEL_WIRELESS_COLUMN_ID, &object_path,
+                             PANEL_WIRELESS_COLUMN_TITLE, &ssid_target,
++                            PANEL_WIRELESS_COLUMN_SECURITY, &security,
+                             -1);
+         g_debug ("try to connect to WIFI network %s [%s]",
+                  ssid_target, object_path);
+@@ -2900,8 +2899,22 @@ wireless_ap_changed_cb (GtkComboBox *com
+         /* create one, as it's missing */
+         g_debug ("no existing connection found for %s, creating",
+                  ssid_target);
++        if (cc_network_panel_default_to_private_connection (panel->priv->client)) {
++                NMSettingConnection *s_con;
++
++                connection_partial = nm_connection_new ();
++                s_con = (NMSettingConnection *) nm_setting_connection_new ();
++                nm_setting_connection_add_permission (s_con, "user", g_get_user_name(), NULL);
++                nm_connection_add_setting (connection_partial, NM_SETTING (s_con));
++
++                if (security == NM_AP_SEC_WPA_PSK) {
++                        NMSettingWirelessSecurity *s_wsec = (NMSettingWirelessSecurity *) nm_setting_wireless_security_new ();
++                        g_object_set (s_wsec, NM_SETTING_WIRELESS_SECURITY_PSK_FLAGS, NM_SETTING_SECRET_FLAG_AGENT_OWNED, NULL);
++                        nm_connection_add_setting (connection_partial, NM_SETTING (s_wsec));
++                }
++        }
+         nm_client_add_and_activate_connection (panel->priv->client,
+-                                               NULL,
++                                               connection_partial,
+                                                device, object_path,
+                                                connection_add_activate_cb, panel);
+ out:
+Index: gnome-control-center-3.4.3.1/panels/network/panel-cell-renderer-security.h
+===================================================================
+--- gnome-control-center-3.4.3.1.orig/panels/network/panel-cell-renderer-security.h	2011-08-25 17:09:31.000000000 +0200
++++ gnome-control-center-3.4.3.1/panels/network/panel-cell-renderer-security.h	2013-01-03 15:48:09.483263614 +0100
+@@ -44,8 +44,8 @@ typedef enum {
+   NM_AP_SEC_UNKNOWN,
+   NM_AP_SEC_NONE,
+   NM_AP_SEC_WEP,
+-  NM_AP_SEC_WPA,
+-  NM_AP_SEC_WPA2
++  NM_AP_SEC_WPA_PSK,
++  NM_AP_SEC_WPA_OTHER
+ } NMAccessPointSecurity;
+ 
+ struct _PanelCellRendererSecurity
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/11_revert_printer_class.patch gnome-control-center-3.4.3.1/debian/patches/11_revert_printer_class.patch
--- gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/11_revert_printer_class.patch	2012-11-07 19:52:05.000000000 +0100
+++ gnome-control-center-3.4.3.1/debian/patches/11_revert_printer_class.patch	1970-01-01 01:00:00.000000000 +0100
@@ -1,17 +0,0 @@
-Revert upstream patch a39b9219652c14bb7a39a8639d03ab1462d311c5
-Index: gnome-control-center-3.4.2+git20121016.29d7c0/panels/printers/cc-printers-panel.c
-===================================================================
---- gnome-control-center-3.4.2+git20121016.29d7c0.orig/panels/printers/cc-printers-panel.c	2012-11-07 18:52:59.000000000 +0100
-+++ gnome-control-center-3.4.2+git20121016.29d7c0/panels/printers/cc-printers-panel.c	2012-11-07 19:25:59.292279172 +0100
-@@ -216,6 +216,11 @@ cc_printers_panel_class_init (CcPrinters
- }
- 
- static void
-+cc_printers_panel_class_finalize (CcPrintersPanelClass *klass)
-+{
-+}
-+
-+static void
- on_cups_notification (GDBusConnection *connection,
-                       const char      *sender_name,
-                       const char      *object_path,
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/series gnome-control-center-3.4.3.1/debian/patches/series
--- gnome-control-center-3.4.2+git20121016.29d7c0/debian/patches/series	2012-11-07 19:52:05.000000000 +0100
+++ gnome-control-center-3.4.3.1/debian/patches/series	2013-01-03 17:23:27.000000000 +0100
@@ -1,7 +1,9 @@
 01_menu_category.patch
 02_no_assert_on_null_streams.patch
+03_network_null_unref.patch
+04_network_crash_signals.patch
 06_handle_passwd_with_ldap.patch
 10_optional_wacom_support.patch
-11_revert_printer_class.patch
+11_network_user_connections.patch
 90_force_fallback.patch
 revert_git_datetime_port.patch
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/depcomp gnome-control-center-3.4.3.1/depcomp
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/INSTALL gnome-control-center-3.4.3.1/INSTALL
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/install-sh gnome-control-center-3.4.3.1/install-sh
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/ltmain.sh gnome-control-center-3.4.3.1/ltmain.sh
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/m4/libtool.m4 gnome-control-center-3.4.3.1/m4/libtool.m4
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/Makefile.in gnome-control-center-3.4.3.1/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/missing gnome-control-center-3.4.3.1/missing
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/NEWS gnome-control-center-3.4.3.1/NEWS
--- gnome-control-center-3.4.2+git20121016.29d7c0/NEWS	2012-11-07 18:52:59.000000000 +0100
+++ gnome-control-center-3.4.3.1/NEWS	2012-12-10 16:08:27.000000000 +0100
@@ -1,3 +1,55 @@
+============================
+Version 3.4.3.1 (2012-11-30)
+============================
+
+Printers:
+- Don't remove used finalize function
+
+==========================
+Version 3.4.3 (2012-11-30)
+==========================
+
+Shell:
+- Don't handle Ctrl+Alt+W the same way as Ctrl+W.
+
+Background:
+- Escape wallpaper filename before display
+
+Bluetooth:
+- Fix setting DUN/PAN networks not working
+
+Network:
+- Don't crash on hidden SSIDs
+
+Display:
+- Don't add an impossible resolution when using clone mode
+
+Region:
+- Avoid crash when searching for languages
+
+Wacom:
+- Make "Calibrate" button insensitive if there is no screen match
+- Hide "Map Buttons" button if no pad is found
+- Make sure the dialogues go away when unplugging the tablet
+- Update the UI when a new tool appears
+- Fix crasher using link to display panel
+- Cancel calibration if window loses focus
+
+Brightness & Lock:
+- Update the brightness when it changes through key presses
+- Avoid crash when getting out of the panel quickly
+
+Keyboard:
+- Fix not being able to assign Ctrl+Q to a shortcut
+
+User Accounts:
+- Fix memory leak of GtkBuilder
+- Make the "Create" button insensitive until some data is entered
+
+Online Accounts:
+- Don't show spurious "No online accounts configured"
+- Fix crash when switching from panel to shell and back
+
 ==========================
 Version 3.4.2 (2012-05-15)
 ==========================
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/background/gdesktop-enums-types.c gnome-control-center-3.4.3.1/panels/background/gdesktop-enums-types.c
--- gnome-control-center-3.4.2+git20121016.29d7c0/panels/background/gdesktop-enums-types.c	2012-11-07 18:58:36.000000000 +0100
+++ gnome-control-center-3.4.3.1/panels/background/gdesktop-enums-types.c	2012-12-10 16:18:33.000000000 +0100
@@ -5,7 +5,7 @@
 #include "gdesktop-enums-types.h"
 #include "cc-background-item.h"
 
-/* enumerations from "/usr/include/gsettings-desktop-schemas/gdesktop-enums.h" */
+/* enumerations from "/home/hadess/Projects/gnome-install/include/gsettings-desktop-schemas/gdesktop-enums.h" */
 GType
 g_desktop_proxy_mode_get_type (void)
 {
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/background/gdesktop-enums-types.h gnome-control-center-3.4.3.1/panels/background/gdesktop-enums-types.h
--- gnome-control-center-3.4.2+git20121016.29d7c0/panels/background/gdesktop-enums-types.h	2012-11-07 18:58:36.000000000 +0100
+++ gnome-control-center-3.4.3.1/panels/background/gdesktop-enums-types.h	2012-02-07 19:43:20.000000000 +0100
@@ -7,7 +7,7 @@
 #include <glib-object.h>
 
 G_BEGIN_DECLS
-/* enumerations from "/usr/include/gsettings-desktop-schemas/gdesktop-enums.h" */
+/* enumerations from "/home/hadess/Projects/gnome-install/include/gsettings-desktop-schemas/gdesktop-enums.h" */
 GType g_desktop_proxy_mode_get_type (void) G_GNUC_CONST;
 #define G_DESKTOP_TYPE_DESKTOP_PROXY_MODE (g_desktop_proxy_mode_get_type())
 GType g_desktop_toolbar_style_get_type (void) G_GNUC_CONST;
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/background/Makefile.in gnome-control-center-3.4.3.1/panels/background/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/bluetooth/Makefile.in gnome-control-center-3.4.3.1/panels/bluetooth/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/icons/16x16/Makefile.in gnome-control-center-3.4.3.1/panels/color/icons/16x16/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/icons/22x22/Makefile.in gnome-control-center-3.4.3.1/panels/color/icons/22x22/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/icons/24x24/Makefile.in gnome-control-center-3.4.3.1/panels/color/icons/24x24/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/icons/256x256/Makefile.in gnome-control-center-3.4.3.1/panels/color/icons/256x256/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/icons/32x32/Makefile.in gnome-control-center-3.4.3.1/panels/color/icons/32x32/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/icons/48x48/Makefile.in gnome-control-center-3.4.3.1/panels/color/icons/48x48/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/icons/64x64/Makefile.in gnome-control-center-3.4.3.1/panels/color/icons/64x64/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/icons/Makefile.in gnome-control-center-3.4.3.1/panels/color/icons/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/icons/scalable/Makefile.in gnome-control-center-3.4.3.1/panels/color/icons/scalable/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/color/Makefile.in gnome-control-center-3.4.3.1/panels/color/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/common/cc-language-chooser.c gnome-control-center-3.4.3.1/panels/common/cc-language-chooser.c
--- gnome-control-center-3.4.2+git20121016.29d7c0/panels/common/cc-language-chooser.c	2012-11-07 18:52:59.000000000 +0100
+++ gnome-control-center-3.4.3.1/panels/common/cc-language-chooser.c	2012-12-10 15:38:41.000000000 +0100
@@ -241,11 +241,13 @@
 
 	filter_string = g_object_get_data (G_OBJECT (model), "filter-string");
 
-	if (filter_string == NULL) {
+	if (filter_string == NULL)
 		return TRUE;
-	}
 
 	gtk_tree_model_get (model, iter, DISPLAY_LOCALE_COL, &locale, -1);
+	if (locale == NULL)
+		return FALSE;
+
 	l = g_utf8_casefold (locale, -1);
 
 	visible = strstr (l, filter_string) != NULL;
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/common/Makefile.in gnome-control-center-3.4.3.1/panels/common/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/datetime/Makefile.in gnome-control-center-3.4.3.1/panels/datetime/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/datetime/po-timezones/Makefile.in gnome-control-center-3.4.3.1/panels/datetime/po-timezones/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/datetime/timedated.c gnome-control-center-3.4.3.1/panels/datetime/timedated.c
--- gnome-control-center-3.4.2+git20121016.29d7c0/panels/datetime/timedated.c	2012-11-07 18:58:41.000000000 +0100
+++ gnome-control-center-3.4.3.1/panels/datetime/timedated.c	2012-12-10 15:40:14.000000000 +0100
@@ -1,5 +1,5 @@
 /*
- * Generated by gdbus-codegen 2.32.4. DO NOT EDIT.
+ * Generated by gdbus-codegen 2.35.3. DO NOT EDIT.
  *
  * The license of this code is the same as for the source it was derived from.
  */
@@ -167,8 +167,8 @@
 {
   {
     -1,
-    "usec_utc",
-    "x",
+    (gchar *) "usec_utc",
+    (gchar *) "x",
     NULL
   },
   FALSE
@@ -178,8 +178,8 @@
 {
   {
     -1,
-    "relative",
-    "b",
+    (gchar *) "relative",
+    (gchar *) "b",
     NULL
   },
   FALSE
@@ -189,8 +189,8 @@
 {
   {
     -1,
-    "user_interaction",
-    "b",
+    (gchar *) "user_interaction",
+    (gchar *) "b",
     NULL
   },
   FALSE
@@ -208,7 +208,7 @@
 {
   {
     -1,
-    "SetTime",
+    (gchar *) "SetTime",
     (GDBusArgInfo **) &_timedate1_method_info_set_time_IN_ARG_pointers,
     NULL,
     NULL
@@ -221,8 +221,8 @@
 {
   {
     -1,
-    "timezone",
-    "s",
+    (gchar *) "timezone",
+    (gchar *) "s",
     NULL
   },
   FALSE
@@ -232,8 +232,8 @@
 {
   {
     -1,
-    "user_interaction",
-    "b",
+    (gchar *) "user_interaction",
+    (gchar *) "b",
     NULL
   },
   FALSE
@@ -250,7 +250,7 @@
 {
   {
     -1,
-    "SetTimezone",
+    (gchar *) "SetTimezone",
     (GDBusArgInfo **) &_timedate1_method_info_set_timezone_IN_ARG_pointers,
     NULL,
     NULL
@@ -263,8 +263,8 @@
 {
   {
     -1,
-    "local_rtc",
-    "b",
+    (gchar *) "local_rtc",
+    (gchar *) "b",
     NULL
   },
   FALSE
@@ -274,8 +274,8 @@
 {
   {
     -1,
-    "fix_system",
-    "b",
+    (gchar *) "fix_system",
+    (gchar *) "b",
     NULL
   },
   FALSE
@@ -285,8 +285,8 @@
 {
   {
     -1,
-    "user_interaction",
-    "b",
+    (gchar *) "user_interaction",
+    (gchar *) "b",
     NULL
   },
   FALSE
@@ -304,7 +304,7 @@
 {
   {
     -1,
-    "SetLocalRTC",
+    (gchar *) "SetLocalRTC",
     (GDBusArgInfo **) &_timedate1_method_info_set_local_rtc_IN_ARG_pointers,
     NULL,
     NULL
@@ -317,8 +317,8 @@
 {
   {
     -1,
-    "use_ntp",
-    "b",
+    (gchar *) "use_ntp",
+    (gchar *) "b",
     NULL
   },
   FALSE
@@ -328,8 +328,8 @@
 {
   {
     -1,
-    "user_interaction",
-    "b",
+    (gchar *) "user_interaction",
+    (gchar *) "b",
     NULL
   },
   FALSE
@@ -346,7 +346,7 @@
 {
   {
     -1,
-    "SetNTP",
+    (gchar *) "SetNTP",
     (GDBusArgInfo **) &_timedate1_method_info_set_ntp_IN_ARG_pointers,
     NULL,
     NULL
@@ -368,8 +368,8 @@
 {
   {
     -1,
-    "Timezone",
-    "s",
+    (gchar *) "Timezone",
+    (gchar *) "s",
     G_DBUS_PROPERTY_INFO_FLAGS_READABLE,
     NULL
   },
@@ -381,8 +381,8 @@
 {
   {
     -1,
-    "LocalRTC",
-    "b",
+    (gchar *) "LocalRTC",
+    (gchar *) "b",
     G_DBUS_PROPERTY_INFO_FLAGS_READABLE,
     NULL
   },
@@ -394,8 +394,8 @@
 {
   {
     -1,
-    "NTP",
-    "b",
+    (gchar *) "NTP",
+    (gchar *) "b",
     G_DBUS_PROPERTY_INFO_FLAGS_READABLE,
     NULL
   },
@@ -415,7 +415,7 @@
 {
   {
     -1,
-    "org.freedesktop.timedate1",
+    (gchar *) "org.freedesktop.timedate1",
     (GDBusMethodInfo **) &_timedate1_method_info_pointers,
     NULL,
     (GDBusPropertyInfo **) &_timedate1_property_info_pointers,
@@ -435,7 +435,7 @@
 GDBusInterfaceInfo *
 timedate1_interface_info (void)
 {
-  return (GDBusInterfaceInfo *) &_timedate1_interface_info;
+  return (GDBusInterfaceInfo *) &_timedate1_interface_info.parent_struct;
 }
 
 /**
@@ -1317,7 +1317,7 @@
     g_variant_new ("(ssv)", "org.freedesktop.timedate1", info->parent_struct.name, variant),
     G_DBUS_CALL_FLAGS_NONE,
     -1,
-    NULL, (GAsyncReadyCallback) timedate1_proxy_set_property_cb, (gpointer) info);
+    NULL, (GAsyncReadyCallback) timedate1_proxy_set_property_cb, (GDBusPropertyInfo *) &info->parent_struct);
   g_variant_unref (variant);
 }
 
@@ -1334,7 +1334,7 @@
   guint num_params;
   guint n;
   guint signal_id;
-  info = (_ExtendedGDBusSignalInfo *) g_dbus_interface_info_lookup_signal ((GDBusInterfaceInfo *) &_timedate1_interface_info, signal_name);
+  info = (_ExtendedGDBusSignalInfo *) g_dbus_interface_info_lookup_signal ((GDBusInterfaceInfo *) &_timedate1_interface_info.parent_struct, signal_name);
   if (info == NULL)
     return;
   num_params = g_variant_n_children (parameters);
@@ -1376,7 +1376,7 @@
   g_variant_get (changed_properties, "a{sv}", &iter);
   while (g_variant_iter_next (iter, "{&sv}", &key, NULL))
     {
-      info = (_ExtendedGDBusPropertyInfo *) g_dbus_interface_info_lookup_property ((GDBusInterfaceInfo *) &_timedate1_interface_info, key);
+      info = (_ExtendedGDBusPropertyInfo *) g_dbus_interface_info_lookup_property ((GDBusInterfaceInfo *) &_timedate1_interface_info.parent_struct, key);
       g_datalist_remove_data (&proxy->priv->qdata, key);
       if (info != NULL)
         g_object_notify (G_OBJECT (proxy), info->hyphen_name);
@@ -1384,7 +1384,7 @@
   g_variant_iter_free (iter);
   for (n = 0; invalidated_properties[n] != NULL; n++)
     {
-      info = (_ExtendedGDBusPropertyInfo *) g_dbus_interface_info_lookup_property ((GDBusInterfaceInfo *) &_timedate1_interface_info, invalidated_properties[n]);
+      info = (_ExtendedGDBusPropertyInfo *) g_dbus_interface_info_lookup_property ((GDBusInterfaceInfo *) &_timedate1_interface_info.parent_struct, invalidated_properties[n]);
       g_datalist_remove_data (&proxy->priv->qdata, invalidated_properties[n]);
       if (info != NULL)
         g_object_notify (G_OBJECT (proxy), info->hyphen_name);
@@ -1756,7 +1756,7 @@
   _ExtendedGDBusPropertyInfo *info;
   GVariant *ret;
   ret = NULL;
-  info = (_ExtendedGDBusPropertyInfo *) g_dbus_interface_info_lookup_property ((GDBusInterfaceInfo *) &_timedate1_interface_info, property_name);
+  info = (_ExtendedGDBusPropertyInfo *) g_dbus_interface_info_lookup_property ((GDBusInterfaceInfo *) &_timedate1_interface_info.parent_struct, property_name);
   g_assert (info != NULL);
   pspec = g_object_class_find_property (G_OBJECT_GET_CLASS (skeleton), info->hyphen_name);
   if (pspec == NULL)
@@ -1790,7 +1790,7 @@
   _ExtendedGDBusPropertyInfo *info;
   gboolean ret;
   ret = FALSE;
-  info = (_ExtendedGDBusPropertyInfo *) g_dbus_interface_info_lookup_property ((GDBusInterfaceInfo *) &_timedate1_interface_info, property_name);
+  info = (_ExtendedGDBusPropertyInfo *) g_dbus_interface_info_lookup_property ((GDBusInterfaceInfo *) &_timedate1_interface_info.parent_struct, property_name);
   g_assert (info != NULL);
   pspec = g_object_class_find_property (G_OBJECT_GET_CLASS (skeleton), info->hyphen_name);
   if (pspec == NULL)
@@ -1941,14 +1941,14 @@
     }
   if (num_changes > 0)
     {
-      GList *connections, *l;
+      GList *connections, *ll;
       GVariant *signal_variant;
       signal_variant = g_variant_ref_sink (g_variant_new ("(sa{sv}as)", "org.freedesktop.timedate1",
                                            &builder, &invalidated_builder));
       connections = g_dbus_interface_skeleton_get_connections (G_DBUS_INTERFACE_SKELETON (skeleton));
-      for (l = connections; l != NULL; l = l->next)
+      for (ll = connections; ll != NULL; ll = ll->next)
         {
-          GDBusConnection *connection = l->data;
+          GDBusConnection *connection = ll->data;
 
           g_dbus_connection_emit_signal (connection,
                                          NULL, g_dbus_interface_skeleton_get_object_path (G_DBUS_INTERFACE_SKELETON (skeleton)),
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/datetime/timedated.h gnome-control-center-3.4.3.1/panels/datetime/timedated.h
--- gnome-control-center-3.4.2+git20121016.29d7c0/panels/datetime/timedated.h	2012-11-07 18:58:41.000000000 +0100
+++ gnome-control-center-3.4.3.1/panels/datetime/timedated.h	2012-12-10 15:40:14.000000000 +0100
@@ -1,5 +1,5 @@
 /*
- * Generated by gdbus-codegen 2.32.4. DO NOT EDIT.
+ * Generated by gdbus-codegen 2.35.3. DO NOT EDIT.
  *
  * The license of this code is the same as for the source it was derived from.
  */
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/display/foo-marshal.c gnome-control-center-3.4.3.1/panels/display/foo-marshal.c
--- gnome-control-center-3.4.2+git20121016.29d7c0/panels/display/foo-marshal.c	2012-11-07 18:58:37.000000000 +0100
+++ gnome-control-center-3.4.3.1/panels/display/foo-marshal.c	2011-08-25 19:54:08.000000000 +0200
@@ -8,7 +8,7 @@
 
 #ifdef G_ENABLE_DEBUG
 #define g_marshal_value_peek_boolean(v)  g_value_get_boolean (v)
-#define g_marshal_value_peek_char(v)     g_value_get_schar (v)
+#define g_marshal_value_peek_char(v)     g_value_get_char (v)
 #define g_marshal_value_peek_uchar(v)    g_value_get_uchar (v)
 #define g_marshal_value_peek_int(v)      g_value_get_int (v)
 #define g_marshal_value_peek_uint(v)     g_value_get_uint (v)
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/display/Makefile.in gnome-control-center-3.4.3.1/panels/display/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/info/Makefile.in gnome-control-center-3.4.3.1/panels/info/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/keyboard/Makefile.in gnome-control-center-3.4.3.1/panels/keyboard/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/Makefile.in gnome-control-center-3.4.3.1/panels/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/mouse/Makefile.in gnome-control-center-3.4.3.1/panels/mouse/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/network/cc-network-panel.c gnome-control-center-3.4.3.1/panels/network/cc-network-panel.c
--- gnome-control-center-3.4.2+git20121016.29d7c0/panels/network/cc-network-panel.c	2012-11-07 18:52:59.000000000 +0100
+++ gnome-control-center-3.4.3.1/panels/network/cc-network-panel.c	2012-12-10 15:38:41.000000000 +0100
@@ -1114,13 +1114,19 @@
         if (aps != NULL)
                 for (i = 0; i < aps->len; i++) {
                         ap = NM_ACCESS_POINT (g_ptr_array_index (aps, i));
+
+                        /* Hidden SSIDs don't get shown in the list */
                         ssid = nm_access_point_get_ssid (ap);
+                        if (!ssid)
+                                continue;
+
                         add_ap = TRUE;
 
                         /* get already added list */
                         for (j=0; j<aps_unique->len; j++) {
                                 ap_tmp = NM_ACCESS_POINT (g_ptr_array_index (aps_unique, j));
                                 ssid_tmp = nm_access_point_get_ssid (ap_tmp);
+                                g_assert (ssid_tmp);
         
                                 /* is this the same type and data? */
                                 if (nm_utils_same_ssid (ssid, ssid_tmp, TRUE)) {
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/network/Makefile.in gnome-control-center-3.4.3.1/panels/network/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/online-accounts/icons/16x16/Makefile.in gnome-control-center-3.4.3.1/panels/online-accounts/icons/16x16/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/online-accounts/icons/22x22/Makefile.in gnome-control-center-3.4.3.1/panels/online-accounts/icons/22x22/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/online-accounts/icons/24x24/Makefile.in gnome-control-center-3.4.3.1/panels/online-accounts/icons/24x24/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/online-accounts/icons/256x256/Makefile.in gnome-control-center-3.4.3.1/panels/online-accounts/icons/256x256/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/online-accounts/icons/32x32/Makefile.in gnome-control-center-3.4.3.1/panels/online-accounts/icons/32x32/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/online-accounts/icons/48x48/Makefile.in gnome-control-center-3.4.3.1/panels/online-accounts/icons/48x48/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/online-accounts/icons/Makefile.in gnome-control-center-3.4.3.1/panels/online-accounts/icons/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/online-accounts/Makefile.in gnome-control-center-3.4.3.1/panels/online-accounts/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/power/icons/16x16/Makefile.in gnome-control-center-3.4.3.1/panels/power/icons/16x16/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/power/icons/22x22/Makefile.in gnome-control-center-3.4.3.1/panels/power/icons/22x22/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/power/icons/24x24/Makefile.in gnome-control-center-3.4.3.1/panels/power/icons/24x24/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/power/icons/256x256/Makefile.in gnome-control-center-3.4.3.1/panels/power/icons/256x256/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/power/icons/32x32/Makefile.in gnome-control-center-3.4.3.1/panels/power/icons/32x32/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/power/icons/48x48/Makefile.in gnome-control-center-3.4.3.1/panels/power/icons/48x48/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/power/icons/Makefile.in gnome-control-center-3.4.3.1/panels/power/icons/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/power/Makefile.in gnome-control-center-3.4.3.1/panels/power/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/printers/cc-printers-panel.c gnome-control-center-3.4.3.1/panels/printers/cc-printers-panel.c
--- gnome-control-center-3.4.2+git20121016.29d7c0/panels/printers/cc-printers-panel.c	2012-11-07 18:52:59.000000000 +0100
+++ gnome-control-center-3.4.3.1/panels/printers/cc-printers-panel.c	2012-12-10 15:39:32.000000000 +0100
@@ -216,6 +216,11 @@
 }
 
 static void
+cc_printers_panel_class_finalize (CcPrintersPanelClass *klass)
+{
+}
+
+static void
 on_cups_notification (GDBusConnection *connection,
                       const char      *sender_name,
                       const char      *object_path,
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/printers/Makefile.in gnome-control-center-3.4.3.1/panels/printers/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/region/Makefile.in gnome-control-center-3.4.3.1/panels/region/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/screen/Makefile.in gnome-control-center-3.4.3.1/panels/screen/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/16x16/apps/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/16x16/apps/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/16x16/devices/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/16x16/devices/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/16x16/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/16x16/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/16x16/status/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/16x16/status/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/22x22/apps/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/22x22/apps/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/22x22/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/22x22/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/22x22/status/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/22x22/status/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/24x24/apps/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/24x24/apps/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/24x24/devices/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/24x24/devices/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/24x24/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/24x24/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/24x24/status/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/24x24/status/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/32x32/apps/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/32x32/apps/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/32x32/devices/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/32x32/devices/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/32x32/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/32x32/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/32x32/status/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/32x32/status/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/48x48/apps/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/48x48/apps/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/48x48/devices/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/48x48/devices/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/48x48/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/48x48/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/scalable/apps/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/scalable/apps/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/scalable/devices/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/scalable/devices/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/icons/scalable/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/icons/scalable/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/sounds/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/sounds/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/symbolic-icons/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/symbolic-icons/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/symbolic-icons/scalable/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/symbolic-icons/scalable/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/data/symbolic-icons/scalable/status/Makefile.in gnome-control-center-3.4.3.1/panels/sound/data/symbolic-icons/scalable/status/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/sound/Makefile.in gnome-control-center-3.4.3.1/panels/sound/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/universal-access/Makefile.in gnome-control-center-3.4.3.1/panels/universal-access/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/user-accounts/data/faces/Makefile.in gnome-control-center-3.4.3.1/panels/user-accounts/data/faces/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/user-accounts/data/icons/Makefile.in gnome-control-center-3.4.3.1/panels/user-accounts/data/icons/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/user-accounts/data/Makefile.in gnome-control-center-3.4.3.1/panels/user-accounts/data/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/user-accounts/Makefile.in gnome-control-center-3.4.3.1/panels/user-accounts/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/wacom/calibrator/Makefile.in gnome-control-center-3.4.3.1/panels/wacom/calibrator/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/panels/wacom/Makefile.in gnome-control-center-3.4.3.1/panels/wacom/Makefile.in
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/po/nl.po gnome-control-center-3.4.3.1/po/nl.po
diff -Nru gnome-control-center-3.4.2+git20121016.29d7c0/shell/Makefile.in gnome-control-center-3.4.3.1/shell/Makefile.in

--- End Message ---
--- Begin Message ---
On 2013-01-27 20:31, Michael Biebl wrote:
> retitle 697894 unblock: gnome-control-center/1:3.4.3.1-2
> thanks
> 
> On 27.01.2013 19:30, intrigeri wrote:
>> Hi,
>>
>> Josselin Mouette wrote (10 Jan 2013 23:56:49 GMT) :
>>> please unblock gnome-control-center. Apart from a handful of upstream 
>>> fixes, the changes consist in using NetworkManager user connections when 
>>> system connections are not available, and to store passwords in the 
>>> keyring if necessary.
>>
>> The diff is way out of my comfort zone to review, but FWIW I've
>> upgraded to the sid version (and asked a few other people to do so
>> too) in order to bring some first-hand real world testing reports and
>> ease the decision. I'll report back in a week.
> 
> There was a followup upload by me, to treat WEP keys like WPA secrets.
> I've updated the bug title accordingly.
> 
> It's important to get those fixes into wheezy, so we have properly
> working NetworkManager support which works consistently among the
> different clients (gnome-shell, gnome-control-center, nm-applet)
> 
> Cheers,
> Michael
> 
> unblock gnome-control-center/1:3.4.3.1-2
> 

Unblocked, thanks.

~Niels

--- End Message ---

Reply to: