[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#699326: marked as done (unblock: bacula/5.2.6+dfsg-8)

Your message dated Wed, 30 Jan 2013 22:30:01 +0100
with message-id <20130130213001.GP8837@radis.cristau.org>
and subject line Re: Bug#699326: unblock: bacula/5.2.6+dfsg-8
has caused the Debian Bug report #699326,
regarding unblock: bacula/5.2.6+dfsg-8
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
699326: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699326
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Hi!

Please unblock bacula-* packages, it fixes security bug #699244
(service run with incorrect permissions)

debdiff --diffstat output attached

Thank you!

-- 
with best regards,
Alexander Golovko
email: alexandro@ankalagon.ru
xmpp: alexandro@ankalagon.ru

diffstat for bacula-5.2.6+dfsg bacula-5.2.6+dfsg

 additions/common-functions.dpkg |    7 ++-----
 changelog                       |    7 +++++++
 2 files changed, 9 insertions(+), 5 deletions(-)

diff -Nru bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
--- bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg	2013-01-03 00:53:46.000000000 +0400
+++ bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg	2013-01-29 18:46:09.000000000 +0400
@@ -162,16 +162,14 @@
         bacula-fd)
             SERVICE="bacula-fd"
             ARGS=""
-            DEFAULT_ARGS=""
             ;;
         bacula-sd)
             SERVICE="bacula-sd"
             ARGS="-u bacula -g tape"
-            DEFAULT_ARGS="-u bacula -g tape"
             ;;
         bacula-director-pgsql|bacula-director-mysql|bacula-director-sqlite3)
             SERVICE="bacula-dir"
-            DAEMONUSER="bacula:bacula"
+            ARGS="-u bacula -g bacula"
             if ucfq -w "/etc/default/bacula-dir" \
                 |egrep -q '^[^:]*:bacula-director-(pgsql|mysql|sqlite3):'; then
                 UCFR_ARGS="-f"
@@ -197,7 +195,6 @@
         else
             if [ -f "$DEFAULTS" ]; then
                 ENABLED=$(. $DEFAULTS; echo $ENABLED)
-                ARGS=$(. $DEFAULTS; echo $ARGS)
                 CONFIG=$(. $DEFAULTS; echo $CONFIG)
             fi
         fi
@@ -219,7 +216,7 @@
 ENABLED="$ENABLED"
 
 # Additional start arguments can be provided here
-# ARGS="$DEFAULT_ARGS"
+# ARGS="$ARGS"
 ARGS="$ARGS"
 
 # Default config file can be changed here
diff -Nru bacula-5.2.6+dfsg/debian/changelog bacula-5.2.6+dfsg/debian/changelog
--- bacula-5.2.6+dfsg/debian/changelog	2013-01-08 16:01:40.000000000 +0400
+++ bacula-5.2.6+dfsg/debian/changelog	2013-01-29 18:47:28.000000000 +0400
@@ -1,3 +1,10 @@
+bacula (5.2.6+dfsg-8) unstable; urgency=high
+
+  * debian/additions/common-functions.dpkg:
+    + Fix missed user for run bacula-director (Closes: #699244).
+
+ -- Alexander Golovko <alexandro@ankalagon.ru>  Tue, 29 Jan 2013 18:47:27 +0400
+
 bacula (5.2.6+dfsg-7) unstable; urgency=low
 
   * debian/bacula-sd.install, bacula-director-{sqlite3,mysql,pgsql}.install,

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
On Thu, Jan 31, 2013 at 00:36:55 +0400, Alexander Golovko wrote:

> В Wed, 30 Jan 2013 20:40:07 +0100
> Julien Cristau <jcristau@debian.org> пишет:
> 
> > On Wed, Jan 30, 2013 at 14:33:49 +0400, Alexander Golovko wrote:
> > 
> > > diffstat for bacula-5.2.6+dfsg bacula-5.2.6+dfsg
> > > 
> > >  additions/common-functions.dpkg |    7 ++-----
> > >  changelog                       |    7 +++++++
> > >  2 files changed, 9 insertions(+), 5 deletions(-)
> > > 
> > > diff -Nru bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
> > > bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg ---
> > > bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
> > > 2013-01-03 00:53:46.000000000 +0400 +++
> > > bacula-5.2.6+dfsg/debian/additions/common-functions.dpkg
> > > 2013-01-29 18:46:09.000000000 +0400
> > 
> > How/where is this file used?
> 
> Changed code used for generate /etc/default/bacula-{fd,sd,director}
> files. Defaults file for bacula-director in 5.2.6+dfsg-7 incorrectly
> set empty arguments string (there is error in reverting some changes),
> which lead to run service with root privileges.
> 
Ouch.. seems over-complicated; unblocked though.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: