[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#698434: unblock: mha4mysql-manager/0.53-2



On 2013-01-18 14:58, KURASHIKI Satoru wrote:
> Package: release.debian.org
> Severity: medium
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> Dear release team,
> 
> Please unblock package mha4mysql-manager 0.53-2, which fix RC bug:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=697197
> 
>> > masterha_master_switch aborts with the following error upon attempting a master
>> > failover/switch, rendering it virtually unusable:
> Here is the debdiff of this change, it's so small backport from upstream.
> 
> [...]
> +@@ -87,6 +87,7 @@
> + our $log_fmt = sub {
> +   my %args = @_;
> +   my $msg  = $args{message};
> ++  $msg = "" unless($msg);

Technically, this can map a "0" to a "" - not sure how likely that is in
a "log_this" function, but you(r upstream) might have wanted
"unless(defined($msg));" instead.

> +   chomp $msg;
> +   if ( $args{level} eq "error" ) {
> +     my ( $ln, $script ) = ( caller(4) )[ 2, 1 ];
> diff -Nru mha4mysql-manager-0.53/debian/patches/series mha4mysql-manager-0.53/debian/patches/series
> --- mha4mysql-manager-0.53/debian/patches/series	1970-01-01 09:00:00.000000000 +0900
> +++ mha4mysql-manager-0.53/debian/patches/series	2013-01-18 22:34:16.000000000 +0900
> @@ -0,0 +1 @@
> +chomp-fix

~Niels


Reply to: