Bug#695174: t-p-u pre-approval owncloud/4.0.4debian2-3.1
Hi,
On Wed, Dec 12, 2012 at 09:20:38PM +0100, Julien Cristau wrote:
> On Wed, Dec 12, 2012 at 19:44:38 +0000, Adam D. Barratt wrote:
> > On Mon, 2012-12-10 at 20:14 +0100, Julien Cristau wrote:
> > > On Wed, Dec 5, 2012 at 22:18:54 +0100, Michael Banck wrote:
> > > >
> > > > On Wed, Dec 05, 2012 at 10:55:56AM +0100, Julien Cristau wrote:
> > > > > As far as I can tell this escapeHTML function is not defined in the
> > > > > current version? Upstream git has it in core/js/js.js.
> > > >
> > > > Attached is a new candidate debdiff.
> > > >
> > > Assuming this is tested, go ahead.
> >
> > +Index: owncloud-4.0.4debian2/core/js/js.js
> > [...]
> > ++function escapeHTML(s) {
> > [...]
> > +Index: owncloud-4.0.4debian2/3rdparty/fullcalendar/js/fullcalendar.js
> > [...]
> > +- "<span class='fc-event-title'>" + event.title + "</span>" +
> > ++ "<span class='fc-event-title'>" + htmlEscape(event.title) + "</span>" +
> >
> > Should the htmlEscape() call in that last hunk be escapeHTML()?
> >
> iirc fullcalendar has its own preexisting escape function, with a
> different name.
Yes:
mba@hartree:~/debian/bsp/owncloud-4.0.4debian2$ grep -r htmlEscape * | head -1
3rdparty/fullcalendar/js/fullcalendar.js:function htmlEscape(s) {
mba@hartree:~/debian/bsp/owncloud-4.0.4debian2$
Cheers,
Michael
Reply to: