Bug#683142: unblock: bdii/5.2.12-1
clone 683142 -1
reassign -1 bdii
retitle -1 bdii: configuration files does not preserve local changes
severity -1 serious
user release.debian.org@packages.debian.org
usertags -1 =
block 683142 by -1
thanks
On 2012-09-05 13:24, Mattias Ellert wrote:
> fre 2012-08-31 klockan 14:01 +0200 skrev Niels Thykier:
>>
>> I believe the RC bug fix on 5.2.5-2 should be reasonable sane and lets
>> take that as a starting point.
>>
>> ~Niels
>
> bdii_5.2.5-2+wheezy1 was uploaded to testing-proposed-updates.
>
> Mattias
>
Hi,
Ansgar just pointed out that the fix for #663444 is RC-buggy on its own,
which I missed in my previous review. Since bdii/5.2.5-2+wheezy1 is
currently in NEW I cannot actually see its content, but I assuming you
applied the same fix as you did in 5.2.12-2.
bdii/5.2.12-2 ships its configuration files as /usr/share/bdii/ and have
symlinks in /etc/bdii/ pointing to the files in /usr/share/bdii.
According to Policy §10.7.2, this should be reversed (i.e. symlinks in
/usr/share/bdii and real files in /etc). The current setup also
violates §10.7.3[1].
Furthermore, the postinst script modifies one of the files in
/usr/share/bdii, which if not RC will at the very least triggers debsums
warnings.
I believe a correct solution would be to ship the files in
/usr/share/bdii and remove the symlink(s) in /etc/bdii. In the
postinst, generate the config files in /etc/bdii using sed (ucf can help
you to ensure local changes are preserved).
Also, I could be wrong, but it looks like a new password is generated
each time the script is run. If so, the script you probably want to add
a guard or two to ensure the postinst is idempotent as required by §6.2.
Please fix this in unstable first.
Sorry,
~Niels
[1] In particular:
"""
* local changes must be preserved during a package upgrade, and
* configuration files must be preserved when the package is removed,
and only deleted when the package is purged.
"""
http://www.debian.org/doc/debian-policy/ch-files.html#s-config-files
Reply to: