[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#686568: marked as done (unblock: debpear/0.3)

Your message dated Mon, 03 Sep 2012 21:09:41 +0100
with message-id <1346702981.16217.4.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#686568: unblock: debpear/0.3
has caused the Debian Bug report #686568,
regarding unblock: debpear/0.3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
686568: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=686568
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

When given the parameter -i, with something like this:

debpear -i <PKG-Name>

debpear is supposed to download the PEAR package named PKG-Name, then build a
Debian package called php-pkg-name out of it, then if the build is successful,
install it.

As I wanted to handle the case where a *user* would use debpear, I wrote this:

if [ "${DO_INSTALL}" = "yes" ] ; then
	if ! [ `whoami` = "root" ] ; then
		sudo dpkg -i ${DEB_PKG_RESULT}
	fi
fi

but I forgot to handle the case where the user would be root. So, version 0.3
fixes this by adding:

+	else
+		dpkg -i ${DEB_PKG_RESULT}

(eg: without the sudo)

Please unblock debpear/0.3 to fix this problem.

Cheers,

Thomas Goirand (zigo)

diff --git a/debian/changelog b/debian/changelog
index 32f3c4e..14a7ba5 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+debpear (0.3) unstable; urgency=low
+
+  * Fixed the -i option when run as root.
+
+ -- Thomas Goirand <zigo@debian.org>  Mon, 03 Sep 2012 08:25:44 +0000
+
 debpear (0.2) unstable; urgency=low
 
   * Removed the -p parameter, so that we can just call like this:
diff --git a/debpear b/debpear
index c7c61aa..f07f23e 100755
--- a/debpear
+++ b/debpear
@@ -251,5 +251,7 @@ cd ..
 if [ "${DO_INSTALL}" = "yes" ] ; then
 	if ! [ `whoami` = "root" ] ; then
 		sudo dpkg -i ${DEB_PKG_RESULT}
+	else
+		dpkg -i ${DEB_PKG_RESULT}
 	fi
 fi

--- End Message ---
--- Begin Message --- 
On Mon, 2012-09-03 at 19:05 +0800, Thomas Goirand wrote:
> When given the parameter -i, with something like this:
> 
> debpear -i <PKG-Name>
> 
> debpear is supposed to download the PEAR package named PKG-Name, then build a
> Debian package called php-pkg-name out of it, then if the build is successful,
> install it.
[...]
> but I forgot to handle the case where the user would be root. So, version 0.3
> fixes this by adding:

Unblocked.

Regards,

Adam

--- End Message ---
Reply to: