[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697055: unblock pdfchain/1:0.3.3-2



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock


Please unblock pdfchain/1:0.3.3-2. It includes a fix 
for an important bug. 

Changelog:

  * Use correct pdftk call for concatenating pdf files in all cases.
    (Closes: #696079)
  * debian/control: Change my e-mail address.

The full debdiff and the applied very small patch (just uncomments one
line) are attached.
Upstream did the same fix in new upstream versions [1].

unblock pdfchain/1:0.3.3-2

Thanks!

Regards,
 Johann Felix Soden

[1] https://bugs.launchpad.net/ubuntu/+source/pdfchain/+bug/1048045/comments/15
diff -Nru pdfchain-0.3.3/debian/changelog pdfchain-0.3.3/debian/changelog
--- pdfchain-0.3.3/debian/changelog	2011-12-27 14:33:07.000000000 +0100
+++ pdfchain-0.3.3/debian/changelog	2012-12-16 16:37:21.000000000 +0100
@@ -1,3 +1,11 @@
+pdfchain (1:0.3.3-2) unstable; urgency=low
+
+  * Use correct pdftk call for concatenating pdf files in all cases.
+    (Closes: #696079)
+  * debian/control: Change my e-mail address.
+
+ -- Johann Felix Soden <johfel@debian.org>  Sun, 16 Dec 2012 16:37:21 +0100
+
 pdfchain (1:0.3.3-1) unstable; urgency=low
 
   * New upstream version with new version numbering scheme
diff -Nru pdfchain-0.3.3/debian/control pdfchain-0.3.3/debian/control
--- pdfchain-0.3.3/debian/control	2011-12-27 12:35:59.000000000 +0100
+++ pdfchain-0.3.3/debian/control	2012-12-16 16:34:29.000000000 +0100
@@ -1,7 +1,7 @@
 Source: pdfchain
 Section: text
 Priority: optional
-Maintainer: Johann Felix Soden <johfel@gmx.de>
+Maintainer: Johann Felix Soden <johfel@debian.org>
 Build-Depends: debhelper (>= 8~), autotools-dev, libgtkmm-3.0-dev,
  libglibmm-2.4-dev, intltool
 Standards-Version: 3.9.2
diff -Nru pdfchain-0.3.3/debian/patches/fix_concatenate_bug pdfchain-0.3.3/debian/patches/fix_concatenate_bug
--- pdfchain-0.3.3/debian/patches/fix_concatenate_bug	1970-01-01 01:00:00.000000000 +0100
+++ pdfchain-0.3.3/debian/patches/fix_concatenate_bug	2012-12-16 16:32:15.000000000 +0100
@@ -0,0 +1,21 @@
+Description: Circumvent problems with wrong pdftk commandline
+  When the user wants to concatenate pdf files, the pdftk commandline is not
+  build correctly in all cases, especially if items were re-ordered. As not
+  specified handles are used, "Input/Output  Error" and error code 256 is
+  displayed. This patch circumvent any hidden bugs by explicitly re-indexing all
+  items.
+Bug-Debian: http://bugs.debian.org/696079
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/pdfchain/+bug/1048045
+Author: Johann Felix Soden <johfel@debian.org>
+
+--- a/src/store_cat.cc
++++ b/src/store_cat.cc
+@@ -533,7 +533,7 @@
+ 	Gtk::TreeModel::iterator	iter;
+ 
+ 	// Indicate each file at list with a handle (same files have same handle)
+-	//indicateHandles();	// not nessesary - handles are re-indexed with every change
++	indicateHandles();	// not nessesary - handles are re-indexed with every change
+ 
+ 	// Assign a file on each handle
+ 	for ( iter = children().begin() , handle = Pdfchain::Cat::HANDLE_FIRST ;
diff -Nru pdfchain-0.3.3/debian/patches/series pdfchain-0.3.3/debian/patches/series
--- pdfchain-0.3.3/debian/patches/series	2011-12-27 11:49:38.000000000 +0100
+++ pdfchain-0.3.3/debian/patches/series	2012-12-16 16:30:15.000000000 +0100
@@ -1,2 +1,3 @@
+fix_concatenate_bug
 fix_build_system
 fix_desktop_file
Description: Circumvent problems with wrong pdftk commandline
  When the user wants to concatenate pdf files, the pdftk commandline is not
  build correctly in all cases, especially if items were re-ordered. As not
  specified handles are used, "Input/Output  Error" and error code 256 is
  displayed. This patch circumvent any hidden bugs by explicitly re-indexing all
  items.
Bug-Debian: http://bugs.debian.org/696079
Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/pdfchain/+bug/1048045
Author: Johann Felix Soden <johfel@debian.org>

--- a/src/store_cat.cc
+++ b/src/store_cat.cc
@@ -533,7 +533,7 @@
 	Gtk::TreeModel::iterator	iter;
 
 	// Indicate each file at list with a handle (same files have same handle)
-	//indicateHandles();	// not nessesary - handles are re-indexed with every change
+	indicateHandles();	// not nessesary - handles are re-indexed with every change
 
 	// Assign a file on each handle
 	for ( iter = children().begin() , handle = Pdfchain::Cat::HANDLE_FIRST ;

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: