[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697010: marked as done (unblock: nova/2012.1.1-11 (rootwrap path fix))

Your message dated Sun, 30 Dec 2012 20:20:35 +0000
with message-id <1356898835.4281.50.camel@jacala.jungle.funky-badger.org>
and subject line Re: Bug#697010: unblock: nova/2012.1.1-11 (rootwrap path fix)
has caused the Debian Bug report #697010,
regarding unblock: nova/2012.1.1-11 (rootwrap path fix)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
697010: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=697010
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Dear Release Team,

My latest upload of Nova in SID fixes some path problems in the
rootwrap thing of Nova. Without it, Nova will fail to use the
iscsiadm command, which is needed to mount VM volumes.

The patch (which I attached to this message) is rather trivial:
/sbin/ip -> /bin/ip and /sbin/iscsiadm -> /usr/bin/iscsiadm
in the /etc/nova/rootwrap configuration folder.

Please allow this fix to reach Wheezy, and unblock nova/2012.1.1-11.

Cheers,

Thomas Goirand (zigo)

diff -Nru nova-2012.1.1/debian/changelog nova-2012.1.1/debian/changelog
--- nova-2012.1.1/debian/changelog	2012-09-16 07:01:27.000000000 +0000
+++ nova-2012.1.1/debian/changelog	2012-12-19 15:59:14.000000000 +0000
@@ -1,3 +1,9 @@
+nova (2012.1.1-11) unstable; urgency=low
+
+  * Fixes some wrong path to binaries in the rootwrap config (Closes: #695791).
+
+ -- Thomas Goirand <zigo@debian.org>  Wed, 19 Dec 2012 15:57:49 +0000
+
 nova (2012.1.1-10) unstable; urgency=low
 
   * Fixes capitalization in debian/po/es.po (Nova vs nova) (Closes: #687000).
diff -Nru nova-2012.1.1/debian/patches/fixes-path-to-binaries-in-rootwrap-config.patch nova-2012.1.1/debian/patches/fixes-path-to-binaries-in-rootwrap-config.patch
--- nova-2012.1.1/debian/patches/fixes-path-to-binaries-in-rootwrap-config.patch	1970-01-01 00:00:00.000000000 +0000
+++ nova-2012.1.1/debian/patches/fixes-path-to-binaries-in-rootwrap-config.patch	2012-12-19 15:59:14.000000000 +0000
@@ -0,0 +1,36 @@
+Description: Fixes path to some binaries in the rootwrap config
+Author: Thomas Goirand <zigo@debian.org>
+Bug-Debian: http://bugs.debian.org/695791
+Forwarded: no
+
+--- nova-2012.1.1.orig/nova/rootwrap/compute.py
++++ nova-2012.1.1/nova/rootwrap/compute.py
+@@ -95,7 +95,7 @@ filterlist = [
+     # nova/network/linux_net.py: 'ip', 'addr', 'show', 'dev', interface, ..
+     # nova/network/linux_net.py: 'ip', 'link', 'set', dev, "address", ..
+     # nova/network/linux_net.py: 'ip', 'link', 'set', dev, 'up'
+-    filters.CommandFilter("/sbin/ip", "root"),
++    filters.CommandFilter("/bin/ip", "root"),
+ 
+     # nova/virt/libvirt/vif.py: 'tunctl', '-b', '-t', dev
+     # nova/network/linux_net.py: 'tunctl', '-b', '-t', dev
+@@ -113,7 +113,7 @@ filterlist = [
+     filters.CommandFilter("/bin/dd", "root"),
+ 
+     # nova/virt/xenapi/volume_utils.py: 'iscsiadm', '-m', ...
+-    filters.CommandFilter("/sbin/iscsiadm", "root"),
++    filters.CommandFilter("/usr/bin/iscsiadm", "root"),
+ 
+     # nova/virt/xenapi/vm_utils.py: "parted", "--script", ...
+     # nova/virt/xenapi/vm_utils.py: 'parted', '--script', dev_path, ..*.
+--- nova-2012.1.1.orig/nova/rootwrap/network.py
++++ nova-2012.1.1/nova/rootwrap/network.py
+@@ -36,7 +36,7 @@ filterlist = [
+     # nova/network/linux_net.py: 'ip', 'link', 'set', dev, "address", ..
+     # nova/network/linux_net.py: 'ip', 'link', 'set', dev, 'up'
+     # nova/network/linux_net.py: 'ip', 'tuntap', 'add', dev, 'mode', 'tap'
+-    filters.CommandFilter("/sbin/ip", "root"),
++    filters.CommandFilter("/bin/ip", "root"),
+ 
+     # nova/network/linux_net.py: 'ip[6]tables-save' % (cmd,), '-t', ...
+     filters.CommandFilter("/sbin/iptables-save", "root"),
diff -Nru nova-2012.1.1/debian/patches/series nova-2012.1.1/debian/patches/series
--- nova-2012.1.1/debian/patches/series	2012-09-16 07:01:27.000000000 +0000
+++ nova-2012.1.1/debian/patches/series	2012-12-19 15:59:14.000000000 +0000
@@ -5,3 +5,4 @@
 iscsiadm_path.patch
 CVE-2012-3371.patch
 CVE-2012-3447_compute-node-file-injection.patch
+fixes-path-to-binaries-in-rootwrap-config.patch

--- End Message ---
--- Begin Message --- 
On Mon, 2012-12-31 at 03:42 +0800, Thomas Goirand wrote:
> My latest upload of Nova in SID fixes some path problems in the
> rootwrap thing of Nova. Without it, Nova will fail to use the
> iscsiadm command, which is needed to mount VM volumes.
> 
> The patch (which I attached to this message) is rather trivial:
> /sbin/ip -> /bin/ip and /sbin/iscsiadm -> /usr/bin/iscsiadm

Both /sbin/ip and /bin/ip are shipped by iproute, so there doesn't seem
to have been any reason to change those? Anyway, unblocked.

Regards,

Adam

--- End Message ---
Reply to: