[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#690908: marked as done (unblock: libdatetime-timezone-perl/1.53-1+2012i)

Your message dated Sat, 29 Dec 2012 11:10:23 +0100
with message-id <[🔎] 20121229101023.GI5634@radis.cristau.org>
and subject line Re: Bug#690908: unblock: libdatetime-timezone-perl/1.51-1+2012g
has caused the Debian Bug report #690908,
regarding unblock: libdatetime-timezone-perl/1.53-1+2012i
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
690908: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=690908
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Please unblock package libdatetime-timezone-perl 1.51-1+2012g.

This release contains the data from version 2012g of the Olson
database (and some other minor changes).

I'm attaching the debdiff against 1.49-1+2012f modulo the boring changes
in the tzdata-generated files.

unblock libdatetime-timezone-perl/1.51-1+2012g

Cheers,
gregor

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJQgKU3AAoJELs6aAGGSaoG5PMQAMXurcnXfb/7k7VjH2hss4Pn
jZgEP8REDWDQFQKJVCjLw3jzCmXB6UXFTX0BW/6+piRF1P/t8siKM+ZFTkoQA1YY
ETMRu4FLelh/XI3MDvq4HF0abNAiD7XfuhyItUokEzbQtaiEYRpzi3kXO5EV9CKA
V88cDFh8+e/2x0OIptXzp5kEpYOeQUG3KgXNq6PffAfuM11J1kk1A+ueHtoA3Y0V
K2ELqdV1/axnc91aF7n8EOpjrljFum3ThgulFdRhnt2X6HD8oRmySmko8hJKma4H
jZwGAM5bshXutNtJmr96gKbvdh89jiVsV0wDp509OAfj+6bD310l0UJSXwXfpMIX
yXcaWoB6676xKijoX33L8KHDhd7/2/0QSSNbGY1Z76QdKrzzOdd8yDfprtVAhLZQ
oQd1qFuo1iQ/20TTppU1M6Li7nkXrtmY+vP9em1AbtFWmOn0GIRPRhZ3DwoqNX8w
O6LJfe7+h0ttIfYXAz79pve7/b89E5MUfsY3PPIgTUgHyS7wp8uJh/t8DIwIrh2d
WdmrYMrzHDg8RYY74diN0HcMYIlrZ1MM2ylCA10jCtdTviziVlstvhGQwQbzi15M
IUfmSITW1L/4k64GzwyV6OJx7ISIOFnSJPatZ0GJH2NHGFwDlZbQwi8NJBwi7yd/
UxO1AbTHg0ITva5TchKC
=NsgO
-----END PGP SIGNATURE-----

diff -Nru libdatetime-timezone-perl-1.49/Changes libdatetime-timezone-perl-1.51/Changes
--- libdatetime-timezone-perl-1.49/Changes	2012-09-13 16:09:12.000000000 +0200
+++ libdatetime-timezone-perl-1.51/Changes	2012-10-18 07:45:21.000000000 +0200
@@ -1,3 +1,26 @@
+1.51    2012-10-18
+
+- This release is based on version 2012g of the Olson database. This release
+  includes contemporary changes for Palestine and Samoa.
+
+
+1.50    2012-09-16
+
+- In scalar context, DateTime::TimeZone->names_in_category returned an
+  arrayref containing an arrayref (rather than _just_ an arrayref). Reported
+  by Ed Shrock. RT #76791.
+
+- The DateTime::TimeZone->names_in_category claimed that it returned names
+  based on the population of the zone. I don't think this was ever true, but
+  this data is definitely not part of the current Olson database. Reported by
+  Ed Shrock. RT #76792.
+
+  However, the DateTime::TimeZone->names_in_country method does preserve the
+  order specified in the Olson database, which is sort of based on population
+  and geography. This method is probably the best choice for presenting a list
+  of names to end user.
+
+
 1.49    2012-09-13
 
 - This release is based on version 2012f of the Olson database. This release
diff -Nru libdatetime-timezone-perl-1.49/META.json libdatetime-timezone-perl-1.51/META.json
--- libdatetime-timezone-perl-1.49/META.json	2012-09-13 16:09:12.000000000 +0200
+++ libdatetime-timezone-perl-1.51/META.json	2012-10-18 07:45:21.000000000 +0200
@@ -4,7 +4,7 @@
       "Dave Rolsky <autarch@urth.org>"
    ],
    "dynamic_config" : 1,
-   "generated_by" : "Dist::Zilla version 4.300021, CPAN::Meta::Converter version 2.120921",
+   "generated_by" : "Dist::Zilla version 4.300027, CPAN::Meta::Converter version 2.120921",
    "license" : [
       "perl_5"
    ],
@@ -19,6 +19,11 @@
             "ExtUtils::MakeMaker" : "6.30"
          }
       },
+      "develop" : {
+         "requires" : {
+            "Test::Pod" : "1.41"
+         }
+      },
       "runtime" : {
          "requires" : {
             "Class::Load" : "0",
@@ -62,6 +67,6 @@
          "web" : "http://git.urth.org/DateTime-TimeZone.git";
       }
    },
-   "version" : "1.49"
+   "version" : "1.51"
 }
 
diff -Nru libdatetime-timezone-perl-1.49/META.yml libdatetime-timezone-perl-1.51/META.yml
--- libdatetime-timezone-perl-1.49/META.yml	2012-09-13 16:09:12.000000000 +0200
+++ libdatetime-timezone-perl-1.51/META.yml	2012-10-18 07:45:21.000000000 +0200
@@ -13,7 +13,7 @@
 configure_requires:
   ExtUtils::MakeMaker: 6.30
 dynamic_config: 1
-generated_by: 'Dist::Zilla version 4.300021, CPAN::Meta::Converter version 2.120921'
+generated_by: 'Dist::Zilla version 4.300027, CPAN::Meta::Converter version 2.120921'
 license: perl
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.4.html
@@ -38,4 +38,4 @@
 resources:
   bugtracker: http://rt.cpan.org/NoAuth/Bugs.html?Dist=DateTime-TimeZone
   repository: git://git.urth.org/DateTime-TimeZone.git
-version: 1.49
+version: 1.51
diff -Nru libdatetime-timezone-perl-1.49/Makefile.PL libdatetime-timezone-perl-1.51/Makefile.PL
--- libdatetime-timezone-perl-1.49/Makefile.PL	2012-09-13 16:09:12.000000000 +0200
+++ libdatetime-timezone-perl-1.51/Makefile.PL	2012-10-18 07:45:21.000000000 +0200
@@ -43,7 +43,7 @@
     "vars" => 0,
     "warnings" => 0
   },
-  "VERSION" => "1.49",
+  "VERSION" => "1.51",
   "test" => {
     "TESTS" => "t/*.t"
   }
diff -Nru libdatetime-timezone-perl-1.49/README libdatetime-timezone-perl-1.51/README
--- libdatetime-timezone-perl-1.49/README	2012-09-13 16:09:12.000000000 +0200
+++ libdatetime-timezone-perl-1.51/README	2012-10-18 07:45:21.000000000 +0200
@@ -1,7 +1,7 @@
 
 
 This archive contains the distribution DateTime-TimeZone,
-version 1.49:
+version 1.51:
 
   Time zone object base class and factory
 
diff -Nru libdatetime-timezone-perl-1.49/debian/changelog libdatetime-timezone-perl-1.51/debian/changelog
--- libdatetime-timezone-perl-1.49/debian/changelog	2012-09-14 13:12:13.000000000 +0200
+++ libdatetime-timezone-perl-1.51/debian/changelog	2012-10-19 02:46:21.000000000 +0200
@@ -1,3 +1,9 @@
+libdatetime-timezone-perl (1:1.51-1+2012g) unstable; urgency=low
+
+  * New upstream release, based on version 2012g of the Olson database.
+
+ -- gregor herrmann <gregoa@debian.org>  Fri, 19 Oct 2012 02:46:13 +0200
+
 libdatetime-timezone-perl (1:1.49-1+2012f) unstable; urgency=low
 
   * New upstream release, based on version 2012f of the Olson database.
diff -Nru libdatetime-timezone-perl-1.49/dist.ini libdatetime-timezone-perl-1.51/dist.ini
--- libdatetime-timezone-perl-1.49/dist.ini	2012-09-13 16:09:12.000000000 +0200
+++ libdatetime-timezone-perl-1.51/dist.ini	2012-10-18 07:45:21.000000000 +0200
@@ -3,7 +3,7 @@
 license = Perl_5
 copyright_holder = Dave Rolsky
 
-version = 1.49
+version = 1.51
 
 [NextRelease]
 format = %-7v %{yyyy-MM-dd}d
diff -Nru libdatetime-timezone-perl-1.49/lib/DateTime/TimeZone.pm libdatetime-timezone-perl-1.51/lib/DateTime/TimeZone.pm
--- libdatetime-timezone-perl-1.49/lib/DateTime/TimeZone.pm	2012-09-13 16:09:12.000000000 +0200
+++ libdatetime-timezone-perl-1.51/lib/DateTime/TimeZone.pm	2012-10-18 07:45:21.000000000 +0200
@@ -1,6 +1,6 @@
 package DateTime::TimeZone;
 {
-  $DateTime::TimeZone::VERSION = '1.49';
+  $DateTime::TimeZone::VERSION = '1.51';
 }
 
 use 5.006;
@@ -525,7 +525,7 @@
 
     return wantarray
         ? @{ $DateTime::TimeZone::Catalog::CATEGORIES{ $_[0] } }
-        : [ $DateTime::TimeZone::Catalog::CATEGORIES{ $_[0] } ];
+        : $DateTime::TimeZone::Catalog::CATEGORIES{ $_[0] };
 }
 
 sub countries {
@@ -561,7 +561,7 @@
 
 =head1 VERSION
 
-version 1.49
+version 1.51
 
 =head1 SYNOPSIS
 
@@ -736,9 +736,6 @@
 "Kentucky/Monticello", and "New_York". In scalar context, it returns
 an array reference, while in list context it returns an array.
 
-The list is returned in order of population by zone, which should mean
-that this order will be the best to use for most UIs.
-
 =head2 DateTime::TimeZone->countries()
 
 Returns a sorted list of all the valid country codes (in lower-case)
@@ -755,6 +752,11 @@
 case. In scalar context, it returns an array reference, while in list
 context it returns an array.
 
+This list is returned in an order vaguely based on geography and
+population. In general, the least used zones come last, but there are not
+guarantees of a specific order from one release to the next. This order is
+probably the best option for presenting zones names to end users.
+
 =head2 DateTime::TimeZone->offset_as_seconds( $offset )
 
 Given an offset as a string, this returns the number of seconds
diff -Nru libdatetime-timezone-perl-1.49/t/15catalog.t libdatetime-timezone-perl-1.51/t/15catalog.t
--- libdatetime-timezone-perl-1.49/t/15catalog.t	2012-09-13 16:09:12.000000000 +0200
+++ libdatetime-timezone-perl-1.51/t/15catalog.t	2012-10-18 07:45:21.000000000 +0200
@@ -58,6 +58,10 @@
 
     my $names = DateTime::TimeZone::names_in_category('America');
     ok( ref $names, 'names_in_category() returns ref in scalar context' );
+    is_deeply(
+        \@names, $names,
+        'names_in_category() returns same values in list and scalar context'
+    );
 }
 
 {
diff -Nru libdatetime-timezone-perl-1.49/tools/parse_olson libdatetime-timezone-perl-1.51/tools/parse_olson
--- libdatetime-timezone-perl-1.49/tools/parse_olson	2012-09-13 16:09:12.000000000 +0200
+++ libdatetime-timezone-perl-1.51/tools/parse_olson	2012-10-18 07:45:21.000000000 +0200
@@ -431,7 +431,7 @@
         $countries .= qq|  '\L$c' => [ qw(\n|;
 
         # We explicitly do not sort these because the order in
-        # zones.tab is by population.
+        # zones.tab is already in a sane sort order.
         $countries .= join "\n",
             map {"    $_"} map { $_->[0] } @{ $countries{$c} };
         $countries .= "\n) ],\n";
@@ -527,8 +527,7 @@
 
         $zonecatalog .= "=head3 $country->[0] ($country->[1])\n\n";
 
-        for my $zone ( sort { lc $a->[0] cmp lc $b->[0] }
-            @{ $countries{ $country->[1] } } ) {
+        for my $zone ( @{ $countries{ $country->[1] } } ) {
             my $line = join ' - ', grep { defined } @{$zone};
             $zonecatalog .= "  $line\n";
         }

--- End Message ---
--- Begin Message --- 
On Fri, Oct 19, 2012 at 02:56:23 +0200, gregor herrmann wrote:

> Please unblock package libdatetime-timezone-perl 1.51-1+2012g.
> 
Unblocked 1:1.56-1+2012j.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: