Bug#696086: unblock: kdepimlibs/4:4.8.4-2
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock
Please unblock package kdepimlibs
This upload includes a fix for a loop that could get unbounded and eat up all
the memory.
It doesn not haves an entry in Debian's BTS, but we maintainers consider it
important.
$ diffstat kdepimlibs.diff
changelog | 12 ++++
patches/series | 1
patches/upstream_b92782580756b3858f0381a5200b79688ab0b0a2.diff | 29 ++++++++++
3 files changed, 42 insertions(+)
Thanks!
unblock kdepimlibs/4:4.8.4-2
-- System Information:
Debian Release: 7.0
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.21+edid (SMP w/2 CPU cores)
Locale: LANG=es_AR.UTF-8, LC_CTYPE=es_AR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
diff -Nru kdepimlibs-4.8.4/debian/changelog kdepimlibs-4.8.4/debian/changelog
--- kdepimlibs-4.8.4/debian/changelog 2012-06-09 09:22:12.000000000 -0300
+++ kdepimlibs-4.8.4/debian/changelog 2012-12-16 12:19:28.000000000 -0300
@@ -1,3 +1,15 @@
+kdepimlibs (4:4.8.4-2) unstable; urgency=low
+
+ [ Lisandro Damián Nicanor Pérez Meyer ]
+ * Team upload.
+
+ [ Pino Toscano ]
+ * Backport upstream commit f142cc25b5620c2d1037cc6cd270b1cf301b5380
+ (adapted to the 4.8 codebase) to stop reading when reaching the end of
+ streams; patch upstream_b92782580756b3858f0381a5200b79688ab0b0a2.diff.
+
+ -- Lisandro Damián Nicanor Pérez Meyer <lisandro@debian.org> Sun, 16 Dec 2012 12:19:24 -0300
+
kdepimlibs (4:4.8.4-1) unstable; urgency=low
* New upstream release.
diff -Nru kdepimlibs-4.8.4/debian/patches/series kdepimlibs-4.8.4/debian/patches/series
--- kdepimlibs-4.8.4/debian/patches/series 2012-06-09 09:20:57.000000000 -0300
+++ kdepimlibs-4.8.4/debian/patches/series 2012-12-16 12:13:33.000000000 -0300
@@ -1,2 +1,3 @@
crash_when_marking_folder_read.diff
+upstream_b92782580756b3858f0381a5200b79688ab0b0a2.diff
03_hide_akonadi_progressbar.diff
diff -Nru kdepimlibs-4.8.4/debian/patches/upstream_b92782580756b3858f0381a5200b79688ab0b0a2.diff kdepimlibs-4.8.4/debian/patches/upstream_b92782580756b3858f0381a5200b79688ab0b0a2.diff
--- kdepimlibs-4.8.4/debian/patches/upstream_b92782580756b3858f0381a5200b79688ab0b0a2.diff 1969-12-31 21:00:00.000000000 -0300
+++ kdepimlibs-4.8.4/debian/patches/upstream_b92782580756b3858f0381a5200b79688ab0b0a2.diff 2012-12-16 12:13:33.000000000 -0300
@@ -0,0 +1,29 @@
+Author: Volker Krause <vkrause@kde.org>
+Author: David Faure <faure@kde.org>
+Description: Don't keep reading when we reached the end of the stream.
+ .
+ This should prevent corrupt change replay files from eating up all your
+ memory.
+Applied-Upstream: 4.9.3, commit:f142cc25b5620c2d1037cc6cd270b1cf301b5380
+Bug: https://bugs.kde.org/show_bug.cgi?id=298257
+
+--- a/akonadi/changerecorder_p.h
++++ b/akonadi/changerecorder_p.h
+@@ -138,7 +138,7 @@ class AKONADI_TESTS_EXPORT Akonadi::Chan
+ QQueue<NotificationMessage> list;
+
+ stream >> size;
+- for ( qulonglong i = 0; i < size; ++i ) {
++ for ( qulonglong i = 0; i < size && !stream.atEnd(); ++i ) {
+ NotificationMessage msg;
+
+ stream >> sessionId;
+@@ -186,7 +186,7 @@ class AKONADI_TESTS_EXPORT Akonadi::Chan
+ QStringList list;
+
+ stream >> size;
+- for ( qulonglong i = 0; i < size; ++i ) {
++ for ( qulonglong i = 0; i < size && !stream.atEnd(); ++i ) {
+ stream >> sessionId;
+ stream >> type;
+ stream >> operation;
Reply to: