[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#694761: unblock pre-approval: python-scipy missing sources, how to proceed



On 11/30/2012 12:46 AM, Julian Taylor wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
> 
> hello,
> 
> I'm asking for advice on how to proceed with bug 589731.
> The missing sources problem there is solved in svn [1, r23110, debdiff
> attached], but the question is whether we want to regenerate the C files
> created from these sources for Wheezy.
> Wheezy is built using pregenerated C files created with cython 0.15
> whereas wheezy has cython 0.15.1, so we inevitable get different output.
> 0.15.1 is a bugfix only release so hopefully it should only get better.
> Unfortunately the diff when regenerating the sources is very large and
> pretty much unreviewable (attached see [2] for comments)
> 
> To somewhat check if everything is ok I ran a couple of quite
> thorough testsuites of rdepends (pandas, statsmodels, nipy and of
> course scipys own testsuite) with no issues.
> 
> please advise if I should request sponsorship for the version with only
> the pyx sources added to the tarball and no regeneration (svn revision
> 23110), or the version that also regenerates the c files from the pyx
> sources (svn revision 23112).
> 
> 
> 

unfortunately I found more missing source files, this time swig wrapper
files.
I have not created a proper debdiff yet, a prelimary check indicates
that the swig files account for about 800 extra lines and the
"reswigging" creates this diffstat:
They were generated with 2.0.1 and 2.0.4 vs 2.0.7 in testing
the difference is mostly bugfixes and minor enhancements according to
swig release notes.

 scipy/sparse/sparsetools/bsr.py           |  903 +++++------
 scipy/sparse/sparsetools/bsr_wrap.cxx     | 1923 ++++++++++++----------
 scipy/sparse/sparsetools/coo.py           |  235 +--
 scipy/sparse/sparsetools/coo_wrap.cxx     |  267 ++--
 scipy/sparse/sparsetools/csc.py           |  680 ++++----
 scipy/sparse/sparsetools/csc_wrap.cxx     | 1690 ++++++++++++--------
 scipy/sparse/sparsetools/csgraph.py       |   14 +-
 scipy/sparse/sparsetools/csgraph_wrap.cxx | 1030 +++++++-----
 scipy/sparse/sparsetools/csr.py           | 1116 ++++++-------
 scipy/sparse/sparsetools/csr_wrap.cxx     | 2113 ++++++++++++----------
 scipy/sparse/sparsetools/dia.py           |   78 +-
 scipy/sparse/sparsetools/dia_wrap.cxx     | 1086 ++++++++-----
 12 files changed, 6440 insertions(+), 4695 deletions(-)

Attachment: swigdiff.diff.xz
Description: application/xz


Reply to: