[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#691640: unblock: nss-pam-ldapd/0.8.10-4



Control: tag -1 - moreinfo
Control: retitle -1 unblock: nss-pam-ldapd/0.8.10-4

On Sat, 2012-12-08 at 15:17 +0100, Julien Cristau wrote:
> On Sat, Oct 27, 2012 at 23:05:06 +0200, Arthur de Jong wrote:
> > +@@ -97,39 +85,27 @@ static inline void tio_tv_prepare(struct
> > +     deadline->tv_usec=0;
> > +     return;
> > +   }
> > +-  tio_tv_add(deadline,timeout);
> > ++  deadline->tv_sec+=timeout/1000;
> > ++  deadline->tv_sec+=(timeout%1000)*1000;
> 
> Looks to me like the second line should set tv_usec, not tv_sec

Thanks for the detailed review and catching this. This didn't show up in
the tests because there is sanity checking code in place that prevents
huge timeout values that could be caused by clock jumps so luckily it
shouldn't be a severe problem in practice.

It will be fixed in the next upstream release and I've uploaded 0.8.10-4
to unstable that contains this fix.

Thanks for your hard work,

-- 
-- arthur - adejong@debian.org - http://people.debian.org/~adejong --

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: