On Mon, Nov 26, 2012 at 23:04:07 -0500, Jaldhar H. Vyas wrote: > > > >+if [ "$1" = "triggered" ]; then > >+ if [ -x "/etc/init.d/dovecot" ]; then > >+ if [ -x /usr/sbin/invoke-rc.d ]; then > >+ invoke-rc.d dovecot start > >+ else > >+ /etc/init.d/dovecot start > >+ fi > >+ fi > >+fi > > > >How can this ever work in postrm? (as far as I know only postinst can > >be called this way, and anyway starting a daemon in postrm doesn't seem > >to make much sense) > > Dovecot starts a number of daemon processes. If e.g. you removed > imapd, you might still keep the pop3d, managesieved and so on. > postrm is never called with $1 == "triggered", so afaict this is dead code. > > >The switch to triggers is not appropriate at this stage IMO anyway, and > >should be deferred to the next release. > > > > I can take it out. > Yes please. > > >The hurd fix is probably not something for right now either. > > > > Fixing FTBS on hurd was a release goal no? IIRC the bug was high > severity but if it is not considered important I can take this out. > Yes please. > >The tcp wrappers change doesn't seem appropriate either. > > > > It's only an extra cflag really but I can take it out if necessary. > Yes please. > >Not sure I'm happy about adding hardening this late. > > This was also a release goal wasn't it? > It was, but it also has potentially wide reaching implications. I suppose for a network daemon it kind of makes sense, so maybe leave it in… > > > >+ chmod 0700 debian/dovecot-core/etc/dovecot/private > > > >You seem to run dh_fixperms afterwards, because as far as I can tell the > >deb has > > > >drwxr-xr-x root/root 0 2012-11-14 23:09 ./etc/dovecot/private/ > > > > Hmm I thought it was doing the right thing but I can change it if > necessary. > Well I guess you added the chmod for a reason. Cheers, Julien
Attachment:
signature.asc
Description: Digital signature