Bug#694614: tpu: cairo-dock/3.0.0-3 (pre-approval)
tags 694614 + moreinfo
thanks
Hi,
(Disclaimer: I'm not part of the release team.)
Youhei SASAKI wrote (28 Nov 2012 11:05:58 GMT) :
> I'd like to get your approval about the upload of cairo-dock 3.0.0-3
> to testing-proposed-update in order to fix 1 RC bug and enable
> hardening build.
Thank you for the RC bugfix effort!
> - Enable hardening build
> - Update debhelper >= 9, Add dpkg-dev (>= 1.16.1~)
As much as I like the hardening effort, I think we're too late in the
freeze for such a change (unless it was explicitly requested by the
security team, maybe).
> diff -Nru cairo-dock-3.0.0/debian/patches/0001-Main-GUI-fixed-a-crash-when-hovering-group-buttons-t.patch cairo-dock-3.0.0/debian/patches/0001-Main-GUI-fixed-a-crash-when-hovering-group-buttons-t.patch
> --- cairo-dock-3.0.0/debian/patches/0001-Main-GUI-fixed-a-crash-when-hovering-group-buttons-t.patch 1970-01-01 09:00:00.000000000 +0900
> +++ cairo-dock-3.0.0/debian/patches/0001-Main-GUI-fixed-a-crash-when-hovering-group-buttons-t.patch 2012-11-27 12:15:55.000000000 +0900
> @@ -0,0 +1,47 @@
> +Description: Main GUI: fixed a crash when hovering group buttons too quickly (the dialog was not correctly destroyed)
> +Forwarded: not-needed
> +rigin: upstream, http://bazaar.launchpad.net/~cairo-dock-team/cairo-dock-core/cairo-dock/revision/1100
I guess you mean "Origin:".
> diff -Nru cairo-dock-3.0.0/debian/patches/0001-main-GUI-fix-a-case-where-the-description-dialog-pre.patch cairo-dock-3.0.0/debian/patches/0001-main-GUI-fix-a-case-where-the-description-dialog-pre.patch
> --- cairo-dock-3.0.0/debian/patches/0001-main-GUI-fix-a-case-where-the-description-dialog-pre.patch 1970-01-01 09:00:00.000000000 +0900
> +++ cairo-dock-3.0.0/debian/patches/0001-main-GUI-fix-a-case-where-the-description-dialog-pre.patch 2012-11-27 12:15:55.000000000 +0900
> @@ -0,0 +1,192 @@
> +Description: main GUI: fix a case where the description dialog&preview didn't appear when hovering the button
> +Forwarded: not-needed
> +rigin: upstream, http://bazaar.launchpad.net/~cairo-dock-team/cairo-dock-core/cairo-dock/revision/1085
Same here.
I'm not competent to review the code changes, so I won't.
Cheers,
--
intrigeri
| GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
| OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc
Reply to: