[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#694124: marked as done (jless/382-iso262-3)

Your message dated Tue, 27 Nov 2012 23:42:00 +0100
with message-id <50B541B8.4080601@thykier.net>
and subject line Re: Bug#694124: unblock: jless/382-iso262-2.1
has caused the Debian Bug report #694124,
regarding jless/382-iso262-3
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
694124: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=694124
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock package jless.

Here is a fix for serious bugs (#684633, #680632 and #433086)
with minimal changes.

diff -u jless-382-iso262/debian/changelog jless-382-iso262/debian/changelog
--- jless-382-iso262/debian/changelog
+++ jless-382-iso262/debian/changelog
@@ -1,3 +1,10 @@
+jless (382-iso262-3) unstable; urgency=low
+
+  * Fix hang-up problem with gcc optimization. (#684633, #680632)
+  * Fix abort when JLESSCHARSET is not set. (#433086)
+
+ -- Tatsuki Sugiura <sugi@nemui.org>  Sat, 24 Nov 2012 12:06:47 +0900
+
 jless (382-iso262-2.1) unstable; urgency=low
 
   * Non-maintainer upload.
diff -u jless-382-iso262/debian/patches/00list jless-382-iso262/debian/patches/00list
--- jless-382-iso262/debian/patches/00list
+++ jless-382-iso262/debian/patches/00list
@@ -6,0 +7 @@
+fix-hang-with-optimization
diff -u jless-382-iso262/debian/patches/less-382-iso259-260.dpatch jless-382-iso262/debian/patches/less-382-iso259-260.dpatch
--- jless-382-iso262/debian/patches/less-382-iso259-260.dpatch
+++ jless-382-iso262/debian/patches/less-382-iso259-260.dpatch
@@ -1963,7 +1963,7 @@
 +
 +	cs = CS2CHARSET(cs);
 +
-+	assert(0);
++	//assert(0);
 +	if (cs == ASCII || cs == JISX0201ROMAN)
 +	{
 +		assert(cvindex == 1);
@@ -1985,7 +1985,7 @@
 +		cvindex = 0;
 +		return (cvbuffer);
 +	}
-+	assert(0);
++	//assert(0);
 +	cvindex = 0;
 +	return (cvbuffer);
 +}
only in patch2:
unchanged:
--- jless-382-iso262.orig/debian/patches/fix-hang-with-optimization.dpatch
+++ jless-382-iso262/debian/patches/fix-hang-with-optimization.dpatch
@@ -0,0 +1,19 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## fix-hang-with-optimization.dpatch by  <sugi@nemui.org>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Fix hang-up problem with large file.
+
+@DPATCH@
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' '--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' jless~/ch.c jless/ch.c
+--- jless~/ch.c	2012-11-24 13:43:46.000000000 +0900
++++ jless/ch.c	2012-11-24 13:45:28.000000000 +0900
+@@ -91,7 +91,7 @@
+ 	thisfile->hashtbl[h].buf_hnext->hprev = (bp); \
+ 	thisfile->hashtbl[h].buf_hnext = (bp);
+ 
+-static struct filestate *thisfile;
++volatile static struct filestate *thisfile;
+ static int ch_ungotchar = -1;
+ static int maxbufs = -1;
+ 


unblock jless/382-iso262-2.1

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.6.6 (SMP w/4 CPU cores; PREEMPT)
Locale: LANG=en_US.utf-8, LC_CTYPE=ja_JP.utf-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

--- End Message ---
--- Begin Message --- 
On 2012-11-24 13:43, Tatsuki Sugiura wrote:
> Hello, 
> 
> Thank you for your quick comment!
> 
>>>> In Message "Re: Bug#694124: unblock: jless/382-iso262-2.1"
>>>>            <[🔎] 50B08E5D.1000708@thykier.net>,
>>>> Niels Thykier <niels@thykier.net>  said;
>>> Here is a fix for serious bugs (#684633, #680632 and #433086)
>>> with minimal changes.
>>>
> 
>> They all appear to be important and normal (versus serious)?  Anyhow,
>> that is still enough for an unblock via sid.
> 
> Oh, I consider this bug is serious for RC. So I changed severity.
> After this unblock request.
> 
>>> unblock jless/382-iso262-2.1
>>>
>>> [...]
> 
>> Looks fine, feel free to go ahead.  Please reply back to this bug once
>> the fixed version has been in sid for a couple of dates (and it has been
>> rebuilt successfully on all relevant architectures).
> 
> And I'm sorry. I mistook on the version of this request.
> I already retitled the bug to jless/382-iso262-3 by control request.
> 
> Is it OK for upload to unstable by retitling?
> Or do I need re-send new unblock request with proper version?
> 
> Regards,

Generally speaking, retitling an existing bug will be fine.

However, as I have just unblocked jless/382-iso262-3 (and thus will be
closing the bug now), there is no need to do it in this case.

Thanks for the fixes.  :)

~Niels

--- End Message ---
Reply to: