[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Please unblock libcitadel



On Tue, 27 Nov 2012 12:33:42 +0100
Michael Meskes <meskes@debian.org> wrote:

> Hi,
> 
> please unblock libcitadel that was just uploaded. 

A bug report would be better than a post to the mailing list. Follow
the template from `reportbug release.debian.org`

> It fixes a missing zero
> termination to a string. 

There's no bug report mentioned in the changelog entry and no bugs
reported in the BTS for the package.

Why should this change go into Wheezy? What are the implications? Has
it affected users or is this just theoretical?

> The other changes in the diff are merely cosmetical:
> adding quilt to apply the patch and replace configure.in with upstream's

Changing the build system is not a cosmetic change.  This is a
dpkg-source format 1.0 package - adding quilt is a major change to how
the package builds.

> version, ours had a test listed twice.
> 
> Full debdiff attached.

... which includes changes made without using the patch system you
added later in the diff... presumably because that change was made
without using a patch system. Again, no bug report for this change, no
indication of why it needs to be done in Wheezy.


-- 


Neil Williams
=============
http://www.linux.codehelp.co.uk/

Attachment: pgp9BxRM5nCFe.pgp
Description: PGP signature


Reply to: