[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#692879: Please unblock rkward



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello Thomas!

> many thanks for helping! However, a fix for this bug is already waiting for 
> approval to upload to tpu:
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692879

Indeed, I didn't notice at first that this was being worked on, I apologize.
But your patch [1] changes_0.5.7_2_3.diff gives me problems with 'cme fix dpkg-copyright' (on unstable):

- ---
Fixing from Dpkg::Copyright...
Configuration item 'Files:"rkward/qwinhost/qwinhost.cpp.orig rkward/qwinhost/qwinhost.cpp rkward/qwinhost/qwinhost.h.orig
rkward/qwinhost/qwinhost.h" License short_name' has a wrong value:
	value 'LPGL-2.1 with Nokia Qt LGPL Exception version 1.0 or GPL-3' does not match grammar:
check: <rulevar: local $found = 0> <rulevar: local $ok = 1 >
check: license alternate(s?) <reject: $text or not $found or not $ok >
alternate: comma(?) oper license
comma: ','
oper: 'and' | 'or'
license: /\S+/i
   { # PRD action to check if the license text is provided
     my $abbrev = $item[1] ;
     $found++ ;
     my $elt = $arg[0]->grab(step => "!Dpkg::Copyright License", mode => 'strict', type => 'hash') ;
     if ($elt->defined($abbrev) or $arg[0]->grab("- full_license")->fetch) {
        $ok &&= 1;
     }
     else {
     	 $ok = 0 ;
         ${$arg[1]} .= "license $abbrev is not declared in main License section. Expected ".join(" ",$elt->fetch_all_indexes) ;
     }
   }
- ---

If you change the summary line, and give a separate License: section to the LGPL exception, you can avoid that; something like what I sent at [2].

All right, I hope your fix gets through soon. I will be off to look for another RC bug.
Best regards, Laszlo

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=30;filename=changes_0.5.7_2_3.diff;att=1;bug=692879
[2] http://lists.debian.org/debian-release/2012/11/msg00899.html
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQIcBAEBAgAGBQJQsK6VAAoJEJvS1kCaDFL6TqcQAKhp7LjTfyfn2mZs0Kjxnykz
K7j5F9QJFOeh3c4CztBpQrA3CWDZACy7ZdzznIKHsNtpfBXGMrJ6Ua+0avKvc+ss
mhwR2eYLvx2UPk1L8Nm2Oge3MBmVbm03+1jGqkh3a5NoNzlRgn292/VzKKRrBmms
xI3OCkFUSvl7OqLKW73gsSI9bqyFw+ofdQHRgJlc+p5cljNx8TP3TACXDRs/EoWm
3RedMGdCTf6k0vR2LmIxZowJYE73dB0YnTFQslqL1IySfbmz94Z+UaLtZVs5wRFR
IZKn1puRYaFHv8erITZO0ClKlYTjPJWammFdu98PKIS9t84x4RIYRr2okyxE/aL2
W9cL543u1WYbKUJYyTT04rhEEIf8RMrPeJwdRn3wQIfGg4dNiciwgBlva6sjNQ0j
/FC1UtSfjBwleTRT0Y76Vq0UjCXT8k19eigXEx2adFeCsdAGr+HbNwddUaj1I6p3
V4wXd6HtIwXFMG6X0kM7Vp6vPDy6pRPhbjr4A4D+zK+vzVTLlW0ywYZyFK46lZlu
7h2alDEmpyOAJXFh/nGQtcPtpU/xQKyvnlnCM6zLtxVAG5y1h1IJISxRGPX77zN4
UBbUC1Ws2659RhSUADltN6GFMewQ7L0KcLW2LaBaBGYmR6HsU/h6HFyShd+5g9hy
GIZ+9Vl+LwjP5L3nNxXw
=NI/N
-----END PGP SIGNATURE-----


Reply to: