Bug#682172: unblock: couchdb/1.2.0-2

["Laszlo Boszormenyi (GCS)" <gcs@debian.hu>]

On Wed, 2012-11-21 at 19:36 +0100, Julien Cristau wrote:
> On Tue, Nov 20, 2012 at 21:17:21 +0000, Laszlo Boszormenyi (GCS) wrote:
> Thanks, I think that should be acceptable.
 OK, -3 will be uploaded if you nod on the s/couchdb/$COUCHDB/ change.
See below.

> > - logrotate will properly own the rotated files.
> > 
> OK, I guess.  Though why is the dir owned by couchdb in the first place
> instead of root?
 It's common for daemons to own their logdir and logfiles, even weird
owners do exist. See Apache2, its logdir is root:adm /var/log/apache2/ ,
for Exim it's Debian-exim:adm /var/log/exim4/ . But for the former, see
MongoDB: mongodb:mongodb /var/log/mongodb/ ,
MySQL: mysql:adm /var/log/mysql/ , Redis: redis:redis /var/log/redis/ .
CouchDB uses the same, its logdir is couchdb:couchdb /var/log/couchdb/ ,
can't give you a special reason for that.

> > +--- couchdb-1.2.0.orig/etc/init/couchdb.tpl.in
> > ++++ couchdb-1.2.0/etc/init/couchdb.tpl.in
> > +@@ -102,6 +102,8 @@ stop_couchdb () {
> > +     # Stop the running Apache CouchDB process.
> > + 
> > +     run_command "$COUCHDB -d" > /dev/null
> > ++    while [ $(couchdb -s 2>/dev/null | grep -c process) -eq 1 ]; \
> > ++        do echo -n .; sleep 1; done;
> > + }
> > + 
> > + display_status () {
> 
> Slightly weird to use $COUCHDB everywhere except in this one place where
> you write couchdb.
 Tested on the CLI, then copied late in the evening. Will be:
++    while [ $($COUCHDB -s 2>/dev/null | grep -c process) -eq 1 ]; \
++        do echo -n .; sleep 1; done;

Is it okay to upload -3 with the discussed changes?

Cheers,
Laszlo/GCS